Fixed collision detection.

source/World.cpp

@@ -11,6 +11,7 @@
 
 #include "sprites/Tile.h"
 #include "util/Interval.h"
+#include "util/Log.h"
 
 /**
  * Insert a drawable into the group. Drawables should only be handled with shared_ptr.
@@ -75,8 +76,19 @@ World::step(int elapsed) {
 				it--;
 			}
 			// Apply movement for movable sprites.
-			else if (spriteA->getSpeed() != sf::Vector2f()) {
-				bool overlap = false;
+			else if (spriteA->getSpeed() != sf::Vector2f() &&
+					!doesOverlap(spriteA, elapsed))
+				spriteA->setPosition(spriteA->getPosition() + speed);
+		}
+	}
+}
+
+/**
+ * Tests spriteA for overlap with every other sprite (considering collision
+ * masks).
+ */
+bool
+World::doesOverlap(std::shared_ptr<Sprite> spriteA, int elapsed) {
 	for (auto w = mDrawables.begin(); w != mDrawables.end(); w++) {
 		for (auto& spriteB : w->second) {
 			if (spriteA == spriteB)
@@ -87,15 +99,12 @@ World::step(int elapsed) {
 				continue;
 			if (testCollision(spriteA, spriteB, elapsed)) {
 				spriteA->onCollide(spriteB);
-							overlap = true;
-						}
-					}
-				}
-				if (!overlap)
-					spriteA->setPosition(spriteA->getPosition() + speed);
+				spriteB->onCollide(spriteA);
+				return true;
 			}
 		}
 	}
+	return false;
 }
 
 /**
@@ -134,7 +143,6 @@ World::testCollision(std::shared_ptr<Sprite> spriteA,
 	// circle-circle collision
 	if ((spriteA->mShape.type == Sprite::Shape::Type::CIRCLE) &&
 			(spriteB->mShape.type == Sprite::Shape::Type::CIRCLE)) {
-
 		sf::Vector2f axis = spriteA->getPosition() - spriteB->getPosition();
 		// If both objects are at the exact same position, allow any movement for unstucking.
 		if (axis == sf::Vector2f())

source/World.h

@@ -35,8 +35,9 @@ private:
 
 private:
     void draw(sf::RenderTarget& target, sf::RenderStates states) const;
-    bool testCollision(std::shared_ptr<Sprite> spriteA, std::shared_ptr<Sprite> spriteB,
-    		int elapsed) const;
+    bool testCollision(std::shared_ptr<Sprite> spriteA,
+    		std::shared_ptr<Sprite> spriteB, int elapsed) const;
+    bool doesOverlap(std::shared_ptr<Sprite> spriteA, int elapsed);
 
 private:
 	std::map<Sprite::Category, std::vector<std::shared_ptr<Sprite> > > mDrawables;

source/sprites/Tile.cpp

@@ -25,7 +25,8 @@ const sf::Vector2i Tile::TILE_SIZE = sf::Vector2i(75, 75);
  */
 Tile::Tile(Type type, int x, int y) :
 		Sprite(Data(sf::Vector2f(x * TILE_SIZE.x, y * TILE_SIZE.y),
-				CATEGORY_WORLD, isSolid(type)),	Yaml(getConfig(type))),
+				CATEGORY_WORLD, (isSolid(type)) ? 0xffff : 0),
+				Yaml(getConfig(type))),
 		mType(type) {
 }