Commit Graph

2798 Commits

Author SHA1 Message Date
Matthias Beyer bb6c4ae896 Merge pull request #750 from matthiasbeyer/libimagstore/store-tests-move-by-id-test
Libimagstore/store: tests move by id test
2016-10-04 14:30:32 +02:00
Matthias Beyer 1244a6666f Add assert to Store::get() the new ID 2016-10-03 12:34:07 +02:00
Matthias Beyer f16c09a981 Do not check whether old or new id exists/does not exist 2016-09-30 13:20:37 +02:00
Matthias Beyer 4f83b22b98 Fix Store::move_by_id(): Move in cache as well 2016-09-22 08:42:19 +02:00
Matthias Beyer caa214f1bd Fix negation error
We check whether the old key already exists.

If it does _not_ exist, the entry is borrowed, from my understanding.
I'm not sure, though.
2016-09-22 08:41:12 +02:00
Matthias Beyer d5a275fec0 Add test: Store::move_by_id() 2016-09-22 08:41:01 +02:00
Matthias Beyer 7124a1d27e Merge pull request #760 from matthiasbeyer/libimagstore/store-tests-extend-create-delete-get-test
libimagstore/store-tests: extend create delete get test
2016-09-21 12:17:33 +02:00
Matthias Beyer 61201082c8 Fix: FileAbstraction::remove_file(): Add implementation 2016-09-21 10:20:16 +02:00
Matthias Beyer babf74e1e5 Fix Store::get() to not check FS but internal hashmap 2016-09-21 10:20:16 +02:00
Matthias Beyer 4f2019a20a Extend test_store_create_delete_get()
to actually test:

1. get      -> Should return Ok(None)
2. create   -> Should return Ok(())
3. get      -> Should return Ok(Some(_))
4. delete   -> Should return Ok(())
5. get      -> Should return Ok(None)
2016-09-21 09:52:37 +02:00
Matthias Beyer 513a9bd066 Merge pull request #751 from matthiasbeyer/libimagstore/store-tests-succeeding-hook-tests
libimagstore/store: tests succeeding hook tests
2016-09-19 22:39:23 +02:00
Matthias Beyer 72a95ee5da Rewrite config validity checker to return Result<()>
And add more detailed error kinds for config errors
2016-09-19 21:52:28 +02:00
Matthias Beyer 83ebe88022 Add PreCreate hook test 2016-09-19 21:51:14 +02:00
Matthias Beyer 4155924f85 Add test for Store::retrieve_for_module() 2016-09-19 11:25:36 +02:00
Matthias Beyer fd41fe5998 Fix Store::delete() for nonexistent IDs
If the ID does not exist, we should return an error instead of doing
nothing, shouldn't we?
2016-09-19 11:07:38 +02:00
Matthias Beyer 8345ff8248 Add test to delete non-existent entries 2016-09-19 11:03:38 +02:00
Matthias Beyer 52b2a4589d Add test to get non-existent entries 2016-09-19 11:01:56 +02:00
Matthias Beyer 85097554e9 Add hook implementation for succeeding hook tests 2016-09-19 10:38:46 +02:00
Matthias Beyer 0cdeeb4c55 Fix test backend implementation
We must return an error if the file is not found here.

This is because if we unwrap() here, we panic if the store action was
Store::retrieve() and there wasn't a file there. We then unwrap() on
None and panic because of this, causing all other tests to panic as
well because the Mutex gets corrupted.

The store handles FileNotFound errors on its own, so it is safe to
return the error here.
2016-09-19 10:37:28 +02:00
Matthias Beyer d5647069cb Add test that Store::retrieve() does ::create() underneath 2016-09-09 13:07:46 +02:00
Matthias Beyer c9994c33b6 Add test whether store-internal hashmap gets actually filled on Store::create() 2016-09-09 13:07:45 +02:00
Matthias Beyer e023a856f1 Add Store testing 2016-09-09 13:07:32 +02:00
Matthias Beyer 21714660df Merge pull request #729 from matthiasbeyer/fix-header-missing-newline
Add newline before header
2016-09-09 12:54:28 +02:00
Matthias Beyer 7b827ff149 Add newline before header
The lastest release of the `toml-rs` crate (2.1) removes leading spaces
before arrays and tables, causing our tests to fail.

This fixes it.
2016-09-09 11:52:12 +02:00
Matthias Beyer e730699541 Merge pull request #725 from matthiasbeyer/libimagstore/storeid-remove-is-dir
Remove StoreId::is_dir()
2016-09-08 17:20:39 +02:00
Matthias Beyer 00acf9bb85 Merge pull request #717 from matthiasbeyer/use-result-trace-helper
Use result trace helper
2016-09-08 16:50:08 +02:00
Matthias Beyer 88ff94fb6d Remove StoreId::is_dir() 2016-09-08 15:05:25 +02:00
Matthias Beyer daca530dd5 imag-store: Use Err/Ok Result map utils to refactor code 2016-09-08 14:05:13 +02:00
Matthias Beyer a39f07f9a5 imag-diary: Use Err/Ok Result map utils to refactor code 2016-09-08 14:04:41 +02:00
Matthias Beyer 473e6d5b6a imag-notes: Use Err/Ok utils to map over results and refactor code 2016-09-08 13:57:09 +02:00
Matthias Beyer b9a9fd52c4 imag-todo: Use Err/Ok utils to map 2016-09-08 13:57:09 +02:00
Matthias Beyer 23a42dcb0d imag-link: Use Err/Ok map utility functions to refactor code 2016-09-08 13:57:09 +02:00
Matthias Beyer d5d83400fa imag-counter: Use utils to map over Err/Ok 2016-09-08 13:56:51 +02:00
Matthias Beyer 198170cf57 Merge pull request #635 from matthiasbeyer/bin/clap
Use clap in bin/imag binary.
2016-09-08 13:23:42 +02:00
Matthias Beyer 712d666ce6 Merge pull request #713 from matthiasbeyer/use-warn-exit-helper
Use warn exit helper
2016-09-08 10:56:13 +02:00
Matthias Beyer 539024781e Merge pull request #720 from mario-kr/fix_bin-target
Fix imag-bin-install target
2016-09-08 09:11:42 +02:00
Matthias Beyer 0635bffd78 imag-store: Use util fn warn_exit() 2016-09-08 08:48:58 +02:00
Matthias Beyer c91de877d0 imag-tag: Use util fn warn_exit() 2016-09-08 08:48:58 +02:00
Matthias Beyer 19711219e7 imag-diary: Use util fn warn_exit() 2016-09-08 08:48:58 +02:00
Matthias Beyer ac5ee9fb51 imag-link: Use util function warn_exit() 2016-09-08 08:48:58 +02:00
Matthias Beyer a200031eb1 imag-counter: use util function warn_exit() 2016-09-08 08:48:58 +02:00
Mario Krehl 46da70070f Fix imag-bin-install target 2016-09-07 17:09:04 +02:00
Matthias Beyer 4dca497c75 Merge pull request #718 from mario-kr/bin/clap_debug
Bin/clap debug
2016-09-07 16:45:04 +02:00
Mario Krehl 6fe4408800 Reduce clone()-ing of commands to necessary places 2016-09-07 12:57:34 +02:00
Mario Krehl e2d3e5597b Fix differing amount of newlines from subprocesses influences output 2016-09-07 12:53:38 +02:00
Mario Krehl e813ab9e3a Pretty output of --versions 2016-09-07 11:24:36 +02:00
Mario Krehl 12f9175700 Fix --versions 2016-09-07 11:14:08 +02:00
Mario Krehl d69b8498e9 Add some comments 2016-09-07 11:07:02 +02:00
Mario Krehl c828bed0e1 Fix panic! when reaching unreachable!, because imag doesnt do anything without an argument or subcommand 2016-09-07 10:37:16 +02:00
Mario Krehl 7023d1f202 Add check if given subcommand is supported 2016-09-07 10:31:00 +02:00