matthiasbeyer
/
imag
1
0
Fork 0
Code Releases Activity
2,443 Commits 1 Branch 0 Tags 6.4 MiB
Commit Graph

422 Commits

Author SHA1 Message Date
Matthias Beyer e37316f3f4 Fix possible w-lock panic 
For a detailed explanation on the issue this commit tries to solve, have
a look at

    7b5d37a039

which explains the issue in detail.
 2016-08-02 18:59:17 +02:00
Matthias Beyer 84ae516dc3 Fix possible w-lock panic 
for a detailed explanation of the issue this commit tries to solve have
a look at

    7b5d37a039

which explains the issue in detail.
 2016-08-02 18:59:17 +02:00
Matthias Beyer ea17755ad4 Fix possible w-lock panic 
for a detailed explanation have a look at

    7b5d37a039

Which explains the issue this commit solves in more detail.
 2016-08-01 20:28:38 +02:00
Matthias Beyer 7b5d37a039 Fix: Make sure we release the Write-Lock 
This was suggested by Marcel Müller, who also debugged this issue and
found that this snippet was the error.

The problem was, that we had the write-lock when starting the hooks. If
the hook runs into an Err() mapping part where the Entry could already
be drop()ed, Rust tries to be smart and drops the object. As we are
still in the creation code of the entry, this paniced as we still hold
the W-Lock and the drop() tryies to call _update() on the entry, which
also tries to W-lock it.

With the new additional scope, the W-lock gets dropped early and we do
not have this problem anymore.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Suggested-by: Marcel Müller <neikos@neikos.email>
Reported-by: Matthias Beyer <mail@beyermatthias.de>
 2016-08-01 20:00:31 +02:00
Kai Sickeler b6437a0b0f Implement Debug for FileLockEntry, do not derive it 2016-07-27 19:26:45 +02:00
Matthias Beyer 0ba67f7873 Check whether implictely creating the store path is allowed 2016-07-25 17:02:38 +02:00
Matthias Beyer 4d650a63f7 Add error kind for implicit create denied 2016-07-25 17:02:38 +02:00
Matthias Beyer 442b1537be Add helper to check config for implicit-create 2016-07-25 17:02:38 +02:00
Matthias Beyer cdf6bc6fa5 Make warning more verbose, tell what kind of variable cannot be fetched 2016-07-18 15:44:34 +02:00
Matthias Beyer ce766427da Merge pull request #561 from matthiasbeyer/libimagstore/verify 
Libimagstore/verify
 2016-07-17 13:03:54 +02:00
Matthias Beyer 6b1fdfbc1d Add Store::verify() 2016-07-17 00:59:04 +02:00
Matthias Beyer bb8dad256c Fix comment how config has to look 2016-07-16 22:17:05 +02:00
Matthias Beyer 2a95d4f79d Merge pull request #553 from matthiasbeyer/libimagstore/custom-hook-error-data-interface 
Add interface for custom error data type
 2016-07-16 19:15:39 +02:00
Matthias Beyer b81750ba09 Add interface for custom error data type 2016-07-16 16:52:02 +02:00
Matthias Beyer 01c21e1d95 Remove "Sync" trait bound - we don't need to sync between threads here 
(and we do not have the possibility to, actually).
 2016-07-16 16:18:37 +02:00
Matthias Beyer 6c181d32b6 Merge pull request #548 from matthiasbeyer/libimagstore/storeid-hook-exec-in-mutable-hook-exec 
Execute StoreIdAccess accessors in MutableHookDataAccessor impl for A…
 2016-07-16 11:23:52 +02:00
Matthias Beyer 76d23577c4 Merge pull request #546 from matthiasbeyer/libimagstore/fixed-and-more-hook-error-wrapping 
Add more error levels in hook execution error wrapping
 2016-07-16 11:23:38 +02:00
Matthias Beyer 083b9da1e9 Merge pull request #545 from matthiasbeyer/libimagstore/fix-aspect-config-getting 
Fix AspectConfig::get_for() implementation
 2016-07-16 11:23:20 +02:00
Matthias Beyer c6be35554b Merge pull request #547 from matthiasbeyer/libimagstore/aspect-execution-output 
Add error output in Aspect execution code
 2016-07-16 11:21:41 +02:00
Matthias Beyer ed4744449c Execute StoreIdAccess accessors in MutableHookDataAccessor impl for Aspect as well 
We have no other way than doing it this way, and it doesn't hurt, does
it?
 2016-07-16 01:15:48 +02:00
Matthias Beyer 6a85760feb Debug output in MutableHookDatsaAccessor impl for Aspect 2016-07-16 01:15:08 +02:00
Matthias Beyer 8de32622b9 Add more error levels in hook execution error wrapping 2016-07-16 00:57:33 +02:00
Matthias Beyer ded6a3f240 Add error output in Aspect execution code 2016-07-16 00:57:20 +02:00
Matthias Beyer c8edb2102f Fix AspectConfig::get_for() implementation 2016-07-16 00:33:54 +02:00
Matthias Beyer 32617d0a16 Add debug config when getting configuration for a hook 2016-07-16 00:32:58 +02:00
Matthias Beyer 33771f3903 Add debugging output when setting hook configuration 2016-07-16 00:32:54 +02:00
Matthias Beyer fc72b3f53a Add more debug output in Store::new() 2016-07-16 00:32:50 +02:00
John Sirois 8ef7b4e0c6 Cleanup `HookError` tracing logic. 
Use `Result::or_else` instead of matching and no-oping the `Ok` case
manually and extract a helper to centralize repeated trace logic.
 2016-07-14 20:37:16 -06:00
John Sirois 7f57e5e234 Move from a helper function to a typeclass. 
This introduces the `FoldResut` trait to move from `func(receiver, ...)`
style to `receiver.func(...)` style. Also add a means to pass the
default result explicitly.
 2016-07-14 07:28:54 -06:00
John Sirois 2c40b8734e Add a `fold_ok` utility. 
Add a utility that folds an iterator into a result and uses it to reduce
boilerplate in the codebase.
 2016-07-13 12:43:04 -06:00
Matthias Beyer 9337a14cdd Update all version strings: 0.1.0 -> 0.2.0 2016-07-12 11:51:20 +02:00
Matthias Beyer c6f9d91599 Merge pull request #513 from matthiasbeyer/libimagstore/hooks/optionally-deny-mutable-hooks 
Libimagstore/hooks/optionally deny mutable hooks
 2016-07-07 21:52:08 +02:00
Matthias Beyer 7818b523b9 Deny mutable access for hooks if the config says so 2016-07-07 20:29:24 +02:00
Matthias Beyer eb31da70d1 Remove import: trace_error() function 2016-07-07 17:03:20 +02:00
Matthias Beyer 7f14639c1e Add configuration parsing/getter for denying of mutable hooks 2016-07-06 19:10:17 +02:00
Matthias Beyer b4b719b753 Add error kind for denied hooks 2016-07-06 19:09:58 +02:00
Matthias Beyer d18766b4b4 Remove checking for aborting errors 
As the Aspect execution catches the aborting hooks and returns them, we
cannot have a non-aborting error here, so there is no point in checking
for aborting errors.
 2016-07-06 18:01:00 +02:00
Matthias Beyer 580ea28877 Fix Display impl for StoreId by using lossy string rep if PathBuf::to_str() fails 2016-07-05 13:47:58 +02:00
Matthias Beyer d7f22020e6 Merge pull request #489 from matthiasbeyer/libimagstore/storify-id 
Libimagstore/storify
 2016-07-04 19:26:42 +02:00
Matthias Beyer 9605d6daa6 Ensure that StoreId::storified() does not alter already storified StoreId objects 2016-07-04 12:49:12 +02:00
Matthias Beyer a706680fd5 Revert "Store::create() Make outgoing storeid object unstorified" 
This reverts commit 41d7d1c213.
 2016-07-04 12:46:06 +02:00
Matthias Beyer 31d5dac63d Revert "Add StoreId::unstorified()" 
This reverts commit 37380c84b9.

We do not want such a feature in the store, actually.
StoreId objects are either storified or not, but you cannot unstorify
them.
 2016-07-04 12:45:17 +02:00
Matthias Beyer 41d7d1c213 Store::create() Make outgoing storeid object unstorified 2016-07-04 12:44:58 +02:00
Matthias Beyer 9f213ddc31 Add error kind for storeid handling errors 2016-07-04 12:44:58 +02:00
Matthias Beyer 37380c84b9 Add StoreId::unstorified() 2016-07-04 12:44:58 +02:00
Matthias Beyer 12b8f8f331 Move storification of StoreId object to new StoreId::storified() func 2016-07-02 17:52:12 +02:00
Matthias Beyer ea4487a481 Impl Display for StoreId 2016-06-30 11:02:58 +02:00
Matthias Beyer 45a24de853 store.rs: Replace error boxing and wrapping with result helper from libimagerror 2016-06-27 18:16:43 +02:00
Matthias Beyer 484520842a lazyfile.rs: Replace error boxing and creation by call to new helper function 2016-06-27 18:00:12 +02:00
Matthias Beyer 0a05b9825c call helper generator macros in error module 2016-06-27 17:59:46 +02:00