matthiasbeyer/imag
1
0
Fork 0
Code Releases Activity

Execute StoreIdAccess accessors in MutableHookDataAccessor impl for Aspect as well

Browse source 
We have no other way than doing it this way, and it doesn't hurt, does
it?
This commit is contained in:
Matthias Beyer 2016-07-16 01:14:40 +02:00
parent 5a4e6b4af6
commit ed4744449c
1 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
libimagstore/src/hook/aspect.rs
View file

@ -64,23 +64,15 @@ impl MutableHookDataAccessor for Aspect {
let accessors : Vec<HDA> = self.hooks.iter().map(|h| h.accessor()).collect();
fn is_file_accessor(a: &HDA) -> bool {
is_match!(*a, HDA::MutableAccess(_) | HDA::NonMutableAccess(_))
}
if !accessors.iter().all(|a| is_file_accessor(a)) {
return Err(HE::new(HEK::AccessTypeViolation, None));
}
// TODO: Naiive implementation.
// More sophisticated version would check whether there are _chunks_ of
// NonMutableAccess accessors and execute these chunks in parallel. We do not have
// performance concerns yet, so this is okay.
accessors.iter().fold_defresult(|accessor| {
let res = match accessor {
&HDA::StoreIdAccess(ref accessor) => accessor.access(fle.get_location()),
&HDA::MutableAccess(ref accessor) => accessor.access_mut(fle),
&HDA::NonMutableAccess(ref accessor) => accessor.access(fle),
_ => unreachable!(),
};
trace_hook_errors(res)
})