LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Remove remaining usages of old activitystreams library #70

Closed
nutomic wants to merge 6 commits from more-upgrade-apub-2 into main
pull from: more-upgrade-apub-2
merge into: LemmyNet:main
Conversation 3 Commits 6 Files Changed 16 +679 -902
nutomic commented 2020-07-16 21:41:36 +00:00
Owner
Copy Link

Its ugly, but it compiles and the tests are passing.

Its ugly, but it compiles and the tests are passing.
nutomic changed title from WIP: Remove remaining usages of old activitystreams library to Remove remaining usages of old activitystreams library 2020-07-16 22:04:35 +00:00
dessalines reviewed 2020-07-17 00:57:57 +00:00
server/lemmy_db/src/schema.rs Outdated
@ -542,0 +538,4 @@
user_,
user_ban,
user_fast,
user_mention,
dessalines commented 2020-07-17 00:57:57 +00:00
Owner
Copy Link

These look weird, make sure you run cargo +nightly fmt again.

These look weird, make sure you run `cargo +nightly fmt` again.
nutomic commented 2020-07-17 11:39:57 +00:00
Author
Owner
Copy Link

Strange, I dont know why it even changed anything in the db.

Strange, I dont know why it even changed anything in the db.
dessalines reviewed 2020-07-17 01:00:50 +00:00
server/src/apub/community.rs Outdated
@ -176,0 +168,4 @@
.set_context(context())
.set_id(XsdAnyUri::from_str(&id)?)
.set_to(public())
.set_many_ccs(vec![self.get_followers_url()]);
dessalines commented 2020-07-17 01:00:50 +00:00
Owner
Copy Link

This is probably much easier than that populate_object_props for everything anyway.

This is probably much easier than that populate_object_props for everything anyway.
nutomic commented 2020-07-17 11:40:15 +00:00
Author
Owner
Copy Link

Yes with the new library its much less verbose.

Yes with the new library its much less verbose.
dessalines reviewed 2020-07-17 01:07:08 +00:00
server/src/apub/extensions/page_extension.rs Outdated
@ -12,0 +24,4 @@
fn try_into_unparsed(self, unparsed_mut: &mut U) -> Result<(), Self::Error> {
unparsed_mut.insert("commentsEnabled", self.comments_enabled)?;
unparsed_mut.insert("sensitive", self.sensitive)?;
dessalines commented 2020-07-17 01:07:08 +00:00
Owner
Copy Link

Its so tempting to add the stickied here. It'd be so much easier than using the "featured" as a separate list.

Its so tempting to add the stickied here. It'd be so much easier than using the "featured" as a separate list.
nutomic commented 2020-07-17 11:43:34 +00:00
Author
Owner
Copy Link

Hmm we could do that, its not part of the ActivityPub standard. Only thing is that we wouldnt be compatible with Mastodon, but our HTTP Signatures arent compatible with theirs either. So it might be a way to get things working, and later we do the proper, compatible implementation.

Or we just do it right from the start, its not that complicated.

Hmm we could do that, its not part of the ActivityPub standard. Only thing is that we wouldnt be compatible with Mastodon, but our HTTP Signatures arent compatible with theirs either. So it might be a way to get things working, and later we do the proper, compatible implementation. Or we just do it right from the start, its not that complicated.
dessalines commented 2020-07-17 01:12:31 +00:00
Owner
Copy Link

Looks good, all the tests passed for me too. Let me know when its good to merge.

Looks good, all the tests passed for me too. Let me know when its good to merge.
nutomic commented 2020-07-17 11:46:59 +00:00
Author
Owner
Copy Link

Rebased and formatted, should be good now.

Rebased and formatted, should be good now.
nutomic commented 2020-07-20 11:35:10 +00:00
Author
Owner
Copy Link

Merged as part of #71.

Merged as part of #71.
nutomic closed this pull request 2020-07-20 11:35:10 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#70
No description provided.
Delete Branch "more-upgrade-apub-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?