Add cache-control header to HTTP responses based on mime #41

nutomic · 2020-05-31T12:51:54Z

nutomic commented

2020-05-31 12:51:54 +00:00

Got this deployed on https://test.lemmy.ml/.

Here is an analyis, note the result for "Leverage browser caching" https://gtmetrix.com/compare/IvgJgdKn/av79Z7K6

Some notes:

I'm not sure what value we should set for the cache-control header, any suggestions?
the wrapper should be a seperate function but its really complicated with the weird types
the unwrap() should be removed, but ? doesnt work (again, weird types)

Got this deployed on https://test.lemmy.ml/. Here is an analyis, note the result for "Leverage browser caching" https://gtmetrix.com/compare/IvgJgdKn/av79Z7K6 Some notes: - I'm not sure what value we should set for the cache-control header, any suggestions? - the wrapper should be a seperate function but its really complicated with the weird types - the unwrap() should be removed, but `?` doesnt work (again, weird types)

dessalines reviewed 2020-05-31 14:50:48 +00:00

server/src/main.rs Outdated

						
				@ -54,0 +67,4 @@

				          }

				          Ok(res)

				        }

				      })

dessalines commented

2020-05-31 14:50:48 +00:00

This seems kinda messy, the only cached resources need to be the static files: https://actix.rs/docs/static-files/

There should be a way to add the cache-control header to them directly, as well as the etags / last-modified.

This seems kinda messy, the only cached resources need to be the static files: https://actix.rs/docs/static-files/ There should be a way to add the cache-control header to them directly, as well as the etags / last-modified.

nutomic commented

2020-05-31 15:05:56 +00:00

Unfortunately I couldnt find any other way. Only thing I found would apply the headers to all requests. etag/last-modified are already set by default.

dessalines commented

2020-05-31 22:24:52 +00:00

I'm asking the actix-web ppl in their gitter channel right now. Also is there any reason we couldn't do this through our nginx template,

dessalines commented

2020-05-31 22:25:24 +00:00

I think maybe it didn't work but I don't remember.

nutomic commented

2020-06-01 08:49:16 +00:00

Nginx should work, but I think its cleaner to handle this directly in Lemmy, in case people use a different reverse proxy. Or in case we want to change it in the future.

nutomic commented

2020-06-02 14:08:49 +00:00

I'm trying to clean this up by moving the lambda into a seperate function, but it always ends with the error expected bound lifetime parameter, found concrete lifetime, no idea how to fix that.

I pushed that version in case you want to have a look at it.

I'm trying to clean this up by moving the lambda into a seperate function, but it always ends with the error `expected bound lifetime parameter, found concrete lifetime`, no idea how to fix that. I pushed that version in case you want to have a look at it.

nutomic commented

2020-06-02 15:39:33 +00:00

Asked on the Rust forum about this: https://users.rust-lang.org/t/how-to-fix-expected-bound-lifetime-parameter-found-concrete-lifetime/43677