LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Forbid usage of unwrap #179

Merged
dessalines merged 1 commits from clippy-unwrap into main 2021-03-02 16:49:20 +00:00
Conversation 1 Commits 1 Files Changed 9 +38 -25
nutomic commented 2021-03-01 12:58:55 +00:00
Owner
Copy Link
No description provided.
nutomic added 2 commits 2021-03-01 12:58:59 +00:00
a5e2463097
Update README.md 
Federation is probably more complete than suggested here.

In response to:
https://github.com/LemmyNet/lemmy/issues/647#issuecomment-787068478
nutomic commented 2021-03-01 13:22:04 +00:00
Author
Owner
Copy Link

Weird, CI is showing more errors than local clippy.

Weird, CI is showing more errors than local clippy.
nutomic changed title from Forbid usage of unwrap to WIP: Forbid usage of unwrap 2021-03-01 13:22:41 +00:00
nutomic force-pushed clippy-unwrap from 838dfa271f to 5268f0b338 2021-03-01 17:32:17 +00:00 Compare
nutomic changed title from WIP: Forbid usage of unwrap to Forbid usage of unwrap 2021-03-01 17:32:22 +00:00
nutomic force-pushed clippy-unwrap from 5268f0b338 to 06085cd6d5 2021-03-01 17:53:04 +00:00 Compare
dessalines reviewed 2021-03-01 18:06:09 +00:00
.drone.yml Outdated
@ -23,6 +23,7 @@ steps:
image: ekidd/rust-musl-builder:1.47.0
commands:
- cargo clippy --workspace --tests --all-targets --all-features -- -D warnings -D deprecated -D clippy::perf -D clippy::complexity -D clippy::dbg_macro
- cargo clippy --workspace -- -D clippy::unwrap_used
dessalines commented 2021-03-01 18:05:45 +00:00
Owner
Copy Link

Why is this a 2nd command here? Why not add it to the previous?

It also didn't seem to run: https://cloud.drone.io/LemmyNet/lemmy/477/1/5

Why is this a 2nd command here? Why not add it to the previous? It also didn't seem to run: https://cloud.drone.io/LemmyNet/lemmy/477/1/5
dessalines commented 2021-03-01 18:07:22 +00:00
Owner
Copy Link

Actually nm it did run, I scrolled down.

Actually nm it did run, I scrolled down.
nutomic commented 2021-03-01 18:08:11 +00:00
Author
Owner
Copy Link

I had it in the same command before, but that also runs for tests and was failing because of that. I'm not sure if we can add comments here.

I had it in the same command before, but that also runs for tests and was failing because of that. I'm not sure if we can add comments here.
dessalines commented 2021-03-01 20:35:01 +00:00
Owner
Copy Link

Ah, that's fine then.

Ah, that's fine then.
nutomic force-pushed clippy-unwrap from 06085cd6d5 to 7f56281c26 2021-03-01 18:24:48 +00:00 Compare
dessalines merged commit 0a52396706 into main 2021-03-02 16:49:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#179
No description provided.
Delete Branch "clippy-unwrap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?