LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Remove categories (fixes #1429) #176

Merged
dessalines merged 2 commits from remove-categories into main 2021-02-25 16:35:09 +00:00
Conversation 1 Commits 2 Files Changed 32 +45 -205
nutomic commented 2021-02-25 12:18:58 +00:00
Owner
Copy Link

This is a breaking change. We also need to update the docs, api docs and javascript client.

This is a breaking change. We also need to update the docs, api docs and javascript client.
nutomic force-pushed remove-categories from be007b5638 to 3141ad31de 2021-02-25 12:22:55 +00:00 Compare
dessalines reviewed 2021-02-25 14:59:05 +00:00
migrations/2021-02-25-112959_remove-categories/down.sql Outdated
@ -0,0 +31,4 @@
('Meta'),
('Other');
ALTER TABLE community ADD category_id int references category on update cascade on delete cascade not null;
dessalines commented 2021-02-25 14:59:05 +00:00
Owner
Copy Link

Did you test this? I'd be surprised if it works since there's not a default value given (should probably be just 1). Its unavoidable but we lose all category info on the tables with this.

Did you test this? I'd be surprised if it works since there's not a default value given (should probably be just 1). Its unavoidable but we lose all category info on the tables with this.
nutomic commented 2021-02-25 15:15:44 +00:00
Author
Owner
Copy Link

I did (with diesel migration revert/run), but maybe I tested it wrong. Will add the default you suggested.

I did (with diesel migration revert/run), but maybe I tested it wrong. Will add the default you suggested.
nutomic added 1 commit 2021-02-25 15:16:42 +00:00
dessalines commented 2021-02-25 16:25:33 +00:00
Owner
Copy Link

mmk, I'll test this locally too.

mmk, I'll test this locally too.
dessalines merged commit 7c87da012e into main 2021-02-25 16:35:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#176
No description provided.
Delete Branch "remove-categories"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?