The upgraded compile SDK requires an upgrade of gradle, which introduces a
build error with api lvl <21:
> Error while processing [...]/app/src/main/res/drawable/ic_close_24dp.xml :
Invalid color value ?attr/colorControlNormal
Explanation: https://stackoverflow.com/a/49501629
Also minor NDK update
* Bump com.github.triplet.play from 2.5.0 to 2.7.5
Bumps com.github.triplet.play from 2.5.0 to 2.7.5.
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Fix com.github.triplet.play dependency setup
* gradle-wrapper.properties: Update gradle 6.0.1 > 6.2.2
from: 5ad55348b8
* build.gradle: Update "com.android.tools.build:gradle" from 3.5.3 to 3.6.3
* gradle.properties: + android.useAndroidX=true
* Migrate to AndroidX: import androidx.databinding.DataBindingUtil
* Create setenv.cmd
* Fix lint error: RtlCompat
Right-to-left text compatibility issues
../../src/main/res/layout/activity_firststart_slide1.xml:46: To support older versions than API 17 (project specifies 16) you must also specify gravity or layout_gravity="center_horizontal"
43 android:paddingLeft="@dimen/desc_padding"
44 android:paddingRight="@dimen/desc_padding"
45 android:text="@string/welcome_text"
46 android:textAlignment="center"
47 android:textColor="@android:color/white"
48 android:textSize="@dimen/slide_desc" />
49
../../src/main/res/layout/activity_firststart_slide2.xml:61: To support older versions than API 17 (project specifies 16) you must also specify gravity or layout_gravity="center_horizontal"
58 android:paddingLeft="@dimen/desc_padding"
59 android:paddingRight="@dimen/desc_padding"
60 android:text="@string/storage_permission_desc"
61 android:textAlignment="center"
62 android:textColor="@android:color/white"
63 android:textSize="@dimen/slide_desc" />
64
../../src/main/res/layout/activity_firststart_slide3.xml:61: To support older versions than API 17 (project specifies 16) you must also specify gravity or layout_gravity="center_horizontal"
58 android:paddingLeft="@dimen/desc_padding"
59 android:paddingRight="@dimen/desc_padding"
60 android:text="@string/location_permission_desc"
61 android:textAlignment="center"
62 android:textColor="@android:color/white"
63 android:textSize="@dimen/slide_desc" />
64
../../src/main/res/layout/fragment_external_versioning.xml:11: To support older versions than API 17 (project specifies 16) you must also specify gravity or layout_gravity="center_horizontal"
8 android:layout_height="wrap_content"
9 android:layout_margin="10dp"
10 android:text="@string/command"
11 android:textAlignment="center"
12 android:textColor="@android:color/black"
13 android:textSize="18sp"
14 android:textStyle="bold" />
../../src/main/res/layout/fragment_simple_versioning.xml:23: To support older versions than API 17 (project specifies 16) you must also specify gravity or layout_gravity="center_horizontal"
20 android:layout_height="wrap_content"
21 android:layout_margin="10dp"
22 android:text="@string/keep_versions"
23 android:textAlignment="center"
24 android:textColor="@android:color/black"
25 android:textSize="18sp"
26 android:textStyle="bold" />
../../src/main/res/layout/fragment_staggered_versioning.xml:17: To support older versions than API 17 (project specifies 16) you must also specify gravity or layout_gravity="center_horizontal"
14 android:layout_width="match_parent"
15 android:layout_height="wrap_content"
16 android:text="@string/maximum_age"
17 android:textAlignment="center"
18 android:textColor="@android:color/black"
19 android:textSize="18sp"
20 android:textStyle="bold"
../../src/main/res/layout/fragment_staggered_versioning.xml:44: To support older versions than API 17 (project specifies 16) you must also specify gravity or layout_gravity="center_horizontal"
41 android:layout_height="wrap_content"
42 android:layout_margin="10dp"
43 android:text="@string/versions_path"
44 android:textAlignment="center"
45 android:textColor="@android:color/black"
46 android:textSize="18sp"
47 android:textStyle="bold"
../../src/main/res/layout/fragment_trashcan_versioning.xml:23: To support older versions than API 17 (project specifies 16) you must also specify gravity or layout_gravity="center_horizontal"
* AndroidManifest: Add permission ACCESS_FINE_LOCATION
Ref.: 5755ed45ad
* Migrate to AndroidX, solves lint error "IncompatibleGradle"
according to:
- b04489e062
* Fix lint error: MissingPermission, catch SecurityException
* Revert "Create setenv.cmd"
This reverts commit e39c460837.
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Catfriend1 <Catfriend1@users.noreply.github.com>
* Bump gradle from 3.1.3 to 3.4.2
Bumps gradle from 3.1.3 to 3.4.2.
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Fix mistakes resulting in build errors after gradle upgrade
* Merge branch 'Fix718'
Merged fixes for issues #718, added functionality for all the file versioning types in the app UI.
* Basic theme is working
* GOt dialog working with setREsult.
* Addressed issues raised and fixed orientation change bug.
Adressed issues radied by nutomic:
- Changed the String concatenation so it uses String.format.
- Made members variables private that were not previously private by mistake.
- Changed name from FolderPathTextView to FolderPathTextViewFragment.
- Fixed typo in NumberPickerFragment
- Now uses TImeUnit for time conversion
- Changed from DialogFragment to a dialog themed Activity inorder to have correct themeing.
About the orientation change bug. When the dialog themed activity was open and the orientation was changed, it would cause the background activity(The FolderActivity) to
recreate itself. In the process of recreating itself it would reset the mFolder variable and then reinitialise it in the OnApiChange listener. However the result from the
Dialog was returned before the mFolder had been reinitialised and was still null, so inbetween the result being returned and the mFolder variable being reinitialised the new file versioning
configuration had to be stored and then applied to the mFolder variable in the onApiChange listener. The file versioning configuration is temporarily stored in the mVersioning variable which is
an instance of Folder.versioning.
This error only occurred when using an Activity as a dialog and using the startActivityForResult method for initialisling the activity. Before when using a dialogfragment and an interface to callback to
the parent activity, everything happend in the correct order.
* Fixed versioning dialog lag.
The initial updateFragmentView() is called in onCreate() and the
fragment is only updated when a new file versioning type is selected.
* Removed FolderPathTextViewFragment
The fragment is removed, and a helper method has been added to FolderPickerActivity to create an intent
to the the FolderPickerActivity for result.
Simon Frei
Felix Ableitner