1
0
Fork 0
mirror of https://github.com/syncthing/syncthing-android.git synced 2025-01-10 20:15:54 +00:00

Clean up config import code.

This commit is contained in:
Felix Ableitner 2015-05-18 00:10:25 +02:00
parent 91bd271302
commit d88828be82
3 changed files with 14 additions and 20 deletions

View file

@ -1,9 +1,5 @@
package com.nutomic.syncthingandroid.fragments;
import android.app.AlarmManager;
import android.app.PendingIntent;
import android.content.Context;
import android.content.Intent;
import android.content.SharedPreferences;
import android.content.pm.PackageManager;
import android.os.Bundle;
@ -20,7 +16,6 @@ import android.view.MenuItem;
import android.widget.Toast;
import com.nutomic.syncthingandroid.R;
import com.nutomic.syncthingandroid.activities.MainActivity;
import com.nutomic.syncthingandroid.activities.SyncthingActivity;
import com.nutomic.syncthingandroid.syncthing.RestApi;
import com.nutomic.syncthingandroid.syncthing.SyncthingService;
@ -290,16 +285,7 @@ public class SettingsFragment extends PreferenceFragment
if (mSyncthingService.importConfig()) {
Toast.makeText(getActivity(), getString(R.string.config_imported_successful),
Toast.LENGTH_SHORT).show();
// Restart application because API key changed
// TODO Should be nicer
Intent mStartActivity = new Intent(this.getActivity(), MainActivity.class);
int mPendingIntentId = 838465;
PendingIntent mPendingIntent = PendingIntent.getActivity(this.getActivity(),
mPendingIntentId,
mStartActivity, PendingIntent.FLAG_CANCEL_CURRENT);
AlarmManager mgr = (AlarmManager)this.getActivity().getSystemService(Context.ALARM_SERVICE);
mgr.set(AlarmManager.RTC, System.currentTimeMillis() + 100, mPendingIntent);
System.exit(0);
mSyncthingService.getApi().requireRestart(getActivity(), false);
} else {
Toast.makeText(getActivity(), getString(R.string.config_import_failed,
SyncthingService.EXPORT_PATH), Toast.LENGTH_LONG).show();

View file

@ -338,13 +338,24 @@ public class RestApi implements SyncthingService.OnWebGuiAvailableListener,
}
return json;
}
public void requireRestart(Activity activity) {
requireRestart(activity, true);
}
/**
* Sends the updated mConfig via Rest API to syncthing and displays a "restart"
* dialog or notification.
*
* @param activity The calling activity.
* @param updateConfig If true, {@link #mConfig} will be sent to `/rest/system/config`.
*/
@TargetApi(11)
public void requireRestart(Activity activity) {
new PostTask(mHttpsCertPath).execute(mUrl, PostTask.URI_CONFIG, mApiKey, mConfig.toString());
public void requireRestart(Activity activity, boolean updateConfig) {
if (updateConfig) {
new PostTask(mHttpsCertPath)
.execute(mUrl, PostTask.URI_CONFIG, mApiKey, mConfig.toString());
}
// TODO Should wait for completion...
if (mRestartPostponed)

View file

@ -513,9 +513,6 @@ public class SyncthingService extends Service {
copyFile(config, new File(getFilesDir(), ConfigXml.CONFIG_FILE));
copyFile(privateKey, new File(getFilesDir(), PRIVATE_KEY_FILE));
copyFile(publicKey, new File(getFilesDir(), PUBLIC_KEY_FILE));
startService(new Intent(this, SyncthingService.class)
.setAction(SyncthingService.ACTION_RESTART));
return true;
}