1
0
Fork 0
mirror of https://github.com/syncthing/syncthing-android.git synced 2024-12-22 10:51:28 +00:00

Make banner for TV track compliant (#2095)

App was rejected because of banner not filling the full page. I already
pushed these changes to the play store (via the release branch) to
iterate on play reviews. This was likely accepted, as the tv banner
rejection went away and now we are back to all file permission
rejection. "Likely" because it's not unimaginable that they are just
randomly ping-ponging between the two rejections.

Looks like our previous banner is not compliant with any standards that
ever existed. Ok maybe it did, definitely not now. Also it looks weird -
what's that background?
Use the adaptive icon guideline, created from the horizontal logo in the
main repo assets. Sizing is hopefully right, it took a bunch of trial
and error and ugly hacks to get there. Worst case the TV app launcher
thing will look off.

https://developer.android.com/design/ui/tv/guides/system/tv-app-icon-guidelines#adaptive-banner
This commit is contained in:
Simon Frei 2024-08-11 12:51:59 +02:00 committed by GitHub
parent 5b50f72a3d
commit c7ff674a11
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 90 additions and 1 deletions

View file

@ -35,7 +35,7 @@
android:allowBackup="false"
android:fullBackupContent="false"
android:icon="@mipmap/ic_launcher"
android:banner="@drawable/banner"
android:banner="@mipmap/ic_banner"
android:label="@string/app_name"
android:theme="@style/Theme.Syncthing"
android:description="@string/app_description"

View file

@ -0,0 +1,80 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:aapt="http://schemas.android.com/aapt"
android:width="320dp"
android:height="180dp"
android:viewportWidth="320"
android:viewportHeight="180">
<path
android:pathData="M93.9,90m-24.9,0a24.9,24.9 45,1 1,49.81 0a24.9,24.9 135,1 1,-49.81 0">
<aapt:attr name="android:fillColor">
<gradient
android:startX="93.89"
android:startY="114.87"
android:endX="93.89"
android:endY="65.1"
android:type="linear">
<item android:offset="0" android:color="#FF0882C8"/>
<item android:offset="1" android:color="#FF26B6DB"/>
</gradient>
</aapt:attr>
</path>
<path
android:pathData="M93.9,89.92m-18.54,0a18.54,18.54 0,1 1,37.08 0a18.54,18.54 0,1 1,-37.08 0"
android:strokeWidth="2.55"
android:fillColor="#00000000"
android:strokeColor="#ffffff"/>
<path
android:pathData="m109.18,85.38c1.99,0.68 4.16,-0.38 4.84,-2.38 0.68,-1.99 -0.38,-4.16 -2.38,-4.84 -1.99,-0.68 -4.16,0.38 -4.84,2.38 -0.68,1.99 0.38,4.16 2.38,4.84z"
android:fillColor="#ffffff"/>
<path
android:pathData="M110.41,81.81L97.64,92.42"
android:strokeWidth="2.55"
android:fillColor="#00000000"
android:strokeColor="#ffffff"/>
<path
android:pathData="m101.92,103.7c-0.17,2.08 1.36,3.95 3.48,4.16 2.12,0.17 3.95,-1.36 4.16,-3.48C109.73,102.3 108.2,100.44 106.08,100.22 103.96,100.05 102.09,101.58 101.92,103.7Z"
android:fillColor="#ffffff"/>
<path
android:pathData="M105.7,104.04L97.64,92.42"
android:strokeWidth="2.55"
android:fillColor="#00000000"
android:strokeColor="#ffffff"/>
<path
android:pathData="m94.45,94.5c1.15,1.78 3.52,2.29 5.26,1.15 1.78,-1.15 2.29,-3.52 1.15,-5.26 -1.15,-1.78 -3.52,-2.29 -5.26,-1.15 -1.78,1.1 -2.29,3.48 -1.15,5.26z"
android:fillColor="#ffffff"/>
<path
android:pathData="m77.99,91.15c-1.82,-1.06 -4.16,-0.47 -5.22,1.32 -1.06,1.82 -0.47,4.16 1.32,5.22 1.82,1.06 4.16,0.47 5.22,-1.32 1.06,-1.78 0.47,-4.12 -1.32,-5.22z"
android:fillColor="#ffffff"/>
<path
android:pathData="M76.04,94.41L97.64,92.42"
android:strokeWidth="2.55"
android:fillColor="#00000000"
android:strokeColor="#ffffff"/>
<path
android:pathData="m138.49,86.39c-0.25,-0.3 -2.67,-1.74 -4.84,-1.74 -1.44,0 -2.21,0.51 -2.21,1.48 0,1.23 1.36,1.57 3.78,2.21 3.48,0.93 5.64,2.12 5.64,5.47 0,4.12 -3.31,5.52 -6.79,5.52 -2.63,0 -5.56,-0.85 -7.72,-2.25l1.82,-3.65c0.34,0.34 3.18,2.12 5.94,2.12 1.48,0 2.21,-0.47 2.21,-1.36 0,-1.36 -1.87,-1.7 -4.37,-2.46 -3.35,-1.02 -4.88,-2.25 -4.88,-5.01 0,-3.82 3.05,-5.9 6.66,-5.9 2.59,0 4.92,1.06 6.53,1.99z"
android:fillColor="#0891d1"/>
<path
android:pathData="m143.24,101.2c0.72,0.21 1.4,0.34 1.87,0.34 0.85,0 1.4,-0.64 1.78,-2.33L141.84,85.84l4.16,0l3.14,9.88 2.67,-9.88l3.78,0L150.45,101.37c-0.72,2.25 -2.63,3.69 -5.01,3.73 -0.72,0 -1.48,-0.08 -2.25,-0.38l0,-3.52z"
android:fillColor="#0891d1"/>
<path
android:pathData="m170.52,99.16l-4.07,0L166.45,91.65c0,-1.74 -0.72,-2.5 -1.82,-2.5 -1.1,0 -2.46,0.98 -2.97,2.38l0,7.68l-4.07,0L157.58,85.8l3.65,0l0,2.25c0.98,-1.57 2.88,-2.5 5.18,-2.5 3.48,0 4.03,2.84 4.03,5.05l0,8.57z"
android:fillColor="#0891d1"/>
<path
android:pathData="m179.98,85.55c3.05,0 5.22,1.44 6.28,3.52l-3.99,1.19c-0.51,-0.81 -1.32,-1.27 -2.33,-1.27 -1.7,0 -2.97,1.36 -2.97,3.48 0,2.12 1.32,3.52 2.97,3.52 1.02,0 1.95,-0.55 2.33,-1.32l3.99,1.23c-0.98,2.08 -3.22,3.52 -6.28,3.52 -4.5,0 -7.17,-3.27 -7.17,-6.96 0,-3.69 2.63,-6.92 7.17,-6.92z"
android:fillColor="#0891d1"/>
<path
android:pathData="m197.16,98.48c-1.1,0.47 -2.63,0.98 -4.12,0.98 -1.99,0 -3.73,-0.98 -3.73,-3.56L189.32,88.9l-1.7,0l0,-3.1l1.7,0l0,-4.24l4.07,0l0,4.24l2.72,0l0,3.1l-2.72,0l0,5.56c0,0.89 0.51,1.23 1.19,1.23 0.59,0 1.27,-0.25 1.78,-0.47z"
android:fillColor="#0891d1"/>
<path
android:pathData="m212.05,99.16l-4.07,0L207.98,91.65c0,-1.74 -0.76,-2.5 -1.95,-2.5 -0.98,0 -2.33,0.93 -2.84,2.38l0,7.68l-4.07,0L199.12,80.58l4.07,0l0,7.47c0.98,-1.57 2.67,-2.5 4.62,-2.5 3.61,0 4.2,2.76 4.2,5.05l0,8.57z"
android:fillColor="#0891d1"/>
<path
android:pathData="m214.68,84.27l0,-3.69l4.07,0l0,3.69zM214.68,99.16L214.68,85.8l4.07,0l0,13.36z"
android:fillColor="#0891d1"/>
<path
android:pathData="m234.41,99.16l-4.07,0L230.34,91.65c0,-1.74 -0.72,-2.5 -1.82,-2.5 -1.1,0 -2.46,0.98 -2.97,2.38l0,7.68l-4.07,0L221.47,85.8l3.65,0l0,2.25c0.98,-1.57 2.88,-2.5 5.18,-2.5 3.48,0 4.03,2.84 4.03,5.05l0,8.57z"
android:fillColor="#0891d1"/>
<path
android:pathData="m236.79,92.5c0,-3.9 2.55,-6.92 6.19,-6.92 1.99,0 3.56,0.93 4.5,2.46l0,-2.21l3.52,0l0,12.43c0,4.07 -3.18,6.58 -7.72,6.58 -2.88,0 -4.88,-0.98 -6.36,-2.67l2.16,-2.21c0.98,1.1 2.55,1.82 4.2,1.82 1.95,0 3.65,-1.02 3.65,-3.52l0,-1.32c-0.81,1.48 -2.5,2.25 -4.24,2.25 -3.52,0.04 -5.9,-3.01 -5.9,-6.7zM246.93,94.16l0,-2.8c-0.55,-1.4 -1.78,-2.33 -3.01,-2.33 -1.74,0 -2.97,1.7 -2.97,3.56 0,1.95 1.36,3.39 3.18,3.39 1.23,0 2.25,-0.76 2.8,-1.82z"
android:fillColor="#0891d1"/>
</vector>

View file

@ -0,0 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
<background android:drawable="@color/ic_banner_background"/>
<foreground android:drawable="@drawable/ic_banner_foreground"/>
</adaptive-icon>

Binary file not shown.

After

Width:  |  Height:  |  Size: 10 KiB

View file

@ -0,0 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<color name="ic_banner_background">#FFFFFF</color>
</resources>