Fixed various lint warnings.

build.gradle

@@ -31,7 +31,7 @@ project.archivesBaseName = 'syncthing'
 
 android {
     compileSdkVersion 23
-    buildToolsVersion "23.0.2"
+    buildToolsVersion "23.0.3"
 
     defaultConfig {
         applicationId "com.nutomic.syncthingandroid"

lint.xml

@@ -12,6 +12,9 @@
 	platforms -->
 	<issue id="UnusedAttribute" severity="ignore" />
 
+	<!-- We don't care about Google App Indexing -->
+	<issue id="GoogleAppIndexingWarning" severity="ignore" />
+
 	<!-- Ignore types in translations (not handled by us) -->
 	<issue id="Typos">
 		<ignore path="src/main/res/values-ar" />

src/main/java/com/nutomic/syncthingandroid/activities/ToolbarBindingActivity.java

@@ -13,7 +13,7 @@ import com.nutomic.syncthingandroid.R;
  * The Toolbar must exist in the content view and have an id of R.id.toolbar.<br/>
  * Trying to call getSupportActionBar before this Activity's onPostCreate will cause a crash.
  */
-public class ToolbarBindingActivity extends AppCompatActivity {
+public abstract class ToolbarBindingActivity extends AppCompatActivity {
 
     private static final String TAG = "ToolbarBindingActivity";
 

src/main/java/com/nutomic/syncthingandroid/syncthing/BootReceiver.java

@@ -8,6 +8,9 @@ public class BootReceiver extends BroadcastReceiver {
 
     @Override
     public void onReceive(Context context, Intent intent) {
+        if (!intent.getAction().equals(Intent.ACTION_BOOT_COMPLETED))
+            return;
+
         if (!SyncthingService.alwaysRunInBackground(context))
             return;
 

src/main/java/com/nutomic/syncthingandroid/syncthing/NetworkReceiver.java

@@ -16,6 +16,10 @@ public class NetworkReceiver extends BroadcastReceiver {
 
     @Override
     public void onReceive(Context context, Intent intent) {
+        if (!intent.getAction().equals(Intent.ACTION_POWER_CONNECTED) &&
+                !intent.getAction().equals(Intent.ACTION_POWER_DISCONNECTED))
+            return;
+
         if (!SyncthingService.alwaysRunInBackground(context))
             return;
 

src/main/res/values-cs/strings.xml

@@ -19,7 +19,6 @@
   <string name="open_website">Otevřít webovou stránku</string>
   <string name="toast_write_storage_permission_required">Tato aplikace vyžaduje oprávnění pro zápis do úložiště</string>
   <string name="device_rejected">Přístroj %1$s žádá o připojení</string>
-  <string name="ignore">Ignorovat</string>
   <!--FoldersFragment-->
   <string name="folders_fragment_title">Adresáře</string>
   <!--Shown if no folders exist-->

src/main/res/values-de/strings.xml

@@ -19,7 +19,6 @@
   <string name="open_website">Webseite öffnen</string>
   <string name="toast_write_storage_permission_required">Diese App benötigt Schreibzugriff auf Ihren Gerätespeicher</string>
   <string name="device_rejected">Gerät %1$s möchte sich verbinden</string>
-  <string name="ignore">Ignorieren</string>
   <!--FoldersFragment-->
   <string name="folders_fragment_title">Verzeichnisse</string>
   <!--Shown if no folders exist-->

src/main/res/values-fr/strings.xml

@@ -19,7 +19,6 @@
   <string name="open_website">Ouvrir le site WEB</string>
   <string name="toast_write_storage_permission_required">La permission d\'écriture sur l\'espace de stockage est requise pour cette application.</string>
   <string name="device_rejected">La machine %1$s veut se connecter</string>
-  <string name="ignore">Ignorer</string>
   <!--FoldersFragment-->
   <string name="folders_fragment_title">Dossiers</string>
   <!--Shown if no folders exist-->

src/main/res/values-it/strings.xml

@@ -19,7 +19,6 @@
   <string name="open_website">Apri sito</string>
   <string name="toast_write_storage_permission_required">E\' richiesto il permesso di scrittura per questa app</string>
   <string name="device_rejected">Dispositivo %1$s vuole connettersi</string>
-  <string name="ignore">Ignora</string>
   <!--FoldersFragment-->
   <string name="folders_fragment_title">Cartelle</string>
   <!--Shown if no folders exist-->

src/main/res/values-ja/strings.xml

@@ -19,7 +19,6 @@
   <string name="open_website">Web サイトを開く</string>
   <string name="toast_write_storage_permission_required">このアプリはストレージの書き込みアクセス許可が必要です</string>
   <string name="device_rejected">デバイス %1$s が接続を求めています</string>
-  <string name="ignore">無視</string>
   <!--FoldersFragment-->
   <string name="folders_fragment_title">フォルダー</string>
   <!--Shown if no folders exist-->

src/main/res/values-nl/strings.xml

@@ -19,7 +19,6 @@
   <string name="open_website">Website openen</string>
   <string name="toast_write_storage_permission_required">Schrijftoegang is vereist voor deze applicatie</string>
   <string name="device_rejected">Apparaat %1$s wil verbinding maken</string>
-  <string name="ignore">Negeren</string>
   <!--FoldersFragment-->
   <string name="folders_fragment_title">Mappen</string>
   <!--Shown if no folders exist-->

src/main/res/values-pl/strings.xml

@@ -19,7 +19,6 @@
   <string name="open_website">Otwórz stronę internetową</string>
   <string name="toast_write_storage_permission_required">Wymagane zezwolenie na zapisywanie do pamięci zewnętrznej</string>
   <string name="device_rejected">Urządzenie %1$s chce nawiązać połączenie</string>
-  <string name="ignore">Ignoru</string>
   <!--FoldersFragment-->
   <string name="folders_fragment_title">Katalogi</string>
   <!--Shown if no folders exist-->

src/main/res/values-pt-rBR/strings.xml

@@ -19,7 +19,6 @@
   <string name="open_website">Abrir site</string>
   <string name="toast_write_storage_permission_required">A permissão de escrita em armazenamento é obrigatória para este aplicativo</string>
   <string name="device_rejected">O dispositivo %1$s quer se conectar</string>
-  <string name="ignore">Ignorar</string>
   <!--FoldersFragment-->
   <string name="folders_fragment_title">Pastas</string>
   <!--Shown if no folders exist-->

src/main/res/values-ru/strings.xml

@@ -19,7 +19,6 @@
   <string name="open_website">Открыть сайт</string>
   <string name="toast_write_storage_permission_required">Приложению требуется право на запись</string>
   <string name="device_rejected">Устройство %1$s запрашивает подключение</string>
-  <string name="ignore">Игнорировать</string>
   <!--FoldersFragment-->
   <string name="folders_fragment_title">Папки</string>
   <!--Shown if no folders exist-->

src/main/res/values-sv-rSE/strings.xml

@@ -20,7 +20,6 @@
   <string name="toast_write_storage_permission_required">Skrivlagrings tillstånd krävs för denna applikation</string>
   <string name="device_rejected">Enhet %1$s vill ansluta</string>
   <string name="folder_rejected">Enhet %1$s vill dela mapp %2$s</string>
-  <string name="ignore">Ignorera</string>
   <!--FoldersFragment-->
   <string name="folders_fragment_title">Mappar</string>
   <!--Shown if no folders exist-->

src/main/res/values-sv/strings.xml

@@ -20,7 +20,6 @@
   <string name="toast_write_storage_permission_required">Skrivlagrings tillstånd krävs för denna applikation</string>
   <string name="device_rejected">Enhet %1$s vill ansluta</string>
   <string name="folder_rejected">Enhet %1$s vill dela mappen %2$s</string>
-  <string name="ignore">Ignorera</string>
   <!--FoldersFragment-->
   <string name="folders_fragment_title">Kataloger</string>
   <!--Shown if no folders exist-->

src/main/res/values-vi/strings.xml

@@ -19,7 +19,6 @@
   <string name="open_website">Mở trang web</string>
   <string name="toast_write_storage_permission_required">Ứng dụng này cần được phép chép vào ổ lưu trữ</string>
   <string name="device_rejected">Thiết bị %1$s muốn kết nối</string>
-  <string name="ignore">Bỏ qua</string>
   <!--FoldersFragment-->
   <string name="folders_fragment_title">Các thư mục</string>
   <!--Shown if no folders exist-->

src/main/res/values-zh-rCN/strings.xml

@@ -19,7 +19,6 @@
   <string name="open_website">打开主页</string>
   <string name="toast_write_storage_permission_required">本应用需要写存储的权限</string>
   <string name="device_rejected">%1$s 想要连接</string>
-  <string name="ignore">忽略</string>
   <!--FoldersFragment-->
   <string name="folders_fragment_title">文件夹</string>
   <!--Shown if no folders exist-->

src/main/res/values/strings.xml

@@ -38,8 +38,6 @@
 
     <string name="folder_rejected">Device %1$s wants to share folder %2$s</string>
 
-    <string name="ignore">Ignore</string>
-
     <!-- FoldersFragment -->