From a000eda4e4308770de245710251dbdd1cad12a5a Mon Sep 17 00:00:00 2001 From: Felix Ableitner Date: Tue, 14 Oct 2014 15:02:50 +0300 Subject: [PATCH] Set `lenientMtimes` option on all folders (fixes #146). See syncthing/syncthing#831. --- .../syncthing/SyncthingService.java | 2 ++ .../syncthingandroid/util/ConfigXml.java | 33 +++++++++++++++++++ 2 files changed, 35 insertions(+) diff --git a/src/main/java/com/nutomic/syncthingandroid/syncthing/SyncthingService.java b/src/main/java/com/nutomic/syncthingandroid/syncthing/SyncthingService.java index f4bdbf75..b4791869 100644 --- a/src/main/java/com/nutomic/syncthingandroid/syncthing/SyncthingService.java +++ b/src/main/java/com/nutomic/syncthingandroid/syncthing/SyncthingService.java @@ -181,6 +181,8 @@ public class SyncthingService extends Service { mApi.shutdown(); Log.i(TAG, "Starting syncthing according to current state and preferences"); + mConfig = new ConfigXml(SyncthingService.this); + mConfig.updateIfNeeded(); mCurrentState = State.STARTING; registerOnWebGuiAvailableListener(mApi); new PollWebGuiAvailableTaskImpl().execute(mConfig.getWebGuiUrl()); diff --git a/src/main/java/com/nutomic/syncthingandroid/util/ConfigXml.java b/src/main/java/com/nutomic/syncthingandroid/util/ConfigXml.java index 07f2eaa6..7730a2cc 100644 --- a/src/main/java/com/nutomic/syncthingandroid/util/ConfigXml.java +++ b/src/main/java/com/nutomic/syncthingandroid/util/ConfigXml.java @@ -129,6 +129,10 @@ public class ConfigXml { r.setAttribute("directory", newDir); changed = true; } + + if (applyLenientMTimes(r)) { + changed = true; + } } // Change global announce server port to 22026 for syncthing v0.9.0. @@ -143,6 +147,35 @@ public class ConfigXml { } } + /** + * Set 'lenientMtimes' (see https://github.com/syncthing/syncthing/issues/831) on the + * given folder. + * + * @return True if the XML was changed. + */ + private boolean applyLenientMTimes(Element folder) { + NodeList childs = folder.getChildNodes(); + boolean lenientMTimesSet = false; + for (int i = 0; i < childs.getLength(); i++) { + if (childs.item(i).getNodeName().equals("lenientMtimes")) { + // Already set, do nothing (we assume that it is set to true, because nothing could + // change it (no GUI option). + lenientMTimesSet = true; + break; + } + } + + // XML tag does not exist, create it. + if (!lenientMTimesSet) { + Log.i(TAG, "Set 'lenientMtimes' on folder " + folder.getAttribute("id")); + Element newElem = mConfig.createElement("lenientMtimes"); + newElem.setTextContent(Boolean.toString(true)); + folder.appendChild(newElem); + return true; + } + return false; + } + private Element getGuiElement() { return (Element) mConfig.getDocumentElement() .getElementsByTagName("gui").item(0);