nutomic/syncthing-android
1
0
Fork 0
mirror of https://github.com/syncthing/syncthing-android.git synced 2024-11-30 00:01:19 +00:00
Code Releases Activity

Clarify todo comments

Browse source
This commit is contained in:
Lode Hoste 2015-05-23 12:46:21 +02:00
parent 2ed6dac071
commit 9e232254ab
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/androidTest/java/com/nutomic/syncthingandroid/test/syncthing/PollWebGuiAvailableTaskTest.java
View file

@ -43,6 +43,6 @@ public class PollWebGuiAvailableTaskTest extends AndroidTestCase {
}.execute(mConfig.getWebGuiUrl()); }.execute(mConfig.getWebGuiUrl());
latch.await(1, TimeUnit.SECONDS); latch.await(1, TimeUnit.SECONDS);
// TODO? SyncthingRunnable.killSyncthing(); // TODO: Unit tests fail when Syncthing is killed SyncthingRunnable.killSyncthing();
} }
} }

4
src/androidTest/java/com/nutomic/syncthingandroid/test/syncthing/RestApiTest.java
View file

@ -39,7 +39,7 @@ public class RestApiTest extends AndroidTestCase {
} }
}.execute(config.getWebGuiUrl()); }.execute(config.getWebGuiUrl());
mApi = new RestApi(getContext(), config.getWebGuiUrl(), config.getApiKey(), mApi = new RestApi(getContext(), config.getWebGuiUrl(), config.getApiKey(),
null, null, // TODO null, null,
new RestApi.OnApiAvailableListener() { new RestApi.OnApiAvailableListener() {
@Override @Override
public void onApiAvailable() { public void onApiAvailable() {
@ -52,7 +52,7 @@ public class RestApiTest extends AndroidTestCase {
@Override @Override
protected void tearDown() throws Exception { protected void tearDown() throws Exception {
super.tearDown(); super.tearDown();
// TODO? SyncthingRunnable.killSyncthing(); // TODO: Unit tests fail when Syncthing is killed SyncthingRunnable.killSyncthing();
ConfigXml.getConfigFile(new MockContext(getContext())).delete(); ConfigXml.getConfigFile(new MockContext(getContext())).delete();
} }

2
src/main/java/com/nutomic/syncthingandroid/syncthing/RestApi.java
View file

@ -356,7 +356,7 @@ public class RestApi implements SyncthingService.OnWebGuiAvailableListener,
new PostTask(mHttpsCertPath) new PostTask(mHttpsCertPath)
.execute(mUrl, PostTask.URI_CONFIG, mApiKey, mConfig.toString()); .execute(mUrl, PostTask.URI_CONFIG, mApiKey, mConfig.toString());
} }
// TODO Should wait for completion... // TODO Should wait until PostTask is completed, see #398
if (mRestartPostponed) if (mRestartPostponed)
return; return;