Always run as foreground service with "run in background" (fixes #922)

src/main/java/com/nutomic/syncthingandroid/activities/SettingsActivity.java

@@ -162,7 +162,6 @@ public class SettingsActivity extends SyncthingActivity {
 
             mUseRoot                     = (CheckBoxPreference) findPreference(Constants.PREF_USE_ROOT);
             Preference useWakelock       = findPreference(Constants.PREF_USE_WAKE_LOCK);
-            Preference foregroundService = findPreference("run_as_foreground_service");
             Preference useTor            = findPreference("use_tor");
 
             mSyncthingVersion       = findPreference("syncthing_version");
@@ -183,7 +182,6 @@ public class SettingsActivity extends SyncthingActivity {
 
             mUseRoot.setOnPreferenceClickListener(this);
             useWakelock.setOnPreferenceChangeListener((p, o) -> requireRestart());
-            foregroundService.setOnPreferenceChangeListener((p, o) -> requireRestart());
             useTor.setOnPreferenceChangeListener((p, o) -> requireRestart());
 
             try {
@@ -412,7 +410,7 @@ public class SettingsActivity extends SyncthingActivity {
 
         @Override
         public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key) {
-            if (key.equals(Constants.PREF_NOTIFICATION_TYPE) || key.equals(Constants.PREF_FOREGROUND_SERVICE)) {
+            if (key.equals(Constants.PREF_NOTIFICATION_TYPE)) {
                 mNotificationHandler.updatePersistentNotification(mSyncthingService);
             }
         }

src/main/java/com/nutomic/syncthingandroid/service/Constants.java

@@ -16,7 +16,6 @@ public class Constants {
     public static final String PREF_USE_ROOT                 = "use_root";
     public static final String PREF_NOTIFICATION_TYPE        = "notification_type";
     public static final String PREF_USE_WAKE_LOCK            = "wakelock_while_binary_running";
-    public static final String PREF_FOREGROUND_SERVICE       = "run_as_foreground_service";
 
     /**
      * Interval in ms at which the GUI is updated (eg {@link com.nutomic.syncthingandroid.fragments.DrawerFragment}).

src/main/java/com/nutomic/syncthingandroid/service/NotificationHandler.java

@@ -41,18 +41,15 @@ public class NotificationHandler {
      */
     public void updatePersistentNotification(SyncthingService service) {
         String type = mPreferences.getString(Constants.PREF_NOTIFICATION_TYPE, "low_priority");
-        boolean foreground = mPreferences.getBoolean(Constants.PREF_FOREGROUND_SERVICE, false);
 
-        // Android 8 does not allow starting service from background unless it's a foreground
+        // Always use startForeground() if app is set to always run. This makes sure the app
-        // service, so if "always run in background" is enabled, we have to use a foreground service.
+        // is not killed, and we don't miss wifi/charging events.
+        // On Android 8, this behaviour is mandatory to receive broadcasts.
         // https://stackoverflow.com/a/44505719/1837158
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && DeviceStateHolder.alwaysRunInBackground(mContext)) {
+        boolean foreground = DeviceStateHolder.alwaysRunInBackground(mContext);
-            foreground = true;
-        }
 
-        // foreground priority requires any notification
+        // Foreground priority requires a notification so this ensures that we either have a
-        // so this ensures that we either have a "default" or "low_priority" notification,
+        // "default" or "low_priority" notification, but not "none".
-        // but not "none".
         if ("none".equals(type) && foreground) {
             type = "low_priority";
         }

src/main/res/values-ca-rES/strings.xml

@@ -200,8 +200,6 @@ Ens podeu informar dels problemes que trobeu a través de Github.</string>
   <string name="export_config">Exporta la configuració</string>
   <string name="keep_wakelock_while_binary_running">Mantingues activa la CPU mentre s\'executi el Syncthing</string>
   <string name="keep_wakelock_while_binary_running_summary">Activeu-ho si experimenteu desconnexions inesperades quan treballeu amb bateria. S\'incrementarà el consum de la bateria.</string>
-  <string name="run_as_foreground_service">Executa el servei amb prioritat de primer pla</string>
-  <string name="run_as_foreground_service_summary">Si ho activeu, el Syncthing s\'executarà amb prioritat de primer pla i serà menys probable que l\'Android l\'aturi. Això pot provocar que quan quedi poca memòria lliure s\'aturin altres serveis. Degut als requeriments de l\'Android cal que es mostri una notificació de baixa prioritat, independentment de la vostra configuració de les notificacions.</string>
     <string name="use_tor_title">Utilitza Tor</string>
   <string name="use_tor_summary">Desvia tot el trànsit de dades a través de Tor per incrementar la privacitat. Es requereix Orbot</string>
   <string name="use_legacy_hashing_title">Genera els hash amb el sistema antic</string>

src/main/res/values-cs/strings.xml

@@ -174,8 +174,6 @@ Všechny zaznamenané chyby prosím hlašte přes Github.</string>
   <string name="export_config">Zálohovat nastavení</string>
   <string name="keep_wakelock_while_binary_running">Udržovat CPU aktivní pokud běží Syncthing</string>
   <string name="keep_wakelock_while_binary_running_summary">Použijte toto nastavení pokud zaznamenáváte neočekávaná ukončení spojení při běhu na baterii. Toto bude mít za následek vyšší spotřebu energie.</string>
-  <string name="run_as_foreground_service">Spustit službu na popředí</string>
-  <string name="run_as_foreground_service_summary">Pokud je povoleno, Syncthing poběží na popředí a bude méně pravděpodobné, že bude zastaven systémem Android. Toto může způsobit zastavení jiných služeb v případě nedostatku paměti. Android přesto vyžaduje zobrazení upozornění s nízkou prioritou, bez ohledu na zvolená nastavení \"Upozornění\".</string>
     <string name="use_tor_title">Použít Tor</string>
   <string name="use_tor_summary">Pro zvýšení bezpečnosti použít výhradně přenosy po síti TOR. Vyžadován Orbot</string>
   <string name="use_legacy_hashing_title">Používat standardní kontrolní součet</string>

src/main/res/values-da/strings.xml

@@ -199,8 +199,6 @@ Vær venlig at rapportere ethvert problem, du støder på, via Github. </string>
   <string name="export_config">Eksporter Konfigurering</string>
   <string name="keep_wakelock_while_binary_running">Lad CPU\'en køre imens Syncthing kører</string>
   <string name="keep_wakelock_while_binary_running_summary">Brug denne indstilling hvis du oplever uventede forbindelsesbrud imens batteriet bruges. Dette vil resultere i forøget batteriforbrug.</string>
-  <string name="run_as_foreground_service">Kør service med forgrundsprioritet</string>
-  <string name="run_as_foreground_service_summary">Hvis aktiveret, vil Syncthing køre med forgrundsprioritet og har derfor mindre chance for at blive stoppet af Android. Dette kan betyde at andre services bliver slukket hvis den tilgængelige hukommelse er for lav. En lavprioritets-notifikation skal vises grundet Android betingelser, uafhængigt af \"Notifikation\"\'s indstillingerne.</string>
     <string name="use_tor_title">Brug Tor</string>
   <string name="use_tor_summary">Tving al traffik gennem Tor for øget privatliv. Orbot er en forudsætning</string>
   <string name="use_legacy_hashing_title">Brug legacy hashing</string>

src/main/res/values-de/strings.xml

@@ -196,8 +196,6 @@ Bitte melden Sie auftretende Probleme via Github.</string>
   <string name="export_config">Konfiguration exportieren</string>
   <string name="keep_wakelock_while_binary_running">Prozessor wach halten während Syncthing läuft.</string>
   <string name="keep_wakelock_while_binary_running_summary">Nutze dieses Einstellung, wenn du unerwartete Verbindungsabbrüche hast, während du im Batteriebetrieb arbeitest. Das wird zu einem erhöhten Energieverbrauch führen.</string>
-  <string name="run_as_foreground_service">Führe Dienst mit Vordergrund-Priorität aus</string>
-  <string name="run_as_foreground_service_summary">Wenn aktiviert, wird Syncthing mit Vordergrund-Priorität ausgeführt und weniger wahrscheinlich durch Android gestoppt. Dies könnte das Stoppen anderer Dienste verursachen, wenn der verfügbare Speicher gering ist. Das Anzeigen einer Benachrichtigung niedriger Priorität wird hierfür von Android erfordert, ungeachtet der Benachrichtigung-Einstellung.</string>
     <string name="use_tor_title">Tor benutzen</string>
   <string name="use_tor_summary">Der gesamte Netzwerkverkehr wird zur Erhöhung der Privatsphäre über Tor geleitet. Benötigt Orbot.</string>
   <string name="use_legacy_hashing_title">Nutze veraltetes Hashing</string>

src/main/res/values-el/strings.xml

@@ -200,8 +200,6 @@
   <string name="export_config">Εξαγωγή ρυθμίσεων</string>
   <string name="keep_wakelock_while_binary_running">Διατήρηση της CPU σε ενεργό κατάσταση όσο εκτελείται το Syncthing</string>
   <string name="keep_wakelock_while_binary_running_summary">Χρησιμοποιήστε αυτή την επιλογή αν παρατηρείτε απρόσμενες αποσυνδέσεις κατά τη λειτουργία με μπαταρία. Θα έχει ως συνέπεια την υψηλότερη κατανάλωση ενέργειας.</string>
-  <string name="run_as_foreground_service">Εκτέλεση της υπηρεσίας με προτεραιότητα προσκηνίου.</string>
-  <string name="run_as_foreground_service_summary">Εφόσον ενεργοποιηθεί, το Syncthing θα εκτελείται με προτεραιότητα προσκηνίου και λιγότερες πιθανότητες να τερματιστεί από το Android. Ενδέχεται να τερματίζονται άλλες υπηρεσίες όταν θα εξαντλείται η διαθέσιμη μνήμη. Το Android επιβάλλει να εμφανίζεται μια ειδοποίηση χαμηλής προτεραιότητας, ανεξάρτητα από την επιλογή της ρύθμισης \"Ειδοποίηση\".</string>
     <string name="use_tor_title">Χρήση του Tor</string>
   <string name="use_tor_summary">Αναγκαστική δρομολόγηση όλης της κίνησης δεδομένων μέσω του Tor για αυξημένη ιδιωτικότητα. Προαπαιτεί το Orbot</string>
   <string name="use_legacy_hashing_title">Χρήση κατακερματισμού παλαιού τύπου</string>

src/main/res/values-es/strings.xml

@@ -178,8 +178,6 @@
   <string name="export_config">Exportar configuración</string>
   <string name="keep_wakelock_while_binary_running">Mantener la CPU activa mientras se ejecuta Syncthing</string>
   <string name="keep_wakelock_while_binary_running_summary">Usa este ajuste si experimentas desconexiones inesperadas mientras funcionas con la batería. Esto resultará en un incremento del consumo de batería.</string>
-  <string name="run_as_foreground_service">Ejecutar el servicio con prioridad de primer plano</string>
-  <string name="run_as_foreground_service_summary">Al activarse, Syncthing se ejecutará con prioridad de primer plano y es más improbable que Android lo detenga. Esto podría detener otros servicios cuando la memoria disponible sea escasa. Se mostrará una notificación de baja prioridad debido a los requerimientos de Android e independientemente de la configuración de las notificaciones.</string>
     <string name="use_tor_title">Usar Tor</string>
   <string name="use_tor_summary">Desviar todo el tráfico a través de Tor para incrementar la privacidad. Requiere Orbot</string>
   <string name="use_legacy_hashing_title">Utilizar método antiguo para generar los hash</string>

src/main/res/values-fi/strings.xml

@@ -179,8 +179,6 @@ Ilmoitathan ystävällisesti kaikista havaitsemistasi ongelmista Githubin kautta
   <string name="export_config">Vie asetukset</string>
   <string name="keep_wakelock_while_binary_running">Pidä suoritin hereillä kun Syncthing on käynnissä</string>
   <string name="keep_wakelock_while_binary_running_summary">Käytä tätä asetusta, jos yhteydet katkeilevat odottamattomasti laitteen käydessä akkuvirralla. Tämä lisää virran kulutusta.</string>
-  <string name="run_as_foreground_service">Käynnistä palvelu etualan tärkeydellä</string>
-  <string name="run_as_foreground_service_summary">Mikäli valittu, Synthing ajetaan etualan tärkeydellä, jolloin Android ei pysäytä sitä yhtä todennäköisesti. Tämä saattaa aiheuttaa sen, että muita palveluita pysäytetään jos muisti on vähissä. Matalan tärkeyden ilmoitus tulee näyttää Androidin vaatimusten mukaan huolimatta \"huomautus\"-asetuksesta.</string>
     <string name="use_tor_title">Käytä Tor-verkkoa</string>
   <string name="use_tor_summary">Pakota kaikki liikenne Tor-verkkoon yksityisyyden parantamiseksi. Vaatii Orbot-sovelluksen.</string>
   <string name="use_legacy_hashing_title">Käytä vanhaa tarkistussumman laskentaa</string>

src/main/res/values-fr/strings.xml

@@ -200,8 +200,6 @@ S\'il vous plaît, soumettez les problèmes que vous rencontrez via Github.</str
   <string name="export_config">Exporter la configuration</string>
   <string name="keep_wakelock_while_binary_running">Garder le CPU en éveil quand Syncthing fonctionne.</string>
   <string name="keep_wakelock_while_binary_running_summary">Utilisez ce paramètre si vous rencontrez des déconnexions inattendues en fonctionnant sur batterie. Il en résultera une augmentation de la consommation de la batterie.</string>
-  <string name="run_as_foreground_service">Fonctionner avec prioriré de premier plan</string>
-  <string name="run_as_foreground_service_summary">Si activé, Syncthing fonctionnera avec une priorité de premier plan et est moins susceptible d\'être arrêté par Android. Cela peut provoquer l\'arrêt d\'autres services si la mémoire disponible devient faible. En raison des exigences d\'Android, quel que soit le réglage \"Notification\", une notification de faible priorité devra être affichée.</string>
     <string name="use_tor_title">Utiliser Tor</string>
   <string name="use_tor_summary">Force tout le trafic à passer par Tor pour plus de discrétion. Nécessite Orbot.</string>
   <string name="use_legacy_hashing_title">Utiliser le hachage habituel</string>

src/main/res/values-hu/strings.xml

@@ -206,8 +206,6 @@ Néhány eszközön extra alkalmazás-leállító alkalmazást telepített fel a
   <string name="export_config">Beállítások mentése</string>
   <string name="keep_wakelock_while_binary_running">CPU ébren tartása a Syncthing futása során</string>
   <string name="keep_wakelock_while_binary_running_summary">Ezt a beállítást akkor használd, ha váratlan szakadásokat tapasztalsz akkumulátoros üzemben. Ennek hatására megnő az alkalmazás energiafelhasználása.</string>
-  <string name="run_as_foreground_service">Szolgáltatás futtatása előtérben</string>
-  <string name="run_as_foreground_service_summary">Ha engedélyezve van, akkor a Syncthing normál, nem háttérben futó prioritással fog futni, így kisebb eséllyel fogja leállítani az Android. Ennek hatására alacsony memóriaszint esetén más szolgáltatásokat fog leállítani az operációs rendszer. Az Android követelményeinek megfelelően ehhez alacsony prioritású értesítést meg kell jeleníteni, függetlenül az \"Értesítések\" beállítás tartalmától.</string>
     <string name="use_tor_title">Tor használata</string>
   <string name="use_tor_summary">A teljes forgalom átküldése a Tor hálózatán a privacy növelése érdekében. Orbot szükséges</string>
   <string name="use_legacy_hashing_title">Régi típusú hashing használata</string>

src/main/res/values-in/strings.xml

@@ -180,8 +180,6 @@ Jika ada masalah silakan laporkan lewat Github.</string>
   <string name="export_config">Ekspor Konfigurasi</string>
   <string name="keep_wakelock_while_binary_running">Buat CPU tetap aktif saat Syncthing berjalan</string>
   <string name="keep_wakelock_while_binary_running_summary">Gunakan pengaturan ini jika anda mengalami pemutusan sambungan saat beroperasi dengan baterai. Ini akan menghasilkan peningkatan konsumsi baterai.</string>
-  <string name="run_as_foreground_service">Jalankan service dengan prioritas foreground</string>
-  <string name="run_as_foreground_service_summary">Jika aktif, Syncthing akan berjalan dengan prioritas foreground dan kecil kemungkinan dihentikan oleh Android. Ini akan menyebabkan service lainnya bisa berhenti jika memori rendah. Notifikasi prioritas rendah perlu dimunculkan karena persyaratan Android, apapun pengaturan \"Notifikasi\"-nya.</string>
     <string name="use_tor_title">Gunakan Tor</string>
   <string name="use_tor_summary">Paksa semua trafik lewat Tor untuk menambah privasi. Membutuhkan Orbot.</string>
   <string name="use_legacy_hashing_title">Gunakan hashing lawas</string>

src/main/res/values-it/strings.xml

@@ -200,8 +200,6 @@ Si prega di segnalare eventuali problemi che si incontrano via Github.</string>
   <string name="export_config">Esporta Configurazione</string>
   <string name="keep_wakelock_while_binary_running">Mantieni attiva la CPU quando syncthing è in esecuzione</string>
   <string name="keep_wakelock_while_binary_running_summary">Usa questa impostazione se rilevi disconnessioni inaspettate durante il funzionamento a batteria. Questo aumenterà il consumo della batteria.</string>
-  <string name="run_as_foreground_service">Esegui il servizio con la priorità di primo piano</string>
-  <string name="run_as_foreground_service_summary">Se abilitato, Syncthing verrà eseguito con la priorità di primo piano e ha meno probabilità di essere fermato da Android. Ciò potrebbe causare l\'arresto di altri servizi se la memoria disponibile è scarsa. Una notifica a bassa priorità deve essere visualizzata a causa di requisiti di Android, a prescindere dall\'impostazione \"Notifica\".</string>
     <string name="use_tor_title">Utilizza Tor</string>
   <string name="use_tor_summary">Forza tutto il traffico attraverso Tor per una maggiore privacy. Richiede Orbot</string>
   <string name="use_legacy_hashing_title">Utilizza la funzione di hash precedente</string>

src/main/res/values-ja/strings.xml

@@ -199,8 +199,6 @@
   <string name="export_config">設定のエクスポート</string>
   <string name="keep_wakelock_while_binary_running">実行中は CPU をオンのままにする</string>
   <string name="keep_wakelock_while_binary_running_summary">バッテリーでの動作中に予期しない切断が発生する場合オンにしてください。バッテリー消費量が増える場合があります。</string>
-  <string name="run_as_foreground_service">フォアグラウンドの優先度でサービスを実行する</string>
-  <string name="run_as_foreground_service_summary">オンにすると Syncthing はフォアグラウンドの優先度で実行され、Android によって停止されにくくなります。使用可能なメモリが少ない場合、他のサービスが停止されることがあります。Android の仕様上、「通知」の設定にかかわらず低優先度の通知が表示されます。</string>
     <string name="use_tor_title">Tor を使用する</string>
   <string name="use_tor_summary">プライバシー保護のため、強制的にすべてのトラフィックを Tor を介します。Orbot が必要です</string>
   <string name="use_legacy_hashing_title">レガシーハッシュを使用する</string>

src/main/res/values-ko/strings.xml

@@ -198,8 +198,6 @@
   <string name="export_config">설정 내보내기</string>
   <string name="keep_wakelock_while_binary_running">Syncthing이 실행 중일 때 CPU를 깨어 있는 상태로 두기</string>
   <string name="keep_wakelock_while_binary_running_summary">만약 배터리로 사용중 예상하지 못한 접속 끊김이 발생 했다면 이 설정을 사용합니다. 이 기능은 배터리 소비를 늘립니다.</string>
-  <string name="run_as_foreground_service">서비스를 포그라운드로 실행</string>
-  <string name="run_as_foreground_service_summary">이 기능을 활성화하면 Syncthing은 우선순위로 작동하며 이는 Android 운영체계에 의해 중지될 가능성을 줄여줍니다. 그러나 가용 가능한 메모리가 부족할 경우 다른 서비스들이 중지될 수도 있습니다.</string>
     <string name="use_tor_title">Tor 사용</string>
   <string name="use_tor_summary">프라이버시 향상을 위해 모든 트래픽을 Tor로 통과시킵니다. Orbot이 필요합니다</string>
   <string name="use_legacy_hashing_title">레가시 해싱 쓰기</string>

src/main/res/values-nb/strings.xml

@@ -159,8 +159,6 @@
   <string name="export_config">Eksporter innstillinger</string>
   <string name="keep_wakelock_while_binary_running">Hold prosessoren våken mens Syncthing kjører</string>
   <string name="keep_wakelock_while_binary_running_summary">Bruk denne innstillingen dersom du opplever uventede frakoblinger mens enheten går på batteri. Dette vil medføre økt batteriforbruk.</string>
-  <string name="run_as_foreground_service">Kjør tjenesten med forgrunnsprioritet</string>
-  <string name="run_as_foreground_service_summary">Hvis aktivert vil Syncthing kjøre med forgrunnsprioritet og det er mindre sannsynlig at den vil bli stoppet av Android. Dette kan føre til at andre tjenester stoppes i stedet, hvis det blir lite tilgjengelig minne. En notifikasjon med lav prioritet må alltid vises uavhengig av \"Notifikasjon\" innstillingen på grunn av krav fra Android.</string>
     <!--Dialog shown before config export-->
   <string name="dialog_confirm_export">Ønsker du virkelig å eksportere innstillingene? Eksisterende filer vil bli overskrevet.\n\nADVARSEL! Andre applikasjoner kan være i stand til å lese den private nøkkelen fra sikkerhetskopien og bruke den til å laste ned eller endre synkroniserte filer.</string>
   <!--Dialog shown before config import-->

src/main/res/values-nl/strings.xml

@@ -200,8 +200,6 @@ Als je problemen tegenkomt, meld ze dan via GitHub.</string>
   <string name="export_config">Configuratie exporteren</string>
   <string name="keep_wakelock_while_binary_running">Laat de CPU niet slapen wanneer Syncthing wordt uitgevoerd</string>
   <string name="keep_wakelock_while_binary_running_summary">Gebruik deze instelling als je onverwacht losgekoppeld wordt wanneer je op batterij werkt. Dit zal leiden tot verhoogd batterijverbruik.</string>
-  <string name="run_as_foreground_service">Dienst uitvoeren met voorgrondprioriteit</string>
-  <string name="run_as_foreground_service_summary">Indien ingeschakeld zal Syncthing worden uitgevoerd met voorgrondprioriteit, waardoor de kans kleiner wordt dat het door Android wordt gestopt. Dit kan ertoe leiden dat andere diensten worden gestopt wanneer het beschikbare geheugen laag is. Een melding met lage prioriteit wordt door Android vereist weergegeven, onafhankelijk van de \"Melding\"-instelling.</string>
     <string name="use_tor_title">Gebruik Tor</string>
   <string name="use_tor_summary">Dwing alle verkeer door Tor voor verhoogde privacy</string>
   <string name="use_legacy_hashing_title">Gebruik verouderde hashing</string>

src/main/res/values-nn/strings.xml

@@ -159,8 +159,6 @@
   <string name="export_config">Eksporter innstillingar</string>
   <string name="keep_wakelock_while_binary_running">Hald prosessoren vaken medan Syncthing køyrer</string>
   <string name="keep_wakelock_while_binary_running_summary">Bruk denne innstillinga om du opplever uventa avkoplingar medan du køyrer på batteri. Dette vil føre til auka batteriforbruk.</string>
-  <string name="run_as_foreground_service">Køyr tenesten med forgrunnsprioritet</string>
-  <string name="run_as_foreground_service_summary">Dersom aktivert vil Syncthing køyre med forgrunnsprioritet og det er mindre sannsynleg at den blir stoppa av Android. Dette kan føre til at andre tenester vert stoppa i staden, dersom det blir lite tilgjengeleg minne. Ein notifikasjon med låg prioritet må alltid visast, uavhengig av \"Notifikasjon\" innstillingen på grunn av krav fra Android.</string>
     <!--Dialog shown before config export-->
   <string name="dialog_confirm_export">Vil du verkeleg eksportere innstillingane? Eksisterande filer vil verte skrivne over. \n\nÅTVARING: Andre appar kan vere i stand til å lese den private nøkkelen frå tryggingskopien, og bruke den til å laste ned eller endre synkroniserte filer.</string>
   <!--Dialog shown before config import-->

src/main/res/values-pl/strings.xml

@@ -172,8 +172,6 @@ Proszę zgłaszać napotkane błędy programu za pośrednictwem serwisu Github.<
   <string name="export_config">Eksportuj ustawienia</string>
   <string name="keep_wakelock_while_binary_running">Utrzymywanie wybudzonego CPU podczas działania</string>
   <string name="keep_wakelock_while_binary_running_summary">Używaj, jeśli doświadczasz nieoczekiwanych rozłączeń w trakcie działania na baterii. Spowoduje to zwiększone jej zużycie.</string>
-  <string name="run_as_foreground_service">Pierwszoplanowy priorytet usługi</string>
-  <string name="run_as_foreground_service_summary">Jeśli włączone, Syncthing będzie działać z pierwszoplanowym priorytetem, i istnieje mniejsza szansa że zostanie zatrzymany przez Androida. Może to jednak spowodować, że inne usługi będą wyłączone, jeśli zabraknie pamięci. Powiadomienie o niskim priorytecie musi być pokazywane ze względu na wymagania Androida, bez względu na ustawienie \"Powiadomienia\".</string>
     <string name="use_tor_title">Korzystanie z Tor</string>
   <string name="use_tor_summary">Wymusza cały ruch przez Tor dla zwiększenia prywatności. Wymaga Orbot.</string>
   <string name="use_legacy_hashing_title">Użyj starego mechanizmu haszowania</string>

src/main/res/values-pt-rBR/strings.xml

@@ -196,8 +196,6 @@ Por favor, nos avise sobre quaisquer problemas que você encontrar via Github.</
   <string name="export_config">Exportar configuração</string>
   <string name="keep_wakelock_while_binary_running">Manter a CPU acordada</string>
   <string name="keep_wakelock_while_binary_running_summary">Marque esta opção se você observar desconexões inesperadas enquanto a bateria do dispositivo não está sendo carregada. Isto resultará em maior uso da bateria.</string>
-  <string name="run_as_foreground_service">Rodar serviço com prioridade de primeiro plano</string>
-  <string name="run_as_foreground_service_summary">Se habilitado, o Syncthing rodará com prioridade de primeiro plano e tem menores chances de ser parado pelo Android. Isto pode fazer com que outros apps sejam parados caso a memória disponível fique baixa. Uma notificação de baixa prioridade precisa ser exibida por exigência do Android, independentemente da configuração \"Notificação\".</string>
     <string name="use_tor_title">Usar Tor</string>
   <string name="use_tor_summary">Forçar o tráfego de dados pela rede Tor para maior privacidade. Orbot deve ser instalado</string>
   <string name="use_legacy_hashing_title">Usar hashing legado</string>

src/main/res/values-pt/strings.xml

@@ -174,8 +174,6 @@ Reporte, através do Github, quaisquer problemas que encontre, por favor.</strin
   <string name="export_config">Exportar configuração</string>
   <string name="keep_wakelock_while_binary_running">Manter a CPU acordada enquanto o Syncthing está a correr</string>
   <string name="keep_wakelock_while_binary_running_summary">Use esta definição se experimentar desconectações inesperadas enquanto estiver a trabalhar com a bateria. Isto irá resultar num aumento do consumo da carga da bateria.</string>
-  <string name="run_as_foreground_service">Correr o serviço com prioridade de primeiro plano</string>
-  <string name="run_as_foreground_service_summary">Se estiver activado, o Syncthing irá correr com prioridade de primeiro plano e tem menos probabilidades de ser parado pelo Android. Isto pode fazer com que outros serviços parem se a memória estiver baixa. Uma notificação de baixa prioridade tem que ser apresentada por causa de exigências do Android, independentemente da definição de \"Notificação\".</string>
     <string name="use_tor_title">Utilizar o Tor</string>
   <string name="use_tor_summary">Forçar todo o tráfego através do Tor para aumentar a privacidade. Exige Orbot</string>
   <string name="use_legacy_hashing_title">Usar verificação antiga</string>

src/main/res/values-ru/strings.xml

@@ -176,8 +176,6 @@
   <string name="export_config">Экспорт настроек</string>
   <string name="keep_wakelock_while_binary_running">Поддерживать CPU включенным, пока Syncthing работает</string>
   <string name="keep_wakelock_while_binary_running_summary">Используйте эту опцию, если у вас происходят потери соединения при работе от батареи. Эта опция увеличит расход заряда батареи.</string>
-  <string name="run_as_foreground_service">Запуск сервиса с повышенным приоритетом</string>
-  <string name="run_as_foreground_service_summary">Если включено, Syncthing будет выполняться с высоким приоритетом и, скорее всего, Android не будет его останавливать. Это может вызвать остановку других сервисов в случае нехватки памяти. Уведомления с низким приоритетом должны быть показаны в связи с требованиями Android независимо от настроек \"Уведомлений\".</string>
     <string name="use_tor_title">Использовать Tor</string>
   <string name="use_tor_summary">Пропускать весь трафик через Tor для улучшения приватности. Требует установленный Orbot.</string>
   <string name="use_legacy_hashing_title">Использовать старый алгоритм хеширования</string>

src/main/res/values-sv/strings.xml

@@ -200,8 +200,6 @@ Vänligen rapportera eventuella problem du stöter på via Github.</string>
   <string name="export_config">Exportera konfiguration</string>
   <string name="keep_wakelock_while_binary_running">Håll CPU:n vaken medan Syncthing körs</string>
   <string name="keep_wakelock_while_binary_running_summary">Använd den här inställningen om du får oväntade frånkopplingar under batteridrift. Detta kommer att resultera i ökad batteriförbrukning.</string>
-  <string name="run_as_foreground_service">Kör tjänst med förgrundsprioritet</string>
-  <string name="run_as_foreground_service_summary">Om aktiverad, kommer Syncthing köra med förgrundsprioritet och är mindre sannolikt att stoppas av Android. Detta kan leda till att andra tjänster stoppas om tillgängligt minne är lågt. En låg prioritetsnotering måste visas på grund av Androidkrav, oavsett av \"notering\" inställning.</string>
     <string name="use_tor_title">Använd Tor</string>
   <string name="use_tor_summary">Tvinga all trafik genom Tor för ökad integritet. Kräver Orbot</string>
   <string name="use_legacy_hashing_title">Använd legacy hashing</string>

src/main/res/values-tr/strings.xml

@@ -174,8 +174,6 @@ Eğer herhangi bir sorunla karşılaşırsan Github aracılığıyla bildir.</st
   <string name="export_config">Yapılandırmayı Dışa Aktar</string>
   <string name="keep_wakelock_while_binary_running">Syncthing çalışırken CPU\'yu uyanık tut</string>
   <string name="keep_wakelock_while_binary_running_summary">Eğer batarya üzerinde çalışırken beklenmedik kopmalar yaşıyorsanız bu ayarı kullanın. Bu artırılmış batarya tüketimiyle sonuçlanacak.</string>
-  <string name="run_as_foreground_service">Hizmeti ön plan önceliğiyle çalıştır</string>
-  <string name="run_as_foreground_service_summary">Eğer etkinse, Syncthing ön plan önceliğiyle çalışacak ve Android tarafından daha az durdurulacak. Eğer kullanılabilir bellek düşük ise bu diğer hizmetlerin durdurulmasına neden olabilir. \"Bildirim\" ayarı ne olursa olsun, Android gereksinimleri nedeniyle düşük öncelikle bildirim gösterilir.</string>
     <string name="use_tor_title">Tor kullan</string>
   <string name="use_tor_summary">Artırılmış gizlilik için tüm trafiği Tor üzerinden yönlendir. Orbot gerektirir</string>
   <!--Dialog shown before config export-->

src/main/res/values-zh-rCN/strings.xml

@@ -201,8 +201,6 @@
   <string name="export_config">导出设置</string>
   <string name="keep_wakelock_while_binary_running">当 Syncthing 正在运行时保持 CPU 唤醒</string>
   <string name="keep_wakelock_while_binary_running_summary">使用此设置如果您在电池上运行时遇到意外的断开连接。这将会导致电量消耗的增加。</string>
-  <string name="run_as_foreground_service">以前台优先级运行服务</string>
-  <string name="run_as_foreground_service_summary">如果启用，Syncthing 将以后台优先级运行，可以更少地被 Android 停止。这也可能在可用内存过低时引起其他服务关闭。因为 Android 的要求，会忽略“通知”的设置而显示一个低优先级的通知。</string>
     <string name="use_tor_title">使用 Tor</string>
   <string name="use_tor_summary">强制所有流量通过 TOR 以提高保密性。需要 Orbot</string>
   <string name="use_legacy_hashing_title">使用传统哈希</string>

src/main/res/values/strings.xml

@@ -331,10 +331,6 @@ Please report any problems you encounter via Github.</string>
 
     <string name="keep_wakelock_while_binary_running_summary">Use this setting if you experience unexpected disconnects while operating on battery. This will result in increased battery consumption.</string>
 
-    <string name="run_as_foreground_service">Run service with foreground priority</string>
-
-    <string name="run_as_foreground_service_summary">If enabled, Syncthing will run with foreground priority and is less likely to be stopped by Android. This might cause other services to be stopped if available memory is low. A low-priority notification needs to be shown due to Android requirements, regardless of the \"Notification\" setting.</string>
-
     <string name="use_tor_title">Use Tor</string>
 
     <string name="use_tor_summary">Force all traffic through Tor for increased privacy. Requires Orbot</string>

src/main/res/xml/app_settings.xml

@@ -196,12 +196,6 @@
             android:summary="@string/keep_wakelock_while_binary_running_summary"
             android:defaultValue="false" />
 
-        <CheckBoxPreference
-            android:key="run_as_foreground_service"
-            android:title="@string/run_as_foreground_service"
-            android:summary="@string/run_as_foreground_service_summary"
-            android:defaultValue="false" />
-
         <CheckBoxPreference
             android:key="use_tor"
             android:title="@string/use_tor_title"