From 3986198fa4312e67dd5152ec338f8dc1d44ff4c1 Mon Sep 17 00:00:00 2001
From: Felix Ableitner <me@nutomic.com>
Date: Fri, 11 Sep 2015 17:24:56 +0200
Subject: [PATCH] Show confirm dialog before config import/export (fixes #456).

---
 .../fragments/SettingsFragment.java           | 47 ++++++++++++++-----
 src/main/res/values/strings.xml               |  6 +++
 2 files changed, 42 insertions(+), 11 deletions(-)

diff --git a/src/main/java/com/nutomic/syncthingandroid/fragments/SettingsFragment.java b/src/main/java/com/nutomic/syncthingandroid/fragments/SettingsFragment.java
index e4cfa68a..c9278787 100644
--- a/src/main/java/com/nutomic/syncthingandroid/fragments/SettingsFragment.java
+++ b/src/main/java/com/nutomic/syncthingandroid/fragments/SettingsFragment.java
@@ -1,5 +1,7 @@
 package com.nutomic.syncthingandroid.fragments;
 
+import android.app.AlertDialog;
+import android.content.DialogInterface;
 import android.content.SharedPreferences;
 import android.content.pm.PackageManager;
 import android.os.AsyncTask;
@@ -308,19 +310,42 @@ public class SettingsFragment extends PreferenceFragment
     public boolean onPreferenceClick(Preference preference) {
         switch (preference.getKey()) {
             case EXPORT_CONFIG:
-                mSyncthingService.exportConfig();
-                Toast.makeText(getActivity(), getString(R.string.config_export_successful,
-                        SyncthingService.EXPORT_PATH), Toast.LENGTH_LONG).show();
+                new AlertDialog.Builder(getActivity())
+                        .setMessage(R.string.dialog_confirm_export)
+                        .setPositiveButton(android.R.string.yes,
+                                new DialogInterface.OnClickListener() {
+                            @Override
+                            public void onClick(DialogInterface dialog, int which) {
+                                mSyncthingService.exportConfig();
+                                Toast.makeText(getActivity(),
+                                        getString(R.string.config_export_successful,
+                                        SyncthingService.EXPORT_PATH), Toast.LENGTH_LONG).show();
+                            }
+                        })
+                        .setNegativeButton(android.R.string.no, null)
+                        .show();
                 return true;
             case IMPORT_CONFIG:
-                if (mSyncthingService.importConfig()) {
-                    Toast.makeText(getActivity(), getString(R.string.config_imported_successful),
-                            Toast.LENGTH_SHORT).show();
-                    mSyncthingService.getApi().requireRestart(getActivity(), false);
-                } else {
-                    Toast.makeText(getActivity(), getString(R.string.config_import_failed,
-                            SyncthingService.EXPORT_PATH), Toast.LENGTH_LONG).show();
-                }
+                new AlertDialog.Builder(getActivity())
+                        .setMessage(R.string.dialog_confirm_import)
+                        .setPositiveButton(android.R.string.yes,
+                                new DialogInterface.OnClickListener() {
+                            @Override
+                            public void onClick(DialogInterface dialog, int which) {
+                                if (mSyncthingService.importConfig()) {
+                                    Toast.makeText(getActivity(),
+                                            getString(R.string.config_imported_successful),
+                                            Toast.LENGTH_SHORT).show();
+                                    mSyncthingService.getApi().requireRestart(getActivity(), false);
+                                } else {
+                                    Toast.makeText(getActivity(),
+                                            getString(R.string.config_import_failed,
+                                            SyncthingService.EXPORT_PATH), Toast.LENGTH_LONG).show();
+                                }
+                            }
+                        })
+                        .setNegativeButton(android.R.string.no, null)
+                        .show();
                 return true;
             case SYNCTHING_RESET:
                 ((SyncthingActivity) getActivity()).getApi().resetSyncthing(getActivity());
diff --git a/src/main/res/values/strings.xml b/src/main/res/values/strings.xml
index 836fcea9..2d0daef2 100644
--- a/src/main/res/values/strings.xml
+++ b/src/main/res/values/strings.xml
@@ -136,6 +136,12 @@
     <!-- Toast shown when selecting 'devices' if no devices have been added -->
     <string name="no_devices">Please connect a device first.</string>
 
+    <!-- Dialog shown before config export -->
+    <string name="dialog_confirm_export">Do you really want to export your configuration? Existing files will be overwritten.</string>
+
+    <!-- Dialog shown before config import -->
+    <string name="dialog_confirm_import">Do you really want to import a new configuration? Existing files will be overwritten.</string>
+
     <!-- DeviceSettingsFragment -->