From 3050617005f1ef42435d702ea243517c82f858ef Mon Sep 17 00:00:00 2001
From: Felix Ableitner <me@nutomic.com>
Date: Mon, 14 Oct 2024 12:42:41 +0200
Subject: [PATCH] Disable markdown plugins for url shortening and smartquotes
 (fixes #53)

---
 src/backend/api/user.rs            |  2 +-
 src/frontend/markdown.rs           |  5 ++-
 src/frontend/pages/article/edit.rs | 60 ++++++++++++++++--------------
 3 files changed, 38 insertions(+), 29 deletions(-)

diff --git a/src/backend/api/user.rs b/src/backend/api/user.rs
index 299d22d..70bad3d 100644
--- a/src/backend/api/user.rs
+++ b/src/backend/api/user.rs
@@ -99,7 +99,7 @@ fn create_cookie(jwt: String, data: &Data<IbisData>) -> Cookie<'static> {
     // Must not set cookie domain on localhost
     // https://stackoverflow.com/a/1188145
     let domain = data.domain().to_string();
-    if domain.starts_with("localhost") || domain.starts_with("127.0.0.1") {
+    if !domain.starts_with("localhost") && !domain.starts_with("127.0.0.1") {
         cookie = cookie.domain(domain);
     }
     cookie
diff --git a/src/frontend/markdown.rs b/src/frontend/markdown.rs
index b3b760b..02e8748 100644
--- a/src/frontend/markdown.rs
+++ b/src/frontend/markdown.rs
@@ -9,7 +9,10 @@ use markdown_it::{
 pub fn markdown_parser() -> MarkdownIt {
     let mut parser = MarkdownIt::new();
     markdown_it::plugins::cmark::add(&mut parser);
-    markdown_it::plugins::extra::add(&mut parser);
+    markdown_it::plugins::extra::linkify::add(&mut parser);
+    markdown_it::plugins::extra::strikethrough::add(&mut parser);
+    markdown_it::plugins::extra::tables::add(&mut parser);
+    markdown_it::plugins::extra::typographer::add(&mut parser);
     parser.inline.add_rule::<ArticleLinkScanner>();
     parser
 }
diff --git a/src/frontend/pages/article/edit.rs b/src/frontend/pages/article/edit.rs
index 1b57d5a..f75d7c4 100644
--- a/src/frontend/pages/article/edit.rs
+++ b/src/frontend/pages/article/edit.rs
@@ -131,10 +131,16 @@ pub fn EditArticle() -> impl IntoView {
                                                     })
                                             }}
 
-                                            <textarea id="edit-article-textarea" rows=rows on:keyup=move |ev| {
-                                                let val = event_target_value(&ev);
-                                                set_text.update(|p| *p = val);
-                                            }>{article.article.text.clone()}</textarea>
+                                            <textarea
+                                                id="edit-article-textarea"
+                                                rows=rows
+                                                on:keyup=move |ev| {
+                                                    let val = event_target_value(&ev);
+                                                    set_text.update(|p| *p = val);
+                                                }
+                                            >
+                                                {article.article.text.clone()}
+                                            </textarea>
                                             <div>
                                                 <a href="https://commonmark.org/help/" target="blank_">
                                                     Markdown
@@ -142,31 +148,31 @@ pub fn EditArticle() -> impl IntoView {
                                                 " formatting is supported"
                                             </div>
                                             <div class="inputs">
-                                            <input
-                                                type="text"
-                                                placeholder="Edit summary"
-                                                value=summary.get_untracked()
-                                                on:keyup=move |ev| {
-                                                    let val = event_target_value(&ev);
-                                                    set_summary.update(|p| *p = val);
-                                                }
-                                            />
+                                                <input
+                                                    type="text"
+                                                    placeholder="Edit summary"
+                                                    value=summary.get_untracked()
+                                                    on:keyup=move |ev| {
+                                                        let val = event_target_value(&ev);
+                                                        set_summary.update(|p| *p = val);
+                                                    }
+                                                />
 
-                                            <button
-                                                prop:disabled=move || button_is_disabled.get()
-                                                on:click=move |_| {
-                                                    submit_action
-                                                        .dispatch((
-                                                            text.get(),
-                                                            summary.get(),
-                                                            article_.clone(),
-                                                            edit_response.get(),
-                                                        ))
-                                                }
-                                            >
+                                                <button
+                                                    prop:disabled=move || button_is_disabled.get()
+                                                    on:click=move |_| {
+                                                        submit_action
+                                                            .dispatch((
+                                                                text.get(),
+                                                                summary.get(),
+                                                                article_.clone(),
+                                                                edit_response.get(),
+                                                            ))
+                                                    }
+                                                >
 
-                                                Submit
-                                            </button>
+                                                    Submit
+                                                </button>
                                             </div>
                                         </div>
                                     }