Commit Graph

2793 Commits

Author SHA1 Message Date
Matthias Beyer 66782ca87b Refactor file opening in helper function 2016-09-06 15:31:55 +02:00
Matthias Beyer 46123622b2 Have and use internal error types for better error messages 2016-09-06 15:31:55 +02:00
Matthias Beyer 04166dd7a3 Import libimagerror with macros, so we can have own error types internally 2016-09-06 15:31:55 +02:00
Matthias Beyer 95b77d7c92 When generating an error code, we should allow dead code here 2016-09-06 15:31:55 +02:00
Matthias Beyer 144a8bf897 Flock hook: Rewrite EntryFlock trait to return HookResult 2016-09-06 15:31:55 +02:00
Matthias Beyer af4a0bfaf2 Export result-helper here 2016-09-06 15:31:55 +02:00
Matthias Beyer a6377f322e Fix Ref::get_path_hash() to use ::into_pathbuf() 2016-09-06 15:31:55 +02:00
Matthias Beyer a53adb854d Use StoreId::into_pathbuf() rather than ::into() 2016-09-06 15:31:55 +02:00
Matthias Beyer 5f04d29345 Adapt store to not use StoreId::into() but new StoreId::into_pathbuf() 2016-09-06 15:31:55 +02:00
Matthias Beyer a313cede06 Add StoreId::into_pathbuf() 2016-09-06 15:31:55 +02:00
Matthias Beyer b8f612632d Add error kind if StoreId has no base part 2016-09-06 15:31:29 +02:00
Matthias Beyer 84b279de95 Remove Into<PathBuf> for StoreId 2016-09-06 15:31:29 +02:00
Matthias Beyer 40014051ec Bugfix: unique()ing the list of links
That should happen _after_ they are all in the same format.
This commit introduces overhead, as we clone() each string here for
comparison and that should clearly be fixed.

Though the bug-fix is more important at this point.
2016-09-06 15:30:26 +02:00
Matthias Beyer 584ac3d46e Fix link test to check properly 2016-09-06 15:30:26 +02:00
Matthias Beyer 2e6f833bf2 Add test for linking the same entries twice 2016-09-06 15:30:26 +02:00
Matthias Beyer 60de2eefec Fix store id specification 2016-09-06 15:30:26 +02:00
Matthias Beyer 47c5b7edf3 Fix string-compare 2016-09-06 15:30:26 +02:00
Matthias Beyer 73d05d80ae Remove version part from IDs 2016-09-06 15:30:26 +02:00
Matthias Beyer 4456c4240e Merge pull request #709 from matthiasbeyer/libimagstore/test-fixup
Fix absolute StoreId specification in imag-store test
2016-09-06 13:53:06 +02:00
Matthias Beyer aa7e050436 Merge pull request #707 from matthiasbeyer/libimagstore/remove-storeid-storified
Remove StoreId::storified()
2016-09-06 12:31:01 +02:00
Matthias Beyer 5ed60f48cd Print errors (dbg) when import_task() failed 2016-09-06 12:03:27 +02:00
Matthias Beyer d7447a64c8 Remove StoreId::storified() 2016-09-06 09:37:25 +02:00
Matthias Beyer b3b90e5303 Merge pull request #712 from matthiasbeyer/libimagentrylink/fix-header-path
libimagentrylink/fix header path
2016-09-06 09:35:55 +02:00
Matthias Beyer 12f4012384 Merge pull request #710 from matthiasbeyer/libimagstore/fix-globstoreiditerator
libimagstore/fix GlobStoreIdIterator
2016-09-06 09:32:34 +02:00
Matthias Beyer 123133c99c test: Return if retrieve failed 2016-09-06 09:32:05 +02:00
Matthias Beyer 0d59305199 Merge pull request #692 from matthiasbeyer/libimagerror/map_err_trace
Add Result helpers for trace()ing errors
2016-09-05 20:30:44 +02:00
Matthias Beyer b1765fa994 Merge pull request #697 from matthiasbeyer/libimagref/hasher-name-in-hdr
libimagref/hasher name in hdr
2016-09-05 20:30:21 +02:00
Matthias Beyer 56576c16bb Merge pull request #696 from matthiasbeyer/imag-diary/refactor
imag-diary/refactor
2016-09-05 20:30:14 +02:00
Matthias Beyer 7bf654158e Merge pull request #695 from matthiasbeyer/libimagutil/warn-exit
libimagutil: Add warn_exit() convenience helper
2016-09-05 19:24:01 +02:00
Matthias Beyer 1dfe877cd9 Fix typo in is_external_link_storeid() helper fn 2016-09-05 18:52:42 +02:00
Matthias Beyer c23a11060f Add debug output 2016-09-05 18:51:35 +02:00
Matthias Beyer 2956df81f1 Fix: We save the url at imag.content.url, not imag.content.uri 2016-09-05 18:49:12 +02:00
Matthias Beyer 364ad01179 Use StoreId::from_full_path() in GlobStoreIdIterator::next() 2016-09-05 18:22:55 +02:00
Matthias Beyer 8362b077e2 Add StoreId::from_full_path() 2016-09-05 18:21:34 +02:00
Matthias Beyer f60afa581c Add error type for failed build of StoreId object from full path 2016-09-05 18:21:21 +02:00
Matthias Beyer e4e5b52171 Fix Iterator impl for GlobStoreIdIterator
This patch fixes the `impl Iterator for GlobStoreIdIterator` which used
the glob() result to fetch the files from the FS, but glob() returns the
absolute pathes (to filesystem root).

We have to strip the `store_path` prefix and use the local part for
building the StoreId object.
2016-09-05 18:12:29 +02:00
Matthias Beyer 47389f0f24 Merge pull request #693 from matthiasbeyer/libimagutil/result-extension-cleanup
Libimagutil/result extension cleanup (documentation)
2016-09-05 17:46:19 +02:00
Matthias Beyer d8c61d25c4 Fix absolute storeid specification in test 2016-09-05 17:05:18 +02:00
mario d19243e7a8 Fall back to get_default_cli_builder
insert custom help text
cleanup not anymore used code
2016-09-05 16:18:11 +02:00
mario 882b2ef5a7 Add help_text()
Replaces the help() functions with help_text(), which returns the help_text of imag.
Use the .help() function of clap::App to overwrite the help text generated by clap
Remove unneeded argument '--help', generated by clap now
2016-09-05 16:18:11 +02:00
mario 1900d6922c Fix clap for external subcommands 2016-09-05 16:18:11 +02:00
Mario Krehl a740dcd7ba Change build_ui to use subcommands() 2016-09-05 16:18:11 +02:00
Matthias Beyer 352d7e9083 Add some debugging output 2016-09-05 16:18:11 +02:00
Matthias Beyer 389c5b9033 We do not need to pass the subcommand as arg here 2016-09-05 16:18:11 +02:00
Matthias Beyer ac7fb19040 Use libimagrt::setup::generate_runtime_setup() helper to build Runtime object 2016-09-05 16:18:11 +02:00
Matthias Beyer c4c726a983 Add dep: log = 0.3 2016-09-05 16:18:11 +02:00
Matthias Beyer 58b2597bcb Enable forwarding of args and subcommands 2016-09-05 16:18:11 +02:00
Matthias Beyer 58fd2dbfe4 Shrink App setup code 2016-09-05 16:18:11 +02:00
Matthias Beyer fa379a2fa7 Only return subcommand name 2016-09-05 16:18:11 +02:00
Matthias Beyer cd70c68a01 Add support for --help and -h 2016-09-05 16:18:11 +02:00