Commit graph

2672 commits

Author SHA1 Message Date
1a01a391f1 Add comment to task delete procedure 2016-08-06 10:14:01 +02:00
0d2cd16e94 Print the imported string before the information output 2016-08-06 10:11:42 +02:00
d0592d0029 Return the imported string as well 2016-08-06 10:11:22 +02:00
01ee30537e Add note why we stdin.lock() here 2016-08-06 10:07:26 +02:00
0d7f7a3ac1 Merge pull request #623 from matthiasbeyer/libimagdiary/remove-unwraps
Libimagdiary/remove unwraps
2016-08-05 13:19:35 +02:00
cc7067d106 Merge pull request #622 from matthiasbeyer/libimagtimeui/remove-unwrap
Libimagtimeui/remove unwrap
2016-08-05 13:19:29 +02:00
20a8f24a6e Merge pull request #621 from matthiasbeyer/libimagentrytag/remove-unwraps
Libimagentrytag/remove unwraps
2016-08-05 13:19:24 +02:00
dd7d7b45ef Merge pull request #620 from matthiasbeyer/libimagerror/replace-unwraps
Libimagerror/replace unwraps
2016-08-05 13:19:18 +02:00
9982b3251c Replace unwrap() with try!() 2016-08-04 19:22:31 +02:00
a07047b61a Replace unwrap() with try!() 2016-08-04 19:22:31 +02:00
27009be687 Replace unwrap() with try!() 2016-08-04 19:22:30 +02:00
f43f227042 Import MapErrInto Trait 2016-08-04 19:20:54 +02:00
bc16a2531a Export MapErrInto trait 2016-08-04 19:20:54 +02:00
11dc277c6b Replace unwrap() with map() 2016-08-04 19:13:16 +02:00
9ea1811e21 Replace unwrap() with map() 2016-08-04 19:13:16 +02:00
97fde8cc1b Replace unwrap() with map() 2016-08-04 19:13:15 +02:00
1762b2e7d5 Replace unwrap() by match 2016-08-04 14:19:25 +02:00
a330cdd82f Replace unwrap() by match 2016-08-04 14:18:13 +02:00
99612b4ecc Replace unwrap with match 2016-08-04 14:15:34 +02:00
669b5a936a Replace unwrap() with match 2016-08-04 14:13:09 +02:00
1872dcd5e6 Replace unwrap() with match 2016-08-04 14:12:42 +02:00
b6ce57418e Merge pull request #617 from matthiasbeyer/imag-store/refactor-unwraps
Imag store/refactor unwraps
2016-08-03 13:56:45 +02:00
b45c4d4d0b Merge pull request #616 from matthiasbeyer/libimagentrylink/remove-unwrap
libimagentrylink - unwrap() cleanup
2016-08-03 13:05:36 +02:00
13945ab352 Replace unwrap() with match 2016-08-03 13:04:53 +02:00
0f13fc38c0 Replace unwrap() with match 2016-08-03 13:04:47 +02:00
84e33c07e6 Replace unwrap() with try!() 2016-08-03 13:04:27 +02:00
bd085b0ead Replace unwrap() with match 2016-08-03 13:04:20 +02:00
5935d43f09 Replace map(unwrap()) with fold() 2016-08-03 11:30:23 +02:00
41bf063a71 Replace map(unwrap()) with fold() 2016-08-03 11:29:38 +02:00
80491ff0b7 Replace map(unwrap()) with fold() 2016-08-03 11:27:26 +02:00
f46e8ac597 Replace unwrap with try!() 2016-08-03 11:27:25 +02:00
ca08f6d273 Export MapErrInto trait 2016-08-03 11:27:25 +02:00
76d88e46ad Merge pull request #611 from matthiasbeyer/libimagstore/drop-wlocks-early
Libimagstore/drop wlocks early
2016-08-02 20:28:08 +02:00
e37316f3f4 Fix possible w-lock panic
For a detailed explanation on the issue this commit tries to solve, have
a look at

    7b5d37a039

which explains the issue in detail.
2016-08-02 18:59:17 +02:00
84ae516dc3 Fix possible w-lock panic
for a detailed explanation of the issue this commit tries to solve have
a look at

    7b5d37a039

which explains the issue in detail.
2016-08-02 18:59:17 +02:00
002fad8711 Merge pull request #614 from matthiasbeyer/libimagentrylister/table-lister
Libimagentrylister/table lister
2016-08-02 18:07:05 +02:00
d41eed41db Merge pull request #613 from matthiasbeyer/update-readme
Update readme
2016-08-02 16:34:20 +02:00
9fd65dbe4a Add TableLister 2016-08-02 16:28:32 +02:00
e88082f270 Export MapErrInto trait here as well 2016-08-02 16:28:21 +02:00
a9f0ee0903 Add error type: IOError 2016-08-02 16:28:11 +02:00
57f3894f76 Add dependency: prettytable = 0.6.* 2016-08-02 16:27:53 +02:00
85678db1c1 Add mailinglist link in CONTRIBUTING.md 2016-08-02 14:23:48 +02:00
116eb11910 Add contact information to README 2016-08-02 14:22:58 +02:00
c3cf7575c0 Merge pull request #612 from matthiasbeyer/libimagrt/logging-without-color
Libimagrt/logging without color
2016-08-02 14:08:19 +02:00
69a10b2d02 Merge pull request #601 from matthiasbeyer/doc-updates
Doc updates
2016-08-02 13:01:40 +02:00
0de0ed94e1 Do not print logging info with color in test scripts 2016-08-02 11:42:35 +02:00
8412ea195f Configure coloring in logger setup 2016-08-02 11:39:01 +02:00
8a0200a183 Make coloring optional via flag in ImagLogger 2016-08-02 11:38:38 +02:00
ea17755ad4 Fix possible w-lock panic
for a detailed explanation have a look at

    7b5d37a039

Which explains the issue this commit solves in more detail.
2016-08-01 20:28:38 +02:00
7b5d37a039 Fix: Make sure we release the Write-Lock
This was suggested by Marcel Müller, who also debugged this issue and
found that this snippet was the error.

The problem was, that we had the write-lock when starting the hooks. If
the hook runs into an Err() mapping part where the Entry could already
be drop()ed, Rust tries to be smart and drops the object. As we are
still in the creation code of the entry, this paniced as we still hold
the W-Lock and the drop() tryies to call _update() on the entry, which
also tries to W-lock it.

With the new additional scope, the W-lock gets dropped early and we do
not have this problem anymore.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Suggested-by: Marcel Müller <neikos@neikos.email>
Reported-by: Matthias Beyer <mail@beyermatthias.de>
2016-08-01 20:00:31 +02:00