Commit Graph

4377 Commits

Author SHA1 Message Date
Matthias Beyer f5d5e3c9c3 Add getters 2017-09-21 17:28:13 +02:00
Matthias Beyer 0efffdbea3 Impl Display for {GPSValue, Coordinates} 2017-09-21 17:26:46 +02:00
Matthias Beyer a34a9239a7 Add GPSEntry::remove_coordinates() 2017-09-21 17:26:41 +02:00
Matthias Beyer 555c0bb1df Fix Walkdir depth
From the documentation of Walkdir::min_depth():

    Set the minimum depth of entries yielded by the iterator.

    The smallest depth is 0 and always corresponds to the path given to
    the new function on this type. Its direct descendents have depth 1,
    and their descendents have depth 2, and so on.

This means that when we started with "/tmp/store", we end up yielding
that exact path in the first iteration. This is exactly what we do _not_
want.

Setting the minimal depth to 1 fixes this bug.
2017-09-21 16:31:25 +02:00
Matthias Beyer a553063c6e Merge pull request #1100 from matthiasbeyer/libimagentrylink/typo
Fix: critical typo
2017-09-21 13:55:58 +02:00
Matthias Beyer 5cf4df474a Doc: Todo: Fix indent 2017-09-21 12:29:27 +02:00
Matthias Beyer e5135aa9d5 Add imag-grep in todo-list, sort 2017-09-21 12:26:28 +02:00
Matthias Beyer 74a7208757 Fix: critical typo 2017-09-21 12:23:32 +02:00
Matthias Beyer 94674841a0 Fix doc: Header structure 2017-09-21 12:21:32 +02:00
Matthias Beyer 5a868015e6 Merge pull request #1098 from matthiasbeyer/libimagstore/glob-iter-early-error
Return glob errors instead of tracing internally
2017-09-21 09:29:34 +02:00
Matthias Beyer 9b7d958d03 Merge pull request #1097 from matthiasbeyer/libimagstore/delete-from-fs-fix
Fix: Store::delete() should check FS as well
2017-09-21 09:29:24 +02:00
Matthias Beyer c6e94dfd3c Return glob errors instead of tracing internally
This changes the internal GlobStoreIdIterator to return Result<StoreId>,
which gives us the possibility to aggregate errors in the
Store::retrieve_for_module() function and return them instead of tracing
them from the store.

The changes the internals to actually fetch the whole list of storeids,
which is unfortunate of course, but changing the interface is not an
option here, in my opinion.

At least we're only aggregating pathes, so the memory usage is pretty
low here.
2017-09-20 22:42:11 +02:00
Matthias Beyer 8bbaeeef45 Fix: Store::delete() should check FS as well
This patch fixes a problem where the Store::delete() function only
checked the store-internal cache whether an entry exists, but not the
Filesystem. After this patch is applied, the Store::delete() function
also checks the filesystem whether the entry exists.
2017-09-20 22:24:59 +02:00
Matthias Beyer 2d727285a6 Enable logging to stderr for all modules in debug mode 2017-09-20 22:14:45 +02:00
Matthias Beyer c0214cafd3 Make debug logging format more verbose 2017-09-20 22:14:30 +02:00
Matthias Beyer e2bf6c48ef Merge pull request #1096 from matthiasbeyer/fix-log-output
Register the no-escape escape functionality in handlebars
2017-09-20 22:00:53 +02:00
Matthias Beyer 87ad85ab3d Merge pull request #1094 from matthiasbeyer/libimagdiary/is_in_diary
Base IsInDiary::is_in_diary() on StoreId::is_in_collection()
2017-09-20 22:00:41 +02:00
Matthias Beyer 9b2ceb31cc Merge pull request #1093 from matthiasbeyer/libimagentrylist/rip-out-cli-mod
libimagentrylist: Remove unused module
2017-09-20 22:00:34 +02:00
Matthias Beyer a73111458e Merge pull request #1091 from matthiasbeyer/libimagstore/toml-pretty
Serialize TOML pretty
2017-09-20 22:00:27 +02:00
Matthias Beyer b431d0ee49 Merge pull request #1092 from matthiasbeyer/minor
Minor things
2017-09-20 19:24:44 +02:00
Matthias Beyer de69d31a58 Register the no-escape escape functionality in handlebars
Before, handlebars automatically applied html escaping, which resulted
in <>'& beeing escaped. But we don't need to escape for terminal output.
2017-09-20 19:12:08 +02:00
Matthias Beyer da4d670cbc Base IsInDiary::is_in_diary() on StoreId::is_in_collection(), which is tested 2017-09-20 18:48:55 +02:00
Matthias Beyer 19c3bc829a Remove unused module 2017-09-20 18:41:54 +02:00
Matthias Beyer 1e7e6ab601 Merge pull request #1090 from matthiasbeyer/imag-ref/positional-args
imag-ref: Use positional args
2017-09-20 18:39:06 +02:00
Matthias Beyer 79b6c26502 Serialize TOML pretty 2017-09-20 18:38:31 +02:00
Matthias Beyer e7ec39bdcc Merge pull request #1089 from matthiasbeyer/imag-bin/pass-runtime-generated-args
Ensure that all arguments are passed to the subcommand
2017-09-20 18:36:31 +02:00
Matthias Beyer e000957722 Ensure that all arguments are passed to the subcommand 2017-09-20 17:13:04 +02:00
Matthias Beyer 456c5539cc Use positional args 2017-09-20 16:44:39 +02:00
Matthias Beyer 4b906f27b1 Merge pull request #1080 from matthiasbeyer/libimagentrytag/header-location
Do not use "imag" namespace in header
2017-09-20 12:40:39 +02:00
Matthias Beyer c558addbd6 Add debug/trace output in Store 2017-09-20 12:05:44 +02:00
Matthias Beyer c3ad3a1256 Remove unused import 2017-09-20 12:05:44 +02:00
Matthias Beyer e986fbeabc Add debugging output 2017-09-20 12:05:44 +02:00
Matthias Beyer 0da07a3387 Each test should use an other name for the file it creates 2017-09-20 12:05:44 +02:00
Matthias Beyer 5ce6cb2aa5 Switch from .set() to .insert() 2017-09-20 12:05:44 +02:00
Matthias Beyer 8ddb0f6c24 Do not use "imag" namespace in header
This change switches the header location for the tagging information
from "imag.tags" to "tag.values". "tags" is not used because non-tables
are not allowed at the top level of the header.

Tests are adapted.
2017-09-20 09:24:46 +02:00
Matthias Beyer 00256effdb Merge pull request #1087 from matthiasbeyer/testing-default-entry-fix
Testing default entry fix
2017-09-20 09:24:18 +02:00
Matthias Beyer 39b9c17a0c Add default entry by simply creating an empty Entry 2017-09-19 22:31:23 +02:00
Matthias Beyer a3d923ab20 Add default entry by simply creating an empty Entry 2017-09-19 22:31:23 +02:00
Matthias Beyer 8904694b2a Remove plain-text default entry 2017-09-19 22:31:23 +02:00
Matthias Beyer 75bc1b0511 Fix README symlink 2017-09-19 18:34:56 +02:00
Matthias Beyer afd6c19c63 Merge pull request #1086 from matthiasbeyer/deps-update
Update dependency specs
2017-09-19 18:32:55 +02:00
Matthias Beyer ec0c58d360 Fix README symlink 2017-09-19 18:32:34 +02:00
Matthias Beyer 162b36d6ee Update dependency specs
Most notably:

* env_logger: 0.4 -> 0.5
* hoedown: 5.0.0 -> 6.0.0
* itertools: 0.5 -> 0.6
* lazy_static: 0.1.15 -> 0.2
* regex: 0.1 -> 0.2
* semver: 0.5 -> 0.8
* url: 1.2 -> 1.5
* uuid: 0.3 -> 0.5

(This list is most surely not complete)
2017-09-19 17:16:19 +02:00
Matthias Beyer d56e086242 Remove shell code which is not used anymore 2017-09-18 14:21:48 +02:00
Matthias Beyer 2cee0db1ec Merge pull request #1084 from matthiasbeyer/libimagstore/move-by-id-check-fs
libimagstore: move_by_id() should check FS
2017-09-18 09:34:28 +02:00
Matthias Beyer a01a2c18f8 Check in Store::move_by_id() whether target exists, not only in cache but also on FS 2017-09-17 15:44:19 +02:00
Matthias Beyer 29e1107d3e Add file abstraction function to check whether path exists 2017-09-17 15:43:57 +02:00
Matthias Beyer d97b77c30c Merge pull request #1078 from matthiasbeyer/imag-tag/positional-args
Transform UI to use positional args
2017-09-17 09:48:30 +02:00
Matthias Beyer 210688d913 Transform UI to use positional args 2017-09-17 08:30:00 +02:00
Matthias Beyer 2c02c98230 Merge pull request #1079 from matthiasbeyer/libimagstore/no-more-links-in-header
Do not insert the links array in the core header
2017-09-17 08:28:33 +02:00