Commit graph

443 commits

Author SHA1 Message Date
d5723791a6 Add StoreId::without_base() 2016-08-28 18:41:54 +02:00
ab23d04e04 Add StoreId::new_baseless() 2016-08-28 18:41:54 +02:00
d1f07cd087 Add check in StoreId::new() whether the local part is absolute 2016-08-28 18:41:54 +02:00
ccc2b6b735 Add error kind for StoreId::new() with id-part that is absolute 2016-08-28 18:41:54 +02:00
5b23059d93 Fix scoping 2016-08-28 18:41:54 +02:00
3c1be0fbe9 Fix use of store ids when passing to FileAbstraction::* 2016-08-28 18:41:54 +02:00
111cb4f29a Add StoreId::to_str() -> String 2016-08-28 18:41:54 +02:00
aa6f220659 Fix GlobStoreIterator type implementation
... to use new StoreId interface
2016-08-28 18:41:53 +02:00
3f88c27834 Remove unused imports 2016-08-28 18:41:53 +02:00
9cf7897286 Fixup Walk type to handle StoreId properly 2016-08-28 18:41:53 +02:00
1de09f1606 Rewrite StoreId::storified() 2016-08-28 18:41:53 +02:00
1af3ab018b Use StoreId::new() in macro 2016-08-28 18:41:53 +02:00
fe73a53d44 Add StoreId::new() 2016-08-28 18:41:53 +02:00
8dff5685fd Make StoreId.base optional 2016-08-28 18:41:53 +02:00
ad92b05fb4 Remove IntoStoreId for PathBuf 2016-08-28 18:41:53 +02:00
adf213bbc7 Remove From<PathBuf> for StoreId 2016-08-28 18:41:53 +02:00
cf84df3ce7 Remove From<String> for StoreId 2016-08-28 18:41:53 +02:00
bcd917055d Remove AsRef<Path> for StoreId 2016-08-28 18:41:53 +02:00
30a76d57f6 Remove Borrow<Path> for StoreId 2016-08-28 18:41:53 +02:00
8c5a427a01 Rewrite Borrow<Path> for StoreId 2016-08-28 18:41:52 +02:00
55953cfe5b Rewrite AsRef<Path> for StoreId 2016-08-28 18:41:52 +02:00
1d165f6fc2 Remove Deref for StoreId but provide basic functions within the type 2016-08-28 18:41:52 +02:00
69b3f6bf87 Rewrite Display for StoreId 2016-08-28 18:41:52 +02:00
fb1df533c5 Rewrite Into<PathBuf> for StoreId 2016-08-28 18:41:52 +02:00
6841b7c340 Rewrite StoreId::storified() 2016-08-28 18:41:52 +02:00
264d651f1d Make StoreId be two parts: base and id 2016-08-28 18:41:52 +02:00
Marcel Müller
820fa287a0
Remove duplication 2016-08-25 09:30:47 +02:00
Marcel Müller
a82ef32142
Add missing FileAbstractions call 2016-08-24 16:58:48 +02:00
Marcel Müller
60a315e553
Rename lazyfile file to file_abstraction 2016-08-24 16:58:47 +02:00
Marcel Müller
c8e296e221
Move all abstractions to LazyFile and change it to FileAbstraction 2016-08-24 16:58:47 +02:00
Marcel Müller
1c71326ede
Add simple test 2016-08-24 16:58:47 +02:00
Marcel Müller
74dcd1f141
Add implementation of Test Lazyfile 2016-08-24 16:58:47 +02:00
Marcel Müller
bc1af19750
Add FileNot{Written,Seeked} errors 2016-08-24 16:58:47 +02:00
Marcel Müller
1d1ad65705
Split up LazyFile for test/prod 2016-08-24 16:58:46 +02:00
Marcel Müller
363a1d246a
Use Read instead of File for from_file
Also change it to `from_reader`
2016-08-24 16:58:46 +02:00
Marcel Müller
ef4455d9f3
Comment out tests 2016-08-24 16:58:43 +02:00
ddbc38e756 Merge pull request #659 from asuivelentine/libimagstore/unused-import
removed unused import
2016-08-23 21:36:03 +02:00
Kai Sickeler
5148bc1a6e removed unused import 2016-08-23 19:58:50 +02:00
e37316f3f4 Fix possible w-lock panic
For a detailed explanation on the issue this commit tries to solve, have
a look at

    7b5d37a039

which explains the issue in detail.
2016-08-02 18:59:17 +02:00
84ae516dc3 Fix possible w-lock panic
for a detailed explanation of the issue this commit tries to solve have
a look at

    7b5d37a039

which explains the issue in detail.
2016-08-02 18:59:17 +02:00
ea17755ad4 Fix possible w-lock panic
for a detailed explanation have a look at

    7b5d37a039

Which explains the issue this commit solves in more detail.
2016-08-01 20:28:38 +02:00
7b5d37a039 Fix: Make sure we release the Write-Lock
This was suggested by Marcel Müller, who also debugged this issue and
found that this snippet was the error.

The problem was, that we had the write-lock when starting the hooks. If
the hook runs into an Err() mapping part where the Entry could already
be drop()ed, Rust tries to be smart and drops the object. As we are
still in the creation code of the entry, this paniced as we still hold
the W-Lock and the drop() tryies to call _update() on the entry, which
also tries to W-lock it.

With the new additional scope, the W-lock gets dropped early and we do
not have this problem anymore.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Suggested-by: Marcel Müller <neikos@neikos.email>
Reported-by: Matthias Beyer <mail@beyermatthias.de>
2016-08-01 20:00:31 +02:00
Kai Sickeler
b6437a0b0f Implement Debug for FileLockEntry, do not derive it 2016-07-27 19:26:45 +02:00
0ba67f7873 Check whether implictely creating the store path is allowed 2016-07-25 17:02:38 +02:00
4d650a63f7 Add error kind for implicit create denied 2016-07-25 17:02:38 +02:00
442b1537be Add helper to check config for implicit-create 2016-07-25 17:02:38 +02:00
cdf6bc6fa5 Make warning more verbose, tell what kind of variable cannot be fetched 2016-07-18 15:44:34 +02:00
ce766427da Merge pull request #561 from matthiasbeyer/libimagstore/verify
Libimagstore/verify
2016-07-17 13:03:54 +02:00
6b1fdfbc1d Add Store::verify() 2016-07-17 00:59:04 +02:00
bb8dad256c Fix comment how config has to look 2016-07-16 22:17:05 +02:00