Commit graph

3484 commits

Author SHA1 Message Date
66ccd97ef2 Simplify error handling 2016-09-05 16:15:54 +02:00
02b58a45c5 Simplify error handling 2016-09-05 16:15:54 +02:00
4ddb558837 Replace complex match with if let Err(e) 2016-09-05 16:15:54 +02:00
44675a4b4f Refactor: use map_err_into() instead of manual building 2016-09-05 16:15:54 +02:00
f8db1273e7 Export MapErrInto as well here 2016-09-05 16:15:54 +02:00
b2f764d004 Add warn_exit() convenience helper 2016-09-05 16:15:50 +02:00
ec9da007a5 Add comment for warn_result code 2016-09-05 16:15:45 +02:00
87e170df72 Add comment for info_result code 2016-09-05 16:15:45 +02:00
2c89de1332 Add comment for debug_result code 2016-09-05 16:15:45 +02:00
6b6e3a0e12 Add documentation for the code-generator macro 2016-09-05 16:15:45 +02:00
55846168dc Add variant of Ref::get_stored_hash() to get stored hash with custom hasher 2016-09-05 16:15:40 +02:00
5399b8ca7b Add variant of Ref::update_ref() to update with custom Hasher instance 2016-09-05 16:15:40 +02:00
a6ca041903 Fix Ref::get_stored_hash() for reading the right header field 2016-09-05 16:15:40 +02:00
8a3d4fc0b2 Fix Ref::update_ref() to set the appropriate header field 2016-09-05 16:15:40 +02:00
6a1ffe059b This patch puts the hasher name in the header
This was a bug, as the previous implementation simply sets the hash, but
we need to set the hash in a place where we can re-find it with a
hasher.
2016-09-05 16:15:40 +02:00
737aab80dc Merge pull request #667 from matthiasbeyer/rewrite-storeid-type
Rewrite storeid type
2016-09-05 16:10:47 +02:00
07d4c45b3f Refactor long line for more readability 2016-09-05 09:21:06 +02:00
24c73325f3 Remove version part from imag-store tests 2016-09-05 09:21:06 +02:00
70a17ca62c Fix typo 2016-09-05 00:35:04 +02:00
3a0739c1cf Merge pull request #690 from matthiasbeyer/rewrite-storeid-type-general-cleanup
General cleanup for #667
2016-09-04 18:03:20 +02:00
dfcc5c6a0e Merge pull request #603 from asuivelentine/imag-view/view-in-editor
get default editor
2016-09-04 15:36:22 +02:00
ccffeb91a2 Remove StoreId::is_in_collection(), add StoreId::local()
Having a ::is_in_collection() is a nice thing, though it is _way_ better
if we just give the user of the `StoreId` object access to the local
part of the ID.

Using this new function, one can do all the actions one might need on
the Path for the actual entry without nasty copying or such.

`StoreId::is_in_collection()` can be replaced by
`StoreId::local().starts_with()` and everything is fine, as we do not
have to move a `PathBuf` object into the function anymore.
2016-09-04 10:40:38 +02:00
253c8a6f54 Adapt tests for new StoreId::is_in_collection() interface 2016-09-03 19:32:27 +02:00
3c31854e66 Use new StoreId::is_in_collection() interface 2016-09-02 17:17:41 +02:00
4da331f990 Use new StoreId::is_in_collection() interface 2016-09-02 17:16:03 +02:00
a77cc2bab2 Change the interface of StoreId::is_in_collection()
to use &PathBuf rather than &[&str] as argument.
2016-09-02 17:15:15 +02:00
85f79ae3e5 Replace .map().all(|x| x) by calling .all() in the first place 2016-09-02 17:01:40 +02:00
8e779fc87e Merge pull request #679 from matthiasbeyer/libimagdiary-is-in-diary-with-storeid-is-in-collection
libimagdiary cleanup
2016-09-02 08:25:37 +02:00
901df1fb3a Merge pull request #680 from matthiasbeyer/rewrite-storeid-type-imag-store-cleanup
imag-store cleanup
2016-09-02 08:25:21 +02:00
4896c14086 Merge pull request #681 from matthiasbeyer/rewrite-storeid-type-cleanup-libimagentrylink
libimagentrylink cleanup
2016-09-02 08:25:10 +02:00
ae280f178c Merge pull request #682 from matthiasbeyer/rewrite-storeid-type-cleanup-libimagentryview
libimagentryview cleanup
2016-09-02 08:24:50 +02:00
e81f4dfcb6 Merge pull request #683 from matthiasbeyer/rewrite-storeid-type-imag-link-cleanup
imag-link cleanup
2016-09-02 08:24:36 +02:00
5562649259 Merge pull request #684 from matthiasbeyer/rewrite-storeid-type-cleanup-libimagentryselect
libimagentryselect cleanup
2016-09-02 08:24:21 +02:00
a225009866 Merge pull request #678 from matthiasbeyer/rewrite-storeid-type-cleanup-libimagstore-versions
Remove Store::get_all_versions()
2016-09-02 08:24:03 +02:00
c9990db634 Merge pull request #685 from matthiasbeyer/rewrite-storeid-type-cleanup-libimagstorestdhook
libimagstorestdhook cleanup
2016-09-02 08:23:41 +02:00
8563e0d4fc Reimplement IsInDiary for StoreId with StoreId::is_in_collection() 2016-08-31 09:21:06 +02:00
b1898887c2 Add StoreId::is_in_collection()
The concept of this function was introduced in

    37076f028c6cde0924b820154f3464f53ef65268

but here added to StoreId as function.
2016-08-31 09:21:06 +02:00
46bf387fc3 Make internal linking only have store-relative links 2016-08-31 09:20:09 +02:00
3e4b0e4bb8 Rewrite internal link handling, returning Result<_> rather than Option<_> 2016-08-31 09:20:09 +02:00
d594b7c6a2 Reimplement libimagentrylink::external::is_external_link_storeid() using StoreId::is_in_collection() 2016-08-31 09:20:08 +02:00
b2806ab592 Add StoreId::is_in_collection()
The concept of this function was introduced in

    37076f028c6cde0924b820154f3464f53ef65268

but here added to StoreId as function.
2016-08-31 09:20:08 +02:00
89db4885f2 Remove versions viewing from imag-view 2016-08-31 08:26:54 +02:00
22d6815abd Remove Store::get_all_versions() as we do not longer have the concept of store-entry versions 2016-08-31 08:26:54 +02:00
4eaa0c2147 We can call StoreId::{exists, is_file} here instead of converting to PathBuf 2016-08-31 08:26:54 +02:00
7487c630f2 Remove versions viewer 2016-08-31 08:26:54 +02:00
4f62dfcf2b Fix imag-store::create::* to fail on absolute pathes 2016-08-31 08:26:53 +02:00
c104e165fd Fix handle_internal_linking() and add error output in case of Err(_) via libimagutil::warn_result::* 2016-08-31 08:26:53 +02:00
4bd157914e Rewrite functions to return Result<_> 2016-08-31 08:26:53 +02:00
0b89cd9ff9 Add libimagutil::warn_result::* 2016-08-31 08:26:53 +02:00
6e7aa3c4b7 Add modules: error, result 2016-08-31 08:26:53 +02:00