Commit graph

2271 commits

Author SHA1 Message Date
84ae516dc3 Fix possible w-lock panic
for a detailed explanation of the issue this commit tries to solve have
a look at

    7b5d37a039

which explains the issue in detail.
2016-08-02 18:59:17 +02:00
ea17755ad4 Fix possible w-lock panic
for a detailed explanation have a look at

    7b5d37a039

Which explains the issue this commit solves in more detail.
2016-08-01 20:28:38 +02:00
7b5d37a039 Fix: Make sure we release the Write-Lock
This was suggested by Marcel Müller, who also debugged this issue and
found that this snippet was the error.

The problem was, that we had the write-lock when starting the hooks. If
the hook runs into an Err() mapping part where the Entry could already
be drop()ed, Rust tries to be smart and drops the object. As we are
still in the creation code of the entry, this paniced as we still hold
the W-Lock and the drop() tryies to call _update() on the entry, which
also tries to W-lock it.

With the new additional scope, the W-lock gets dropped early and we do
not have this problem anymore.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Suggested-by: Marcel Müller <neikos@neikos.email>
Reported-by: Matthias Beyer <mail@beyermatthias.de>
2016-08-01 20:00:31 +02:00
6e988782da Merge pull request #605 from matthiasbeyer/libimagentryfilter/bool-filter
Add BoolFilter
2016-07-31 22:02:43 +02:00
989ee1864a Merge pull request #604 from matthiasbeyer/imag-diary/warnings
Imag diary/warnings
2016-07-31 22:02:37 +02:00
79c1edcbd1 Add BoolFilter 2016-07-31 12:18:07 +02:00
dcd72765bc Add deny() macro 2016-07-31 11:13:20 +02:00
b613aba257 Remove unused function
We do not offer explicit diary functionality.

Either a user creates a diary implicitely by creating a new entry inside
of it, or not.
2016-07-31 11:13:20 +02:00
7187ad89b1 If an error happens while viewing, trace it 2016-07-31 10:39:43 +02:00
c1d41c954e Remove keyword: mut 2016-07-31 10:38:30 +02:00
5cc84c1551 Remove keyword: mut 2016-07-31 10:38:21 +02:00
2b0efee4cc Merge pull request #600 from matthiasbeyer/doc-deps
Add new non-optional dependencies to doc in default.nix
2016-07-31 10:31:14 +02:00
fd8d7b2ebb Merge pull request #599 from matthiasbeyer/add-missing-readme-links
Add missing readme links
2016-07-31 10:31:07 +02:00
3e4d01a339 Add missing dependency: which 2016-07-30 20:59:49 +02:00
008f4d0032 Add new non-optional dependencies to doc in default.nix 2016-07-30 20:53:12 +02:00
6981bbdff1 Add link: doc/src/04020-module-ref.md -> imag-ref/README.md 2016-07-30 20:48:31 +02:00
517050588b Add link: doc/src/04020-module-diary.md -> imag-diary/README.md 2016-07-30 20:48:04 +02:00
ab91a08179 Add link: doc/src/04020-module-bookmarks.md -> imag-bookmark/README.md 2016-07-30 20:47:05 +02:00
5cd2964fe3 Merge pull request #598 from asuivelentine/imag-notes/warnings
removed warnings
2016-07-30 20:16:17 +02:00
a559fdff07 Merge pull request #597 from asuivelentine/imag-view/refactor
shorten exit on error
2016-07-30 20:15:57 +02:00
Kai Sickeler
34ea40381f removed warnings 2016-07-30 19:21:07 +02:00
Kai Sickeler
6e56653c8e shorten exit on error 2016-07-30 19:12:29 +02:00
6a8c93ee52 Merge pull request #594 from matthiasbeyer/libimagutil/debug-mapping
Add utility to print debugging information while mapping
2016-07-30 15:28:45 +02:00
5a68c05ca5 Merge pull request #595 from matthiasbeyer/update-readme
Update README
2016-07-30 15:28:03 +02:00
e9e9950db7 Update README 2016-07-30 12:36:23 +02:00
d050be4cbc Refactor, generate code with macro 2016-07-30 11:57:42 +02:00
deb1544bc5 Add info_result 2016-07-30 11:45:31 +02:00
0b1ea94dae Add utility to print debugging information while mapping 2016-07-29 16:49:45 +02:00
9a9a1b7ecd Merge pull request #592 from matthiasbeyer/quiet-travis
Quiet travis
2016-07-29 10:29:44 +02:00
59afb5b9d0 Merge pull request #581 from impo/libimagerror/deny-warnings
libimagerror: Deny warnings
2016-07-29 10:25:19 +02:00
b2c11384c0 Merge pull request #586 from asuivelentine/libimagstore/debug
Implement Debug for FileLockEntry, do not derive it
2016-07-28 14:42:55 +02:00
0e78081918 Merge pull request #587 from matthiasbeyer/libimagrt/imagrc-location
Search for imagrc in RTP and not in RTP/store
2016-07-28 14:42:30 +02:00
4dce62030a Merge pull request #588 from asuivelentine/libimagcounter/refactor
Libimagcounter/refactor
2016-07-28 14:41:53 +02:00
c7b9de3bbd travis: try to remove "tree" call 2016-07-28 14:39:10 +02:00
0ec5117b5a travis: Dont call cargo with --verbose flag 2016-07-28 14:37:59 +02:00
49cd0d0476 Merge pull request #589 from matthiasbeyer/imag-documentation
Imag (library) documentation
2016-07-28 14:36:14 +02:00
Gavin Thomas Claugus
6578abdf3d libimagerror: Eliminate unused imports
Signed-off-by: Gavin Thomas Claugus <gclaugus@gmail.com>
2016-07-28 08:34:50 -04:00
Gavin Thomas Claugus
014a40c9df libimagerror: Deny warnings
Signed-off-by: Gavin Thomas Claugus <gclaugus@gmail.com>
2016-07-28 08:34:50 -04:00
Kai Sickeler
da432f5b07 Replaced unwrap with try! 2016-07-27 20:19:35 +02:00
Kai Sickeler
47d2a7703c shorten header reading with header function 2016-07-27 19:54:03 +02:00
7c8c9b5264 Add Makefile target for building the lib documentation 2016-07-27 19:29:34 +02:00
be0a907145 Add .imag-documentation
A crate which simply depends on all libimag* crates to be able to
generate the documentation for all of them by simply creating the
documentation of this crate.
2016-07-27 19:28:36 +02:00
Kai Sickeler
b6437a0b0f Implement Debug for FileLockEntry, do not derive it 2016-07-27 19:26:45 +02:00
6571429123 Search for imagrc in RTP and not in RTP/store 2016-07-27 19:15:50 +02:00
Kai Sickeler
1c5cb7d21d replaced implementation of reset with call to set function 2016-07-27 18:54:09 +02:00
4cbd81ed20 Merge pull request #535 from asuivelentine/libimagcounter/units
Libimagcounter/units
2016-07-27 18:34:09 +02:00
Kai Sickeler
f527e7eb0a changed default behavior from unit to None 2016-07-27 17:40:20 +02:00
Kai Sickeler
3445908ef9 better error-handling when reading the unit 2016-07-27 17:40:20 +02:00
Kai Sickeler
769512ada2 added Option<CounterUnit> as member of Struct Counter 2016-07-27 17:40:20 +02:00
Kai Sickeler
aeb27072a7 use CounterUnit::new instead of a pub member 2016-07-27 17:40:20 +02:00