matthiasbeyer/imag
1
0
Fork 0
Code Releases Activity
6185 commits 1 branch 0 tags 6.4 MiB
Commit graph

1009 commits

Author SHA1 Message Date
Matthias Beyer
7348378a96 Fix test: Check whether in cache, then get, then check again 
After moving an entry, the entry should _not_ be in the cache. This is
just a decision that has to be made, whether we cache the moved entry or
not. I decided to not cache because it is results in less code.

After that check, we get the entry from the backend and then we can
check whether the entry is in the cache, which is then should be.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-26 09:57:05 +02:00
Matthias Beyer
583f972788 Add test: Test moving entry with writing to it before and after moving 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-26 09:57:05 +02:00
Matthias Beyer
d1078590c7 Fix: Testing backend bug where an entry was not properly rewritten 
When moving an entry, what we did is copying the entry inside the
backend abstraction (the hashmap) from one key to another.

But as the entry itself does also encode its location, we actually have
to rewrite the entire entry. This patch fixes this.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-26 09:57:05 +02:00
Matthias Beyer
a07e03a25c Fix: Renaming entries should also remove the old entry 
This is a bugfix for a bug in Store::move_entry_by_id():
The old entry was not removed after the new one was created.

The bug is a bit subtle. The issue was, that the internal cache held
open a reference to the old entry (as StoreEntry object) and when that
object got drop()ed, the contents of the entry were written to disk,
which resulted in the old entry being recreated.

This patch rewrites the function to behave well. The most critical part
is that we do not check whether the old entry is borrowed with
`hsmap.get()` but rather `hsmap.remove()`. The trick here is that the
`StoreEntry` object is dropped in the moment the check is done, clearing
the cached object and flushing it to the backend (the disk).
After that, we continue doing the filesystem operation and the cache is
clean.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-26 09:57:05 +02:00
Matthias Beyer
2a23002a07 Fix: --override-config argument can be passed multiple times 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-13 12:21:57 +02:00
Matthias Beyer
712eda074d Merge branch 'libimagcalendar/init' into master 2019-10-11 21:35:51 +02:00
Matthias Beyer
b40a854c6f Add function to get all events 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-09 19:44:08 +02:00
Matthias Beyer
e86f36c215 Add getter helper 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-09 19:44:08 +02:00
Matthias Beyer
cf78f7192f Implement calendar library 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-09 19:44:08 +02:00
Matthias Beyer
3be9407c6c Add Linkable::is_linked_to() 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-09 19:44:01 +02:00
Matthias Beyer
b2dffff6e8 Outsource helper: getting the link partial from Entry 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-09 19:44:01 +02:00
Matthias Beyer
568e041c52 Update dependency: hex: 0.3.2 -> 0.4 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-07 18:18:28 +02:00
Matthias Beyer
613b78f369 Update dependency: ansi_term: 0.11.0 -> 0.12 2019-10-07 18:18:28 +02:00
Matthias Beyer
5edb470a5f Update dependency: handlebars: 1.1.0 -> 2 2019-10-07 18:18:28 +02:00
Matthias Beyer
07f949056e Update dependency: env_logger: 0.6.1 -> 0.7 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-07 18:18:28 +02:00
Matthias Beyer
ee5348ea23 Update dependency: url: 1.7.2 -> 2 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-07 18:05:58 +02:00
Matthias Beyer
7fc3961a17 Add viewer helper trait for iterators 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-04 17:50:30 +02:00
Matthias Beyer
f5a4331d0a Add helper function to parse string by several datetime formats 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-10-03 16:36:04 +02:00
Matthias Beyer
87f2a0cb75 Add Tests for Entries::{find_by_id_substr, find_by_id_startswith} 2019-09-01 13:36:39 +02:00
Matthias Beyer
84135b1961 Add Entries::{find_by_id_substr, find_by_id_startswith} 
This patch adds functions to the Entries type which can be used for
filtering by id, either with `contains()` or `starts_with()`.

This is useful for the end-user functionality where the user specifies
the ID of an entry only partially.

The implementation still iterates over all entries. This could be
improved, of course, by implementing a `find`-like function on `Store`
directly. But for now, this is good enough.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-09-01 13:36:39 +02:00
flip1995
e2216db41d Allow some Clippy lints 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
0087de7af8 [No-auto] lib/etc/interaction: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
a8bb180a6a [No-auto] lib/entry/view: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
d377a999cb [No-auto] lib/entry/util: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
d605f923bb [No-auto] lib/entry/url: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
c8a7aacf99 [No-auto] lib/entry/tag: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
fae9f82c67 [No-auto] lib/entry/ref: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
69dce9ed9f [No-auto] lib/entry/link: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
9620e81f59 [No-auto] lib/entry/filter: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
36957917b2 [No-auto] lib/entry/datetime: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
db40175840 [No-auto] lib/entry/category: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
2e7706af99 [No-auto] lib/domain/todo: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
4301e80cf2 [No-auto] lib/domain/timetrack: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
8726cb12cf [No-auto] lib/domain/mail: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
6307b80027 [No-auto] lib/domain/habit: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
2ac2a86c7a [No-auto] lib/domain/bookmark: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
b2997517bb [No-auto] lib/core/store: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
7b5f216e01 [No-auto] lib/core/rt: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:41 +02:00
flip1995
670a0ff6d7 [Auto] lib/etc/util: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:40 +02:00
flip1995
bde29b7242 [Auto] lib/etc/interaction: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:40 +02:00
flip1995
cb9068d7fb [Auto] lib/entry/view: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:40 +02:00
flip1995
19a1c41924 [Auto] lib/entry/url: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:40 +02:00
flip1995
1569442fee [Auto] lib/entry/tag: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:40 +02:00
flip1995
c02e6580be [Auto] lib/entry/ref: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:40 +02:00
flip1995
3215c6351c [Auto] lib/entry/markdown: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:40 +02:00
flip1995
e2b1ed729a [Auto] lib/entry/link: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:40 +02:00
flip1995
839f39435a [Auto] lib/entry/gps: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:40 +02:00
flip1995
28e693bdea [Auto] lib/entry/filter: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:40 +02:00
flip1995
17de341b90 [Auto] lib/entry/edit: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:40 +02:00
flip1995
663bb7f6c0 [Auto] lib/entry/datetime: Fix Clippy warnings 
Signed-off-by: flip1995 <hello@philkrones.com>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
 2019-08-28 18:18:40 +02:00