Commit Graph

2777 Commits

Author SHA1 Message Date
Matthias Beyer 501d1f38a2 Refactor edit_in_tmpfile()
To offer variant where we can pass the editor as command.
2016-09-09 14:57:51 +02:00
Matthias Beyer 21714660df Merge pull request #729 from matthiasbeyer/fix-header-missing-newline
Add newline before header
2016-09-09 12:54:28 +02:00
Matthias Beyer 7b827ff149 Add newline before header
The lastest release of the `toml-rs` crate (2.1) removes leading spaces
before arrays and tables, causing our tests to fail.

This fixes it.
2016-09-09 11:52:12 +02:00
Matthias Beyer e730699541 Merge pull request #725 from matthiasbeyer/libimagstore/storeid-remove-is-dir
Remove StoreId::is_dir()
2016-09-08 17:20:39 +02:00
Matthias Beyer 00acf9bb85 Merge pull request #717 from matthiasbeyer/use-result-trace-helper
Use result trace helper
2016-09-08 16:50:08 +02:00
Matthias Beyer 88ff94fb6d Remove StoreId::is_dir() 2016-09-08 15:05:25 +02:00
Matthias Beyer daca530dd5 imag-store: Use Err/Ok Result map utils to refactor code 2016-09-08 14:05:13 +02:00
Matthias Beyer a39f07f9a5 imag-diary: Use Err/Ok Result map utils to refactor code 2016-09-08 14:04:41 +02:00
Matthias Beyer 473e6d5b6a imag-notes: Use Err/Ok utils to map over results and refactor code 2016-09-08 13:57:09 +02:00
Matthias Beyer b9a9fd52c4 imag-todo: Use Err/Ok utils to map 2016-09-08 13:57:09 +02:00
Matthias Beyer 23a42dcb0d imag-link: Use Err/Ok map utility functions to refactor code 2016-09-08 13:57:09 +02:00
Matthias Beyer d5d83400fa imag-counter: Use utils to map over Err/Ok 2016-09-08 13:56:51 +02:00
Matthias Beyer 198170cf57 Merge pull request #635 from matthiasbeyer/bin/clap
Use clap in bin/imag binary.
2016-09-08 13:23:42 +02:00
Matthias Beyer 712d666ce6 Merge pull request #713 from matthiasbeyer/use-warn-exit-helper
Use warn exit helper
2016-09-08 10:56:13 +02:00
Matthias Beyer 539024781e Merge pull request #720 from mario-kr/fix_bin-target
Fix imag-bin-install target
2016-09-08 09:11:42 +02:00
Matthias Beyer 0635bffd78 imag-store: Use util fn warn_exit() 2016-09-08 08:48:58 +02:00
Matthias Beyer c91de877d0 imag-tag: Use util fn warn_exit() 2016-09-08 08:48:58 +02:00
Matthias Beyer 19711219e7 imag-diary: Use util fn warn_exit() 2016-09-08 08:48:58 +02:00
Matthias Beyer ac5ee9fb51 imag-link: Use util function warn_exit() 2016-09-08 08:48:58 +02:00
Matthias Beyer a200031eb1 imag-counter: use util function warn_exit() 2016-09-08 08:48:58 +02:00
Mario Krehl 46da70070f Fix imag-bin-install target 2016-09-07 17:09:04 +02:00
Matthias Beyer 4dca497c75 Merge pull request #718 from mario-kr/bin/clap_debug
Bin/clap debug
2016-09-07 16:45:04 +02:00
Mario Krehl 6fe4408800 Reduce clone()-ing of commands to necessary places 2016-09-07 12:57:34 +02:00
Mario Krehl e2d3e5597b Fix differing amount of newlines from subprocesses influences output 2016-09-07 12:53:38 +02:00
Mario Krehl e813ab9e3a Pretty output of --versions 2016-09-07 11:24:36 +02:00
Mario Krehl 12f9175700 Fix --versions 2016-09-07 11:14:08 +02:00
Mario Krehl d69b8498e9 Add some comments 2016-09-07 11:07:02 +02:00
Mario Krehl c828bed0e1 Fix panic! when reaching unreachable!, because imag doesnt do anything without an argument or subcommand 2016-09-07 10:37:16 +02:00
Mario Krehl 7023d1f202 Add check if given subcommand is supported 2016-09-07 10:31:00 +02:00
Mario Krehl e6d48cb31a Fix exit codes 2016-09-07 10:22:08 +02:00
Mario Krehl 5ea5f588a9 Fix panics due to unwrap on Option::None 2016-09-07 10:21:59 +02:00
Matthias Beyer 6d851160ae Merge pull request #706 from matthiasbeyer/libimagstore/remove-storeid-into-pathbuf
Libimagstore/remove storeid into pathbuf
2016-09-07 09:37:50 +02:00
Matthias Beyer 06038b8405 Merge pull request #708 from matthiasbeyer/imag-link/test-fixup
Imag link/test fixup
2016-09-06 16:40:38 +02:00
Matthias Beyer 8c12315ff8 Merge pull request #694 from matthiasbeyer/libimagtodo/debug-output
libimagtodo: Debug output
2016-09-06 16:38:54 +02:00
Matthias Beyer 66782ca87b Refactor file opening in helper function 2016-09-06 15:31:55 +02:00
Matthias Beyer 46123622b2 Have and use internal error types for better error messages 2016-09-06 15:31:55 +02:00
Matthias Beyer 04166dd7a3 Import libimagerror with macros, so we can have own error types internally 2016-09-06 15:31:55 +02:00
Matthias Beyer 95b77d7c92 When generating an error code, we should allow dead code here 2016-09-06 15:31:55 +02:00
Matthias Beyer 144a8bf897 Flock hook: Rewrite EntryFlock trait to return HookResult 2016-09-06 15:31:55 +02:00
Matthias Beyer af4a0bfaf2 Export result-helper here 2016-09-06 15:31:55 +02:00
Matthias Beyer a6377f322e Fix Ref::get_path_hash() to use ::into_pathbuf() 2016-09-06 15:31:55 +02:00
Matthias Beyer a53adb854d Use StoreId::into_pathbuf() rather than ::into() 2016-09-06 15:31:55 +02:00
Matthias Beyer 5f04d29345 Adapt store to not use StoreId::into() but new StoreId::into_pathbuf() 2016-09-06 15:31:55 +02:00
Matthias Beyer a313cede06 Add StoreId::into_pathbuf() 2016-09-06 15:31:55 +02:00
Matthias Beyer b8f612632d Add error kind if StoreId has no base part 2016-09-06 15:31:29 +02:00
Matthias Beyer 84b279de95 Remove Into<PathBuf> for StoreId 2016-09-06 15:31:29 +02:00
Matthias Beyer 40014051ec Bugfix: unique()ing the list of links
That should happen _after_ they are all in the same format.
This commit introduces overhead, as we clone() each string here for
comparison and that should clearly be fixed.

Though the bug-fix is more important at this point.
2016-09-06 15:30:26 +02:00
Matthias Beyer 584ac3d46e Fix link test to check properly 2016-09-06 15:30:26 +02:00
Matthias Beyer 2e6f833bf2 Add test for linking the same entries twice 2016-09-06 15:30:26 +02:00
Matthias Beyer 60de2eefec Fix store id specification 2016-09-06 15:30:26 +02:00