Commit graph

3408 commits

Author SHA1 Message Date
9f59478da0 Readability fixes 2015-12-05 11:10:54 +01:00
93393751b2 Remove uneccessary variable 2015-12-05 11:06:22 +01:00
80563cb340 Move tag filtering to sub-function 2015-12-05 11:05:50 +01:00
e8c7df4593 Remove variable, use expression directly 2015-12-05 11:03:05 +01:00
166a0cf5dd bm: remove_command: Refactor into sub-functions 2015-12-05 11:00:44 +01:00
75cedc1580 Move to rust stable (1.4 atm) so we can use clap 2015-12-05 10:45:33 +01:00
230d00f35a Remove unused imports 2015-12-05 01:23:06 +01:00
1f8bdef1ed Remove unused variables 2015-12-05 01:18:12 +01:00
f7a92b6e79 Resort "use"
First comes std stuff
Second is external crates
Then we have own modules

All in alphabetical order and as few lines as possible if readability is
preserved.
2015-12-05 01:14:13 +01:00
5953563671 Refactor for readability 2015-12-04 23:39:30 +01:00
f8e870312e Outsource: ids iterator to files vector 2015-12-04 23:35:48 +01:00
55f740497b Beautify get_tags() helper 2015-12-04 23:26:08 +01:00
a005d4209b Merge branch 'fix-bm-remove' 2015-12-04 23:21:32 +01:00
cd1bb88f20 Rework remove_command() 2015-12-04 23:19:18 +01:00
848fb0b4b4 Ensure we build the globstring _with_ the ID in it 2015-12-04 23:11:59 +01:00
261fbdd038 Add id getter for FileID 2015-12-04 23:11:46 +01:00
87d5852986 Ensure we dont crash if there are no files found 2015-12-04 23:01:37 +01:00
fd3d2ec8dc Fixup get_file_by_id() 2015-12-04 22:57:28 +01:00
6473b743a3 Outsource globlist -> Vec<FileID> transformation code snippet 2015-12-04 22:53:31 +01:00
dac4911ea2 (partly) Rewrite StorageBackend::get_file_by_id(), so we can get a file with a partially available ID 2015-12-04 22:49:00 +01:00
253658ece5 Fix: FileID::from() should also succeed if we pass a ID as string 2015-12-04 22:31:09 +01:00
38158e2edf Merge branch 'fix-bm-list' 2015-12-04 21:57:18 +01:00
2dfb76bd0d Reimplement: Parser::divide_text() 2015-12-04 21:56:48 +01:00
5c38e6752b Fixup glob string generating 2015-12-04 21:56:48 +01:00
08fa8f8655 Add debugging output 2015-12-04 21:56:48 +01:00
2b21d1cb47 StorageBackend::iter_files(): Add caused_by use 2015-12-04 21:56:48 +01:00
90e3f44005 StorageBackend::iter_ids(): Add caused_by() usage
Actually not, as there is no Error implementation for the error we get
to handle here.
2015-12-04 21:56:48 +01:00
87d9ca7d06 Print table only if there are entries 2015-12-04 21:56:48 +01:00
b6c1a6301f Use ParserError::with_cause() and build new ParserError object 2015-12-04 21:56:48 +01:00
3a76c05317 ParserError: Add cause 2015-12-04 21:56:47 +01:00
1aaea39b3d storage/parser::divide_text(): Add debug output 2015-12-04 21:56:33 +01:00
e72c1c68b9 Fix: Output formatting
The header-content separator dashes were completely missing. Shame on
me.
2015-12-04 21:56:33 +01:00
e31239b02b Fix wording in debug message 2015-12-04 21:56:33 +01:00
915cbd24ef Impl From<PathBuf> for FileID, using From<String> for FileID 2015-12-04 21:56:33 +01:00
db9c4e48ba ui/TablePrinter: Add debug output 2015-12-04 21:56:33 +01:00
3484858c3d Remove unused code 2015-12-04 21:56:33 +01:00
22aecc7022 Merge branch 'test-storage_code' 2015-12-04 17:55:11 +01:00
2ab025a4eb Add test: match_header_spec() testing 2015-12-04 17:52:30 +01:00
e025cf8835 Add missing Clone for FileHeaderSpec 2015-12-04 17:52:30 +01:00
04443b34bf Add test: serialize-deserialize-compare 2015-12-04 17:52:30 +01:00
3e75117d69 Add test: Deserialization without Specification should match as well 2015-12-04 17:52:30 +01:00
74a9523f45 Use box_patterns, so we can unbox in the tests 2015-12-04 17:52:30 +01:00
2dce3151bd Remove default impl for Error for ParserError 2015-12-04 17:52:30 +01:00
84e7100229 Add test for deserialization 2015-12-04 17:52:30 +01:00
d9019e408e Remove static livetime in ParserError::short() 2015-12-04 17:51:22 +01:00
2e6e63e77c Merge branch 'remove-build_functions' 2015-12-04 15:19:19 +01:00
03856cd3a1 Reimplement StorageBackendError::{new,build} with Into<String> 2015-12-04 15:18:52 +01:00
702f1b07ad Merge branch 'add-url-check' 2015-12-04 15:09:14 +01:00
c1d497fa6a Add URL check before adding the "url" to the store 2015-12-04 15:09:03 +01:00
406348bc34 Merge branch 'errors-from-backend' 2015-12-04 14:17:45 +01:00