matthiasbeyer/imag
1
0
Fork 0
Code Releases Activity

Merge pull request #1342 from matthiasbeyer/libimagentryedit/fix-editor-stdinerr-inherit

Browse source 
libimagentryedit: fix editor stdinerr inherit
This commit is contained in:
Matthias Beyer 2018-03-12 21:14:01 +01:00 committed by GitHub
commit fb9866bd46
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
doc/src/09020-changelog.md
View file

@ -75,6 +75,8 @@ This section contains the changelog from the last release to the next release.
* `imag-diary create --timed` did not work as expected * `imag-diary create --timed` did not work as expected
* `libimagstore` got another fix with the file parsing, as the * `libimagstore` got another fix with the file parsing, as the
`std::str::Lines` iterator takes empty lines as no lines. `std::str::Lines` iterator takes empty lines as no lines.
* `libimagentryedit` fixed to inherit stdin and stderr to child process for
editor command.
## 0.6.3 ## 0.6.3

7
lib/core/libimagrt/src/runtime.rs
View file

@ -458,7 +458,12 @@ impl<'a> Runtime<'a> {
.value_of("editor") .value_of("editor")
.map(String::from) .map(String::from)
.or(env::var("EDITOR").ok()) .or(env::var("EDITOR").ok())
.map(Command::new) .map(|s| {
let mut c = Command::new(s);
c.stdin(::std::process::Stdio::inherit());
c.stderr(::std::process::Stdio::inherit());
c
})
} }
pub fn stdout(&self) -> OutputProxy { pub fn stdout(&self) -> OutputProxy {