matthiasbeyer/imag
1
0
Fork 0
Code Releases Activity

Add checks whether variables are valid unicode and propagate appropriate error

Browse source 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
This commit is contained in:
Matthias Beyer 2019-07-25 19:52:49 +02:00
parent 5f10ab976f
commit 9c896eb98b
1 changed files with 15 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
lib/core/libimagrt/src/runtime.rs
View file

@ -648,17 +648,26 @@ pub fn get_rtp_match<'a>(matches: &ArgMatches<'a>) -> Result<PathBuf> {
return Ok(p)
}
if let Ok(home) = env::var("IMAG_RTP") {
return Ok(PathBuf::from(home))
match env::var("IMAG_RTP").map(PathBuf::from) {
Ok(p) => return Ok(p),
Err(env::VarError::NotUnicode(_)) => {
return Err(err_msg("Environment variable 'IMAG_RTP' does not contain valid Unicode"))
},
Err(env::VarError::NotPresent) => { /* passthrough */ }
}
env::var("HOME")
.map(PathBuf::from)
.map(|mut p| { p.push(".imag"); p })
.map_err(|_| {
.map_err(|e| match e {
env::VarError::NotUnicode(_) => {
err_msg("Environment variable 'HOME' does not contain valid Unicode")
},
env::VarError::NotPresent => {
err_msg("You seem to be $HOME-less. Please get a $HOME before using this \
software. We are sorry for you and hope you have some \
accommodation anyways.")
}
})
}