matthiasbeyer
/
imag
1
0
Fork 0
Code Releases Activity

Add TODOs in code

This commit is contained in:
Matthias Beyer 2017-01-20 10:49:38 +01:00
parent 8419be1195
commit 9a47313adc
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libimagruby/src/store.rs
View File

@ -36,6 +36,7 @@ pub mod storeid {
let base = match base.map(|b| b.to_string()).map(PathBuf::from) { let base = match base.map(|b| b.to_string()).map(PathBuf::from) {
Ok(base) => base, Ok(base) => base,
Err(e) => { Err(e) => {
// TODO: Exception!
error!("Building StoreId object failed: {:?}", e); error!("Building StoreId object failed: {:?}", e);
return AnyObject::from(NilClass::new().value()); return AnyObject::from(NilClass::new().value());
}, },
@ -44,6 +45,7 @@ pub mod storeid {
let id = match id.map(|id| id.to_string()).map(PathBuf::from) { let id = match id.map(|id| id.to_string()).map(PathBuf::from) {
Ok(id) => id, Ok(id) => id,
Err(e) => { Err(e) => {
// TODO: Exception!
error!("Building StoreId object failed: {:?}", e); error!("Building StoreId object failed: {:?}", e);
return AnyObject::from(NilClass::new().value()); return AnyObject::from(NilClass::new().value());
}, },
@ -52,6 +54,7 @@ pub mod storeid {
match StoreId::new(Some(base), id) { match StoreId::new(Some(base), id) {
Ok(sid) => Class::from_existing("RStoreId").wrap_data(sid, &*STOREID_WRAPPER), Ok(sid) => Class::from_existing("RStoreId").wrap_data(sid, &*STOREID_WRAPPER),
Err(e) => { Err(e) => {
// TODO: Exception!
error!("Building StoreId object failed: {:?}", e); error!("Building StoreId object failed: {:?}", e);
return AnyObject::from(NilClass::new().value()); return AnyObject::from(NilClass::new().value());
}, },
@ -62,6 +65,7 @@ pub mod storeid {
let id = match id.map(|id| id.to_string()).map(PathBuf::from) { let id = match id.map(|id| id.to_string()).map(PathBuf::from) {
Ok(id) => id, Ok(id) => id,
Err(e) => { Err(e) => {
// TODO: Exception!
error!("Building StoreId object failed: {:?}", e); error!("Building StoreId object failed: {:?}", e);
return AnyObject::from(NilClass::new().value()); return AnyObject::from(NilClass::new().value());
}, },
@ -70,6 +74,7 @@ pub mod storeid {
match StoreId::new(None, id) { match StoreId::new(None, id) {
Ok(sid) => Class::from_existing("RStoreId").wrap_data(sid, &*STOREID_WRAPPER), Ok(sid) => Class::from_existing("RStoreId").wrap_data(sid, &*STOREID_WRAPPER),
Err(e) => { Err(e) => {
// TODO: Exception!
error!("Building StoreId object failed: {:?}", e); error!("Building StoreId object failed: {:?}", e);
return AnyObject::from(NilClass::new().value()); return AnyObject::from(NilClass::new().value());
}, },
@ -85,6 +90,7 @@ pub mod storeid {
let base : PathBuf = match base.map(|b| b.to_string()).map(PathBuf::from) { let base : PathBuf = match base.map(|b| b.to_string()).map(PathBuf::from) {
Ok(pb) => pb, Ok(pb) => pb,
Err(e) => { Err(e) => {
// TODO: Exception!
error!("Error: {:?}", e); error!("Error: {:?}", e);
return AnyObject::from(NilClass::new().value()); return AnyObject::from(NilClass::new().value());
}, },
@ -97,9 +103,11 @@ pub mod storeid {
itself.get_data(&*STOREID_WRAPPER) itself.get_data(&*STOREID_WRAPPER)
.clone() .clone()
.into_pathbuf() .into_pathbuf()
// TODO: No unwraps
.map(|pb| pb.to_str().map(String::from).unwrap()) .map(|pb| pb.to_str().map(String::from).unwrap())
.as_ref() .as_ref()
.map(|s| AnyObject::from(RString::new(s).value())) .map(|s| AnyObject::from(RString::new(s).value()))
// TODO: Exception!
.unwrap_or(AnyObject::from(NilClass::new().value())) .unwrap_or(AnyObject::from(NilClass::new().value()))
} }
@ -112,12 +120,13 @@ pub mod storeid {
.to_str() .to_str()
.as_ref() .as_ref()
.map(|s| AnyObject::from(RString::new(s).value())) .map(|s| AnyObject::from(RString::new(s).value()))
// TODO: Exception!
.unwrap_or(AnyObject::from(NilClass::new().value())) .unwrap_or(AnyObject::from(NilClass::new().value()))
} }
fn r_storeid_local() -> RString { fn r_storeid_local() -> RString {
let local = itself.get_data(&*STOREID_WRAPPER).local(); let local = itself.get_data(&*STOREID_WRAPPER).local();
let local = local.to_str().unwrap(); let local = local.to_str().unwrap(); // TODO: No unwraps
RString::new(local) RString::new(local)
} }
@ -140,4 +149,3 @@ pub mod storeid {
} }
} }