From 461d59fcb0ced16e0d9401798db38f04ed293c89 Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Sat, 14 Apr 2018 00:39:43 +0200 Subject: [PATCH 01/12] Add lints --- bin/core/imag-tag/src/main.rs | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/bin/core/imag-tag/src/main.rs b/bin/core/imag-tag/src/main.rs index 200456cd..0addc357 100644 --- a/bin/core/imag-tag/src/main.rs +++ b/bin/core/imag-tag/src/main.rs @@ -17,6 +17,21 @@ // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA // +#![deny( + non_camel_case_types, + non_snake_case, + path_statements, + trivial_numeric_casts, + unstable_features, + unused_allocation, + unused_import_braces, + unused_imports, + unused_must_use, + unused_mut, + unused_qualifications, + while_true, +)] + extern crate clap; #[macro_use] extern crate log; From f6f1c234560b6cf3143d40ad78dd4603c0ee6ab3 Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Sat, 14 Apr 2018 00:39:43 +0200 Subject: [PATCH 02/12] Add lints --- bin/core/imag/src/main.rs | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/bin/core/imag/src/main.rs b/bin/core/imag/src/main.rs index 396c515c..a83cc234 100644 --- a/bin/core/imag/src/main.rs +++ b/bin/core/imag/src/main.rs @@ -17,6 +17,21 @@ // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA // +#![deny( + non_camel_case_types, + non_snake_case, + path_statements, + trivial_numeric_casts, + unstable_features, + unused_allocation, + unused_import_braces, + unused_imports, + unused_must_use, + unused_mut, + unused_qualifications, + while_true, +)] + extern crate clap; #[macro_use] extern crate log; extern crate walkdir; From ad3269bbccd6de899e37939096a81f2071a0fb73 Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Sat, 14 Apr 2018 00:39:43 +0200 Subject: [PATCH 03/12] Add lints --- bin/domain/imag-contact/src/create.rs | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/bin/domain/imag-contact/src/create.rs b/bin/domain/imag-contact/src/create.rs index 03dde897..15d885b2 100644 --- a/bin/domain/imag-contact/src/create.rs +++ b/bin/domain/imag-contact/src/create.rs @@ -17,6 +17,21 @@ // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA // +#![deny( + non_camel_case_types, + non_snake_case, + path_statements, + trivial_numeric_casts, + unstable_features, + unused_allocation, + unused_import_braces, + unused_imports, + unused_must_use, + unused_mut, + unused_qualifications, + while_true, +)] + use std::collections::BTreeMap; use std::process::exit; use std::io::Write; From e71019a2f2bdca283de62b1e43876e67937f031b Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Sat, 14 Apr 2018 00:39:43 +0200 Subject: [PATCH 04/12] Add lints --- bin/domain/imag-mail/src/main.rs | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/bin/domain/imag-mail/src/main.rs b/bin/domain/imag-mail/src/main.rs index b7d67f80..7a1246dd 100644 --- a/bin/domain/imag-mail/src/main.rs +++ b/bin/domain/imag-mail/src/main.rs @@ -17,6 +17,21 @@ // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA // +#![deny( + non_camel_case_types, + non_snake_case, + path_statements, + trivial_numeric_casts, + unstable_features, + unused_allocation, + unused_import_braces, + unused_imports, + unused_must_use, + unused_mut, + unused_qualifications, + while_true, +)] + extern crate clap; #[macro_use] extern crate log; From f92163f6d037fea348fe5907eb369d40c3808073 Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Sat, 14 Apr 2018 00:39:43 +0200 Subject: [PATCH 05/12] Add lints --- bin/domain/imag-notes/src/main.rs | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/bin/domain/imag-notes/src/main.rs b/bin/domain/imag-notes/src/main.rs index 6d193b4c..5f9e23f0 100644 --- a/bin/domain/imag-notes/src/main.rs +++ b/bin/domain/imag-notes/src/main.rs @@ -17,6 +17,21 @@ // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA // +#![deny( + non_camel_case_types, + non_snake_case, + path_statements, + trivial_numeric_casts, + unstable_features, + unused_allocation, + unused_import_braces, + unused_imports, + unused_must_use, + unused_mut, + unused_qualifications, + while_true, +)] + extern crate clap; #[macro_use] extern crate log; extern crate itertools; From 561008bd7f9fafa5cc03c3e0a94e58b6291f7a51 Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Sat, 14 Apr 2018 00:39:43 +0200 Subject: [PATCH 06/12] Add lints --- bin/domain/imag-timetrack/src/main.rs | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/bin/domain/imag-timetrack/src/main.rs b/bin/domain/imag-timetrack/src/main.rs index 2f432452..d482d112 100644 --- a/bin/domain/imag-timetrack/src/main.rs +++ b/bin/domain/imag-timetrack/src/main.rs @@ -17,6 +17,21 @@ // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA // +#![deny( + non_camel_case_types, + non_snake_case, + path_statements, + trivial_numeric_casts, + unstable_features, + unused_allocation, + unused_import_braces, + unused_imports, + unused_must_use, + unused_mut, + unused_qualifications, + while_true, +)] + #[macro_use] extern crate log; From 1511d70fa3f828be9dbdfb37c3ad0e319dd3fb59 Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Sat, 14 Apr 2018 00:39:43 +0200 Subject: [PATCH 07/12] Add lints --- bin/domain/imag-todo/src/main.rs | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/bin/domain/imag-todo/src/main.rs b/bin/domain/imag-todo/src/main.rs index 22ae1ede..f6262a6f 100644 --- a/bin/domain/imag-todo/src/main.rs +++ b/bin/domain/imag-todo/src/main.rs @@ -17,6 +17,21 @@ // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA // +#![deny( + non_camel_case_types, + non_snake_case, + path_statements, + trivial_numeric_casts, + unstable_features, + unused_allocation, + unused_import_braces, + unused_imports, + unused_must_use, + unused_mut, + unused_qualifications, + while_true, +)] + extern crate clap; #[macro_use] extern crate log; extern crate toml; From a40d90fef23cb3e58e60155c27ec16f0243cc9d1 Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Sat, 14 Apr 2018 00:41:31 +0200 Subject: [PATCH 08/12] Add lints --- lib/domain/libimaghabit/src/lib.rs | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/lib/domain/libimaghabit/src/lib.rs b/lib/domain/libimaghabit/src/lib.rs index d8a5581e..5272cc6b 100644 --- a/lib/domain/libimaghabit/src/lib.rs +++ b/lib/domain/libimaghabit/src/lib.rs @@ -17,6 +17,22 @@ // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA // +#![deny( + dead_code, + non_camel_case_types, + non_snake_case, + path_statements, + trivial_numeric_casts, + unstable_features, + unused_allocation, + unused_import_braces, + unused_imports, + unused_must_use, + unused_mut, + unused_qualifications, + while_true, +)] + extern crate chrono; extern crate toml; extern crate toml_query; From d02b298d5a5fa43418dac86299ec33b1dd112c1f Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Sat, 14 Apr 2018 00:41:31 +0200 Subject: [PATCH 09/12] Add lints --- lib/domain/libimaglog/src/lib.rs | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/lib/domain/libimaglog/src/lib.rs b/lib/domain/libimaglog/src/lib.rs index 505d8b94..a094bf87 100644 --- a/lib/domain/libimaglog/src/lib.rs +++ b/lib/domain/libimaglog/src/lib.rs @@ -17,6 +17,22 @@ // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA // +#![deny( + dead_code, + non_camel_case_types, + non_snake_case, + path_statements, + trivial_numeric_casts, + unstable_features, + unused_allocation, + unused_import_braces, + unused_imports, + unused_must_use, + unused_mut, + unused_qualifications, + while_true, +)] + #[macro_use] extern crate error_chain; extern crate toml; From 40b85f13b5d2900931a9febb3ba387d94a9c00ed Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Sat, 14 Apr 2018 00:41:31 +0200 Subject: [PATCH 10/12] Add lints --- lib/entry/libimagentrygps/src/lib.rs | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/lib/entry/libimagentrygps/src/lib.rs b/lib/entry/libimagentrygps/src/lib.rs index f575dabb..6343d693 100644 --- a/lib/entry/libimagentrygps/src/lib.rs +++ b/lib/entry/libimagentrygps/src/lib.rs @@ -17,6 +17,22 @@ // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA // +#![deny( + dead_code, + non_camel_case_types, + non_snake_case, + path_statements, + trivial_numeric_casts, + unstable_features, + unused_allocation, + unused_import_braces, + unused_imports, + unused_must_use, + unused_mut, + unused_qualifications, + while_true, +)] + extern crate toml; extern crate toml_query; #[macro_use] extern crate serde_derive; From 207346bea0737ab0a5bb72e890302dd8a4830ffc Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Sat, 14 Apr 2018 00:41:31 +0200 Subject: [PATCH 11/12] Add lints --- lib/etc/libimagnotification/src/lib.rs | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/lib/etc/libimagnotification/src/lib.rs b/lib/etc/libimagnotification/src/lib.rs index 723091c7..6bf0f0e1 100644 --- a/lib/etc/libimagnotification/src/lib.rs +++ b/lib/etc/libimagnotification/src/lib.rs @@ -17,6 +17,22 @@ // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA // +#![deny( + dead_code, + non_camel_case_types, + non_snake_case, + path_statements, + trivial_numeric_casts, + unstable_features, + unused_allocation, + unused_import_braces, + unused_imports, + unused_must_use, + unused_mut, + unused_qualifications, + while_true, +)] + extern crate notify_rust; #[macro_use] extern crate error_chain; From 51b9b5c0db654f20ce8c106f48b023cfbd21ec6e Mon Sep 17 00:00:00 2001 From: Matthias Beyer Date: Sat, 14 Apr 2018 00:57:15 +0200 Subject: [PATCH 12/12] Fix: Use qualification --- bin/core/imag-annotate/src/main.rs | 2 +- bin/core/imag-store/src/main.rs | 2 +- bin/core/imag-tag/src/main.rs | 2 +- bin/domain/imag-diary/src/main.rs | 2 +- bin/domain/imag-log/src/main.rs | 2 +- bin/domain/imag-mail/src/main.rs | 2 +- bin/domain/imag-notes/src/main.rs | 2 +- bin/domain/imag-todo/src/main.rs | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/bin/core/imag-annotate/src/main.rs b/bin/core/imag-annotate/src/main.rs index d196c7cb..ddeecf90 100644 --- a/bin/core/imag-annotate/src/main.rs +++ b/bin/core/imag-annotate/src/main.rs @@ -79,7 +79,7 @@ fn main() { let _ = rt.handle_unknown_subcommand("imag-annotation", other, rt.cli()) .map_err_trace_exit_unwrap(1) .code() - .map(std::process::exit); + .map(::std::process::exit); }, } }); diff --git a/bin/core/imag-store/src/main.rs b/bin/core/imag-store/src/main.rs index 5ec16ce6..64297a67 100644 --- a/bin/core/imag-store/src/main.rs +++ b/bin/core/imag-store/src/main.rs @@ -98,7 +98,7 @@ fn main() { let _ = rt.handle_unknown_subcommand("imag-store", other, rt.cli()) .map_err_trace_exit_unwrap(1) .code() - .map(std::process::exit); + .map(::std::process::exit); }, }; } else { diff --git a/bin/core/imag-tag/src/main.rs b/bin/core/imag-tag/src/main.rs index 0addc357..d291af69 100644 --- a/bin/core/imag-tag/src/main.rs +++ b/bin/core/imag-tag/src/main.rs @@ -106,7 +106,7 @@ fn main() { let _ = rt.handle_unknown_subcommand("imag-tag", other, rt.cli()) .map_err_trace_exit_unwrap(1) .code() - .map(std::process::exit); + .map(::std::process::exit); }, }); } diff --git a/bin/domain/imag-diary/src/main.rs b/bin/domain/imag-diary/src/main.rs index 201f8431..85da8835 100644 --- a/bin/domain/imag-diary/src/main.rs +++ b/bin/domain/imag-diary/src/main.rs @@ -86,7 +86,7 @@ fn main() { let _ = rt.handle_unknown_subcommand("imag-diary", other, rt.cli()) .map_err_trace_exit_unwrap(1) .code() - .map(std::process::exit); + .map(::std::process::exit); }, } }); diff --git a/bin/domain/imag-log/src/main.rs b/bin/domain/imag-log/src/main.rs index bc5a6a74..277ccaea 100644 --- a/bin/domain/imag-log/src/main.rs +++ b/bin/domain/imag-log/src/main.rs @@ -77,7 +77,7 @@ fn main() { let _ = rt.handle_unknown_subcommand("imag-log", other, rt.cli()) .map_err_trace_exit_unwrap(1) .code() - .map(std::process::exit); + .map(::std::process::exit); }, } } else { diff --git a/bin/domain/imag-mail/src/main.rs b/bin/domain/imag-mail/src/main.rs index 7a1246dd..57ebf8ea 100644 --- a/bin/domain/imag-mail/src/main.rs +++ b/bin/domain/imag-mail/src/main.rs @@ -74,7 +74,7 @@ fn main() { let _ = rt.handle_unknown_subcommand("imag-mail", other, rt.cli()) .map_err_trace_exit_unwrap(1) .code() - .map(std::process::exit); + .map(::std::process::exit); } } }); diff --git a/bin/domain/imag-notes/src/main.rs b/bin/domain/imag-notes/src/main.rs index 5f9e23f0..188fe9a3 100644 --- a/bin/domain/imag-notes/src/main.rs +++ b/bin/domain/imag-notes/src/main.rs @@ -86,7 +86,7 @@ fn main() { let _ = rt.handle_unknown_subcommand("imag-notes", other, rt.cli()) .map_err_trace_exit_unwrap(1) .code() - .map(std::process::exit); + .map(::std::process::exit); }, }; }); diff --git a/bin/domain/imag-todo/src/main.rs b/bin/domain/imag-todo/src/main.rs index f6262a6f..cf1d4ccb 100644 --- a/bin/domain/imag-todo/src/main.rs +++ b/bin/domain/imag-todo/src/main.rs @@ -71,7 +71,7 @@ fn main() { let _ = rt.handle_unknown_subcommand("imag-todo", other, rt.cli()) .map_err_trace_exit_unwrap(1) .code() - .map(std::process::exit); + .map(::std::process::exit); } None => { warn!("No command");