matthiasbeyer/imag
1
0
Fork 0
Code Releases Activity

Update some things in the CONTRIBUTING guidelines

Browse source
This commit is contained in:
Matthias Beyer 2017-04-22 11:51:09 +02:00
parent 1c0c9ff378
commit 525491e21f
1 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
CONTRIBUTING.md
View file

@ -1,18 +1,18 @@
# Contributing to imag # Contributing to imag
So you want to contribute to imag! Thank you, that's awesome of you! So you want to contribute to imag! Thank you, that's awesome!
If you already have something in mind, go ahead with [the prerequisites If you already have something in mind, go ahead with [the prerequisites
section](#prerequisites). If you don't know what you could do, start here. section](#prerequisites). If you don't know what you could do, start here.
All contribors agree to the All contributors agree to the
[developer certificate of origin](#developer-certificate-of-origin) [developer certificate of origin](#developer-certificate-of-origin)
by contributing to imag. by contributing to imag.
## Without Github ## Without Github
If you do not want to use github for your contribution, this is completely okay If you do not want to use github for your contribution, this is completely okay.
with us. Feel free to contact [us via our mailinglist](http://imag-pim.org/mailinglist/) Feel free to contact [us via our mailinglist](http://imag-pim.org/mailinglist/)
via mail, feel also free to submit patches via mail (use `git format-patch` and via mail, feel also free to submit patches via mail (use `git format-patch` and
`git send-email`, always add a cover letter to describe your submission). `git send-email`, always add a cover letter to describe your submission).
@ -25,7 +25,7 @@ Once _I am_ okay with your patchset, I will
submit it as PR in the github repository, so more people can review it and CI submit it as PR in the github repository, so more people can review it and CI
can test it (the mailinglist is not yet used as much as github). I might come can test it (the mailinglist is not yet used as much as github). I might come
back to you if something broke in CI or someone has a suggestion how to improve back to you if something broke in CI or someone has a suggestion how to improve
your PR. I will keep you as author of the commits. your PR. I will keep you as author of the commits.
The following sections describe the way how to contribute with github. The following sections describe the way how to contribute with github.
@ -42,12 +42,13 @@ file issues about them or even better: Write a pull request to fix them!
## Prerequisites ## Prerequisites
* cargo and rust compiler in current version (stable) * cargo and rust compiler in current version (stable)
* Ruby and Bundler if you want to write a Ruby module.
Dependencies are listed in the [default.nix Dependencies are listed in the
file](http://git.imag-pim.org/imag/tree/default.nix), [default.nix file](http://git.imag-pim.org/imag/tree/default.nix),
though you do not have to have `nix` installed to build imag. though you do not have to have `nix` installed to build imag.
`make` (better: `gnu make`) can be helpful to automate the build process. `make` can be helpful to automate the build process.
Note that this software is targeted towards commandline linux users and we do Note that this software is targeted towards commandline linux users and we do
not aim to be portable to Windows or Mac OSX (though I wouldn't mind merging not aim to be portable to Windows or Mac OSX (though I wouldn't mind merging
@ -71,15 +72,15 @@ free to push "Fixup" commits in the review process. We will ask you to clean
your history before merging! your history before merging!
Make sure to prefix your commits with `"doc: "` if you change the document. Do Make sure to prefix your commits with `"doc: "` if you change the document. Do
not change document and code in one commit, always seperate them. not change document and code in one commit, always separate them.
We do not follow some official rust styleguide for our codebase, but we try to We do not follow some official Rust styleguide for our codebase, but we try to
write minimal and readable code. 100 characters per line, as few lines as write minimal and readable code. 100 characters per line, as few lines as
possible, avoid noise in the codebase, ... you get it. possible, avoid noise in the codebase, ... you get it.
Not all of your commits have to be buildable. But your PR has to be. Not all of your commits have to be buildable. But your PR has to be.
## PR guidelines: ## PR guidelines
We'd like to have one PR per module change. This means you _should_ only change We'd like to have one PR per module change. This means you _should_ only change
one imag module in one commit or PR (library plus belonging binary is okay). one imag module in one commit or PR (library plus belonging binary is okay).
@ -101,7 +102,7 @@ If you're writing an application or module for imag, feel free to propose
integrating it into the imag core distribution, if it fulfills the following integrating it into the imag core distribution, if it fulfills the following
requirements: requirements:
1. It is written in Rust 1. It is written in Rust or Ruby
1. It has a commandline interface which is the main interface to the module 1. It has a commandline interface which is the main interface to the module
OR it is a utility library for creating new kinds of functionality within the OR it is a utility library for creating new kinds of functionality within the
imag core. imag core.