matthiasbeyer/imag
1
0
Fork 0
Code Releases Activity

Spit out the traceback for hook registration errors only in debug mode

Browse source 
This patch is added because this error occours only if there is no
configuration file with the appropriate settings available.

There will still be a warning about hook registration failed, but the
traceback will only be visitible in `--debug` mode.
This commit is contained in:
Matthias Beyer 2016-04-05 16:47:51 +02:00
parent ee61d079bd
commit 4f391d0e04
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
libimagrt/src/runtime.rs
View file

@ -39,8 +39,10 @@ impl<'a> Runtime<'a> {
use std::error::Error; use std::error::Error;
use libimagstore::hook::position::HookPosition; use libimagstore::hook::position::HookPosition;
use libimagstore::error::StoreErrorKind;
use libimagstorestdhook::debug::DebugHook; use libimagstorestdhook::debug::DebugHook;
use libimagutil::trace::trace_error; use libimagutil::trace::trace_error;
use libimagutil::trace::trace_error_dbg;
use configuration::error::ConfigErrorKind; use configuration::error::ConfigErrorKind;
@ -109,8 +111,12 @@ impl<'a> Runtime<'a> {
// If it fails, trace the error and warn, but continue. // If it fails, trace the error and warn, but continue.
for (hook, position) in hooks { for (hook, position) in hooks {
if let Err(e) = store.register_hook(position, &String::from("debug"), Box::new(hook)) { if let Err(e) = store.register_hook(position, &String::from("debug"), Box::new(hook)) {
trace_error(&e); if e.err_type() == StoreErrorKind::HookRegisterError {
warn!("Registering debug hook with store failed"); trace_error_dbg(&e);
warn!("Registering debug hook with store failed");
} else {
trace_error(&e);
};
} }
} }
} }