matthiasbeyer/imag
1
0
Fork 0
Code Releases Activity

Bugfix: unique()ing the list of links

Browse source 
That should happen _after_ they are all in the same format.
This commit introduces overhead, as we clone() each string here for
comparison and that should clearly be fixed.

Though the bug-fix is more important at this point.
This commit is contained in:
Matthias Beyer 2016-09-06 10:56:23 +02:00
parent 584ac3d46e
commit 40014051ec
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
libimagentrylink/src/internal.rs
View file

@ -100,8 +100,13 @@ impl InternalLinker for Entry {
fn links_into_values(links: Vec<StoreId>) -> Vec<Result<Value>> { fn links_into_values(links: Vec<StoreId>) -> Vec<Result<Value>> {
links links
.into_iter() .into_iter()
.unique()
.map(|s| s.without_base().to_str().map_err_into(LEK::InternalConversionError)) .map(|s| s.without_base().to_str().map_err_into(LEK::InternalConversionError))
.unique_by(|entry| {
match entry {
&Ok(ref e) => Some(e.clone()),
&Err(_) => None,
}
})
.map(|elem| elem.map(Value::String)) .map(|elem| elem.map(Value::String))
.sorted_by(|a, b| { .sorted_by(|a, b| {
match (a, b) { match (a, b) {