matthiasbeyer/imag
1
0
Fork 0
Code Releases Activity

Fix: Remove default value for --verbose flag

Browse source 
This actually caused an error.

When executing `imag ids --verbose trace` for example, the `imag` binary
got the default value (as in `--verbose info`) supplied from clap. So
far, so good. Problem is that the implementation then forwarded that
flag to `imag-ids`, which resulted in the `--verbose` flag to be passed
_two times_ to `imag-ids`.

Somehow this is really strange, but it does not really matter. First of
all: A default of "Info" is still too high IMO. Default should be
warnings and errors, but no information printed. We like silent tools,
don't we?

Second is that the commandline argument forwarding mechanism of `imag`
is broken and this was a fix which helped debugging of the brokenness,
so this is acutally a step forward in this regard as well.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
This commit is contained in:
Matthias Beyer 2018-10-31 22:58:32 +01:00
parent 84f2f2c46f
commit 351849e349
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/core/libimagrt/src/runtime.rs
View file

@ -178,7 +178,6 @@ impl<'a> Runtime<'a> {
.required(false) .required(false)
.takes_value(true) .takes_value(true)
.possible_values(&["trace", "debug", "info", "warn", "error"]) .possible_values(&["trace", "debug", "info", "warn", "error"])
.default_value("info")
.value_name("LOGLEVEL")) .value_name("LOGLEVEL"))
.arg(Arg::with_name(Runtime::arg_debugging_name()) .arg(Arg::with_name(Runtime::arg_debugging_name())