From 19622f41aee752fe8f5c1e3097cad8b66b589ecc Mon Sep 17 00:00:00 2001
From: Matthias Beyer <mail@beyermatthias.de>
Date: Sat, 9 Mar 2019 12:39:56 +0100
Subject: [PATCH] Do not ignore errors when collecting links

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
---
 lib/entry/libimagentrylink/src/external.rs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/entry/libimagentrylink/src/external.rs b/lib/entry/libimagentrylink/src/external.rs
index 539bbe20..5d7084e4 100644
--- a/lib/entry/libimagentrylink/src/external.rs
+++ b/lib/entry/libimagentrylink/src/external.rs
@@ -409,10 +409,11 @@ impl ExternalLinker for Entry {
         debug!("Getting links");
         self.get_external_links(store)
             .and_then(|links| {
-                // TODO: Do not ignore errors here
-                let mut links = links.filter_map(Result::ok).collect::<Vec<_>>();
+                let mut links = links.collect::<Result<Vec<_>>>()?;
+
                 debug!("Adding link = '{:?}' to links = {:?}", link, links);
                 links.push(link);
+
                 debug!("Setting {} links = {:?}", links.len(), links);
                 self.set_external_links(store, links)
             })