Merge pull request #583 from impo/libimagref/deny-warnings

libimagref: Deny warnings and fix denied warnings

libimagref/src/flags.rs

@@ -32,7 +32,7 @@ impl RefFlags {
     }
 
     /// Alias for `RefFlags::content_hashing()`
-    pub fn is_often_moving(mut self, b: bool) -> RefFlags {
+    pub fn is_often_moving(self, b: bool) -> RefFlags {
         self.with_content_hashing(b)
     }
 

libimagref/src/lib.rs

@@ -1,3 +1,17 @@
+#![deny(
+    non_camel_case_types,
+    non_snake_case,
+    path_statements,
+    trivial_numeric_casts,
+    unstable_features,
+    unused_allocation,
+    unused_import_braces,
+    unused_imports,
+    unused_mut,
+    unused_qualifications,
+    while_true,
+)]
+
 #[macro_use] extern crate log;
 extern crate crypto;
 extern crate itertools;

libimagref/src/lister.rs

@@ -10,7 +10,6 @@ use libimagerror::trace::trace_error;
 use libimagstore::store::Entry;
 use libimagstore::store::FileLockEntry;
 use libimagerror::into::IntoError;
-use libimagentrylist::error::ListError as LE;
 use libimagentrylist::error::ListErrorKind as LEK;
 
 use reference::Ref;

libimagref/src/reference.rs

@@ -6,7 +6,7 @@ use std::ops::Deref;
 use std::ops::DerefMut;
 use std::collections::BTreeMap;
 use std::fs::File;
-use std::io::{Read, Write};
+use std::io::Read;
 use std::fmt::{Display, Error as FmtError, Formatter};
 use std::fs::Permissions;
 use std::result::Result as RResult;
@@ -204,7 +204,6 @@ impl<'a> Ref<'a> {
     /// Creates a Hash from a PathBuf by making the PathBuf absolute and then running a hash
     /// algorithm on it
     fn hash_path(pb: &PathBuf) -> Result<String> {
-        use std::io::Read;
         use crypto::sha1::Sha1;
         use crypto::digest::Digest;