Image proxy fixes (#4871)

* Fix remote image urls

* Remove unnecessary URL decode

* Removing the proxy changes.

---------

Co-authored-by: SleeplessOne1917 <28871516+SleeplessOne1917@users.noreply.github.com>
Co-authored-by: Dessalines <tyhou13@gmx.com>

Cargo.lock

@@ -2999,7 +2999,6 @@ dependencies = [
  "tokio",
  "tracing",
  "url",
- "urlencoding",
 ]
 
 [[package]]

crates/routes/Cargo.toml

@@ -32,5 +32,4 @@ serde = { workspace = true }
 url = { workspace = true }
 tracing = { workspace = true }
 tokio = { workspace = true }
-urlencoding = { workspace = true }
 rss = "2.0.8"

crates/routes/src/images.rs

@@ -22,7 +22,6 @@ use reqwest_middleware::{ClientWithMiddleware, RequestBuilder};
 use serde::Deserialize;
 use std::time::Duration;
 use url::Url;
-use urlencoding::decode;
 
 pub fn config(
   cfg: &mut web::ServiceConfig,
@@ -255,7 +254,7 @@ pub async fn image_proxy(
   client: web::Data<ClientWithMiddleware>,
   context: web::Data<LemmyContext>,
 ) -> LemmyResult<HttpResponse> {
-  let url = Url::parse(&decode(&params.url)?)?;
+  let url = Url::parse(&params.url)?;
 
   // Check that url corresponds to a federated image so that this can't be abused as a proxy
   // for arbitrary purposes.