grishka/lemmy
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #1225 from LemmyNet/fix_remove_icons

Browse source 
Fix invalid url error when removing icons. Fixes #1219
This commit is contained in:
Dessalines 2020-10-22 14:56:55 -04:00 committed by GitHub
commit cfa60dcb76
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lemmy_api/src/community.rs
View file

@ -140,8 +140,8 @@ impl Perform for CreateCommunity {
let icon = diesel_option_overwrite(&data.icon);
let banner = diesel_option_overwrite(&data.banner);
check_optional_url(&data.icon)?;
check_optional_url(&data.banner)?;
check_optional_url(&icon)?;
check_optional_url(&banner)?;
// When you create a community, make sure the user becomes a moderator and a follower
let keypair = generate_actor_keypair()?;
@ -240,8 +240,8 @@ impl Perform for EditCommunity {
let icon = diesel_option_overwrite(&data.icon);
let banner = diesel_option_overwrite(&data.banner);
check_optional_url(&data.icon)?;
check_optional_url(&data.banner)?;
check_optional_url(&icon)?;
check_optional_url(&banner)?;
let community_form = CommunityForm {
name: read_community.name,

4
lemmy_api/src/lib.rs
View file

@ -100,8 +100,8 @@ pub(in crate) async fn check_community_ban(
}
}
pub(in crate) fn check_optional_url(item: &Option<String>) -> Result<(), LemmyError> {
if let Some(item) = &item {
pub(in crate) fn check_optional_url(item: &Option<Option<String>>) -> Result<(), LemmyError> {
if let Some(Some(item)) = &item {
if Url::parse(item).is_err() {
return Err(APIError::err("invalid_url").into());
}

2
lemmy_api/src/post.rs
View file

@ -59,7 +59,7 @@ impl Perform for CreatePost {
check_community_ban(user.id, data.community_id, context.pool()).await?;
check_optional_url(&data.url)?;
check_optional_url(&Some(data.url.to_owned()))?;
// Fetch Iframely and pictrs cached image
let (iframely_title, iframely_description, iframely_html, pictrs_thumbnail) =

4
lemmy_api/src/user.rs
View file

@ -349,8 +349,8 @@ impl Perform for SaveUserSettings {
let matrix_user_id = diesel_option_overwrite(&data.matrix_user_id);
// Check to make sure the avatar and banners are urls
check_optional_url(&data.avatar)?;
check_optional_url(&data.banner)?;
check_optional_url(&avatar)?;
check_optional_url(&banner)?;
if let Some(Some(bio)) = &bio {
if bio.chars().count() > 300 {