grishka/lemmy
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

prevent ordering by comment path without post filter (#3717)

Browse source
This commit is contained in:
phiresky 2023-07-25 18:46:00 +02:00 committed by GitHub
parent 13a866aeb0
commit 3b09d8c882
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
crates/db_views/src/comment_view.rs
View file

@ -340,8 +340,11 @@ impl<'a> CommentQuery<'a> {
query = query.filter(nlevel(comment::path).le(depth_limit)); query = query.filter(nlevel(comment::path).le(depth_limit));
// Always order by the parent path first // only order if filtering by a post id. DOS potential otherwise and max_depth + !post_id isn't used anyways (afaik)
query = query.order_by(subpath(comment::path, 0, -1)); if self.post_id.is_some() {
// Always order by the parent path first
query = query.order_by(subpath(comment::path, 0, -1));
}
// TODO limit question. Limiting does not work for comment threads ATM, only max_depth // TODO limit question. Limiting does not work for comment threads ATM, only max_depth
// For now, don't do any limiting for tree fetches // For now, don't do any limiting for tree fetches