mirror of
https://github.com/LemmyNet/lemmy.git
synced 2024-11-15 00:43:59 +00:00
Nutomic
b2aee565f3
* Allow passing auth via header or cookie * revert submodule * taplo * fix build * working * convert apub api methods * also set cache-control header * opt * clippy * deduplicate code, ignore invalid auth * clippy --------- Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
120 lines
3.6 KiB
Rust
120 lines
3.6 KiB
Rust
use actix_web::{
|
|
body::MessageBody,
|
|
cookie::SameSite,
|
|
dev::{forward_ready, Service, ServiceRequest, ServiceResponse, Transform},
|
|
http::header::CACHE_CONTROL,
|
|
Error,
|
|
HttpMessage,
|
|
};
|
|
use core::future::Ready;
|
|
use futures_util::future::LocalBoxFuture;
|
|
use lemmy_api_common::{context::LemmyContext, utils::local_user_view_from_jwt};
|
|
use lemmy_utils::error::{LemmyError, LemmyErrorType};
|
|
use reqwest::header::HeaderValue;
|
|
use std::{future::ready, rc::Rc};
|
|
|
|
static AUTH_COOKIE_NAME: &str = "auth";
|
|
|
|
#[derive(Clone)]
|
|
pub struct SessionMiddleware {
|
|
context: LemmyContext,
|
|
}
|
|
|
|
impl SessionMiddleware {
|
|
pub fn new(context: LemmyContext) -> Self {
|
|
SessionMiddleware { context }
|
|
}
|
|
}
|
|
impl<S, B> Transform<S, ServiceRequest> for SessionMiddleware
|
|
where
|
|
S: Service<ServiceRequest, Response = ServiceResponse<B>, Error = Error> + 'static,
|
|
S::Future: 'static,
|
|
B: MessageBody + 'static,
|
|
{
|
|
type Response = ServiceResponse<B>;
|
|
type Error = Error;
|
|
type Transform = SessionService<S>;
|
|
type InitError = ();
|
|
type Future = Ready<Result<Self::Transform, Self::InitError>>;
|
|
|
|
fn new_transform(&self, service: S) -> Self::Future {
|
|
ready(Ok(SessionService {
|
|
service: Rc::new(service),
|
|
context: self.context.clone(),
|
|
}))
|
|
}
|
|
}
|
|
|
|
pub struct SessionService<S> {
|
|
service: Rc<S>,
|
|
context: LemmyContext,
|
|
}
|
|
|
|
impl<S, B> Service<ServiceRequest> for SessionService<S>
|
|
where
|
|
S: Service<ServiceRequest, Response = ServiceResponse<B>, Error = Error> + 'static,
|
|
S::Future: 'static,
|
|
B: 'static,
|
|
{
|
|
type Response = ServiceResponse<B>;
|
|
type Error = Error;
|
|
type Future = LocalBoxFuture<'static, Result<Self::Response, Self::Error>>;
|
|
|
|
forward_ready!(service);
|
|
|
|
fn call(&self, req: ServiceRequest) -> Self::Future {
|
|
let svc = self.service.clone();
|
|
let context = self.context.clone();
|
|
|
|
Box::pin(async move {
|
|
// Try reading jwt from auth header
|
|
let auth_header = req
|
|
.headers()
|
|
.get(AUTH_COOKIE_NAME)
|
|
.and_then(|h| h.to_str().ok());
|
|
let jwt = if let Some(a) = auth_header {
|
|
Some(a.to_string())
|
|
}
|
|
// If that fails, try auth cookie. Dont use the `jwt` cookie from lemmy-ui because
|
|
// its not http-only.
|
|
else {
|
|
let auth_cookie = req.cookie(AUTH_COOKIE_NAME);
|
|
if let Some(a) = &auth_cookie {
|
|
// ensure that its marked as httponly and secure
|
|
let secure = a.secure().unwrap_or_default();
|
|
let http_only = a.http_only().unwrap_or_default();
|
|
let same_site = a.same_site();
|
|
if !secure || !http_only || same_site != Some(SameSite::Strict) {
|
|
return Err(LemmyError::from(LemmyErrorType::AuthCookieInsecure).into());
|
|
}
|
|
}
|
|
auth_cookie.map(|c| c.value().to_string())
|
|
};
|
|
|
|
if let Some(jwt) = &jwt {
|
|
// Ignore any invalid auth so the site can still be used
|
|
// TODO: this means it will be impossible to get any error message for invalid jwt. Need
|
|
// to add a separate endpoint for that.
|
|
// https://github.com/LemmyNet/lemmy/issues/3702
|
|
let local_user_view = local_user_view_from_jwt(jwt, &context).await.ok();
|
|
if let Some(local_user_view) = local_user_view {
|
|
req.extensions_mut().insert(local_user_view);
|
|
}
|
|
}
|
|
|
|
let mut res = svc.call(req).await?;
|
|
|
|
// Add cache-control header. If user is authenticated, mark as private. Otherwise cache
|
|
// up to one minute.
|
|
let cache_value = if jwt.is_some() {
|
|
"private"
|
|
} else {
|
|
"public, max-age=60"
|
|
};
|
|
res
|
|
.headers_mut()
|
|
.insert(CACHE_CONTROL, HeaderValue::from_static(cache_value));
|
|
Ok(res)
|
|
})
|
|
}
|
|
}
|