mirror of
https://github.com/LemmyNet/lemmy.git
synced 2024-12-27 13:21:32 +00:00
2e8687e203
* Update comment_report_view.rs * Update comment_report_view.rs * Update post_view.rs * Update utils.rs * Update schema.rs * stuff * stuff * fix actions * PostLike * fmt * more post stuff (partial) * remove uplete * returning * rename read_comments field * PersonPostAggregates * a * fix usage of read_comments_amount * comment * community * community_block * instance_block * LocalUser::export_backup * person_block * person * stuff (partial) * update cargo.lock * fix lemmy_db_schema * post_view * comment_report_view * comment_view * post_report_view * find and replace some selected values * private_message_view * vote_view * comment_reply_view * some action views * action_query, find_action * community_view * block views * person_mention_view * remove struct update * refactor actions function * actions_alias * clean up return types and trait bounds * fix all rust code * fmt * clippy fix * Migrate tables * migrate indexes and contraints, and add statistics * fix what appears to be a messed up merge * commented thing * Create uplete.rs * Update uplete.rs * Update uplete.rs * Update up.sql * Update comment.rs * Update Cargo.toml * Update comment.rs * Update post.rs * Update comment_view.rs * Update post_view.rs * Update comment_reply_view.rs * Update person_mention_view.rs * Update Cargo.toml * Update utils.rs * Update comment.rs * Update utils.rs * Update uplete.rs * Update uplete.rs * Update uplete.rs * Update comment.rs * Update uplete.rs * Update uplete.rs * Update uplete.rs * Update uplete.rs * Update uplete.rs * Update uplete.rs * Update comment_view.rs * Update post_view.rs * Update triggers.sql * Update triggers.sql * Update triggers.sql * Update comment_reply_view.rs * Update person_mention_view.rs * Update person_mention_view.rs * Update comment_reply_view.rs * Update uplete.rs * start removing post_id column * Update down.sql * Update schema.rs * Update comment.rs * Update comment.rs * Update comment.rs * Update schema.rs * Update comment.rs * Update like.rs * Update comment.rs * Update up.sql * Update down.sql * Update down.sql * Update up.sql * Update up.sql * Update down.sql * Update comment.rs * Update vote_view.rs * Update vote_view.rs * Update comment_aggregates.rs * Update person_aggregates.rs * Update comment_view.rs * Update vote_view.rs * Update mod.rs * Update create.rs * Update comment.rs * Update community.rs * Update community.rs * Update up.sql * Update uplete.rs * Update uplete.rs * revert to UpleteCount * Update comment.rs * Update traits.rs * Update comment.rs * Update community.rs * Update community_block.rs * Update community.rs * Update instance_block.rs * Update instance.rs * Update community_block.rs * Update person.rs * Update person_block.rs * Update person.rs * Update person_block.rs * Update person.rs * Update instance.rs * Update instance_block.rs * Update instance.rs * Update person.rs * Update post.rs * Update comment.rs * Update community.rs * Update person.rs * Update post_view.rs * Update comment.rs * reduce diff * revert some changes in views * Update post_view.rs * Update comment.rs * Update post.rs * fix missing cfg_attr * rewrite uplete * Update Cargo.toml * Update Cargo.toml * Update uplete.rs * add `pub` to structs that appear in trait bounds * optional = true * Update uplete.rs * Update community.rs * Update comment.rs * Update uplete.rs * Update uplete.rs * Update uplete.rs * Update uplete.rs * something is wrong with me * use new uplete function everywhere * fmt * fmt * Keep post_id when comment_actions::liked is not null * Update up.sql * Update up.sql * clean up up.sql * clean up down.sql * fix * Update person_aggregates.rs * fmt * Update uplete.rs * fmt * Update uplete.rs * Update community.rs * Update uplete.rs * Update local_user.rs * fmt * fix * fix * fmt * improve uplete api * Update uplete.rs * fix * fix * Update uplete.rs * Update uplete.rs * Update uplete.rs * Update uplete.rs * fix * fix test * fix db_views_actor imports * fix uplete import in post_view test * rerun ci * fix AllNull syntax error * fix DynColumn * Fix rust syntax * fmt * fix iter * pain * Update community_moderators.rs * Update community_moderator_view.rs * Update uplete.rs * Fix mistake found by chatgpt * revert debugging stuff, change migration date, refactor constraint * Update down.sql * Update down.sql * fmt * make things added to db_schema::utils more understandable * update rust version for woodpecker * finish merge * Fix index that checked read_comments twice instead of also checking read_comments_amount * fix * uplete: test_count, test_generated_sql_setting_one_column_null, test_count_methods * refactor uplete sql test * test setting both columns to null in uplete * make AllNull generic * test AllNull * Merge remote-tracking branch 'upstream/main' into smoosh-tables-together --------- Co-authored-by: phiresky <phireskyde+git@gmail.com>
397 lines
12 KiB
Rust
397 lines
12 KiB
Rust
use crate::structs::PrivateMessageView;
|
|
use diesel::{
|
|
debug_query,
|
|
pg::Pg,
|
|
result::Error,
|
|
BoolExpressionMethods,
|
|
ExpressionMethods,
|
|
JoinOnDsl,
|
|
QueryDsl,
|
|
};
|
|
use diesel_async::RunQueryDsl;
|
|
use lemmy_db_schema::{
|
|
aliases,
|
|
newtypes::{PersonId, PrivateMessageId},
|
|
schema::{instance_actions, person, person_actions, private_message},
|
|
utils::{actions, get_conn, limit_and_offset, DbConn, DbPool, ListFn, Queries, ReadFn},
|
|
};
|
|
use tracing::debug;
|
|
|
|
fn queries<'a>() -> Queries<
|
|
impl ReadFn<'a, PrivateMessageView, PrivateMessageId>,
|
|
impl ListFn<'a, PrivateMessageView, (PrivateMessageQuery, PersonId)>,
|
|
> {
|
|
let all_joins = |query: private_message::BoxedQuery<'a, Pg>| {
|
|
query
|
|
.inner_join(person::table.on(private_message::creator_id.eq(person::id)))
|
|
.inner_join(
|
|
aliases::person1.on(private_message::recipient_id.eq(aliases::person1.field(person::id))),
|
|
)
|
|
.left_join(actions(
|
|
person_actions::table,
|
|
Some(aliases::person1.field(person::id)),
|
|
private_message::creator_id,
|
|
))
|
|
.left_join(actions(
|
|
instance_actions::table,
|
|
Some(aliases::person1.field(person::id)),
|
|
person::instance_id,
|
|
))
|
|
};
|
|
|
|
let selection = (
|
|
private_message::all_columns,
|
|
person::all_columns,
|
|
aliases::person1.fields(person::all_columns),
|
|
);
|
|
|
|
let read = move |mut conn: DbConn<'a>, private_message_id: PrivateMessageId| async move {
|
|
all_joins(private_message::table.find(private_message_id).into_boxed())
|
|
.order_by(private_message::published.desc())
|
|
.select(selection)
|
|
.first(&mut conn)
|
|
.await
|
|
};
|
|
|
|
let list = move |mut conn: DbConn<'a>,
|
|
(options, recipient_id): (PrivateMessageQuery, PersonId)| async move {
|
|
let mut query = all_joins(private_message::table.into_boxed())
|
|
.select(selection)
|
|
// Dont show replies from blocked users
|
|
.filter(person_actions::blocked.is_null())
|
|
// Dont show replies from blocked instances
|
|
.filter(instance_actions::blocked.is_null());
|
|
|
|
// If its unread, I only want the ones to me
|
|
if options.unread_only {
|
|
query = query.filter(private_message::read.eq(false));
|
|
if let Some(i) = options.creator_id {
|
|
query = query.filter(private_message::creator_id.eq(i))
|
|
}
|
|
query = query.filter(private_message::recipient_id.eq(recipient_id));
|
|
}
|
|
// Otherwise, I want the ALL view to show both sent and received
|
|
else {
|
|
query = query.filter(
|
|
private_message::recipient_id
|
|
.eq(recipient_id)
|
|
.or(private_message::creator_id.eq(recipient_id)),
|
|
);
|
|
if let Some(i) = options.creator_id {
|
|
query = query.filter(
|
|
private_message::creator_id
|
|
.eq(i)
|
|
.or(private_message::recipient_id.eq(i)),
|
|
)
|
|
}
|
|
}
|
|
|
|
let (limit, offset) = limit_and_offset(options.page, options.limit)?;
|
|
|
|
query = query
|
|
.filter(private_message::deleted.eq(false))
|
|
.limit(limit)
|
|
.offset(offset)
|
|
.order_by(private_message::published.desc());
|
|
|
|
debug!(
|
|
"Private Message View Query: {:?}",
|
|
debug_query::<Pg, _>(&query)
|
|
);
|
|
|
|
query.load::<PrivateMessageView>(&mut conn).await
|
|
};
|
|
|
|
Queries::new(read, list)
|
|
}
|
|
|
|
impl PrivateMessageView {
|
|
pub async fn read(
|
|
pool: &mut DbPool<'_>,
|
|
private_message_id: PrivateMessageId,
|
|
) -> Result<Self, Error> {
|
|
queries().read(pool, private_message_id).await
|
|
}
|
|
|
|
/// Gets the number of unread messages
|
|
pub async fn get_unread_messages(
|
|
pool: &mut DbPool<'_>,
|
|
my_person_id: PersonId,
|
|
) -> Result<i64, Error> {
|
|
use diesel::dsl::count;
|
|
let conn = &mut get_conn(pool).await?;
|
|
private_message::table
|
|
// Necessary to get the senders instance_id
|
|
.inner_join(person::table.on(private_message::creator_id.eq(person::id)))
|
|
.left_join(actions(
|
|
person_actions::table,
|
|
Some(my_person_id),
|
|
private_message::creator_id,
|
|
))
|
|
.left_join(actions(
|
|
instance_actions::table,
|
|
Some(my_person_id),
|
|
person::instance_id,
|
|
))
|
|
// Dont count replies from blocked users
|
|
.filter(person_actions::blocked.is_null())
|
|
// Dont count replies from blocked instances
|
|
.filter(instance_actions::blocked.is_null())
|
|
.filter(private_message::read.eq(false))
|
|
.filter(private_message::recipient_id.eq(my_person_id))
|
|
.filter(private_message::deleted.eq(false))
|
|
.select(count(private_message::id))
|
|
.first::<i64>(conn)
|
|
.await
|
|
}
|
|
}
|
|
|
|
#[derive(Default)]
|
|
pub struct PrivateMessageQuery {
|
|
pub unread_only: bool,
|
|
pub page: Option<i64>,
|
|
pub limit: Option<i64>,
|
|
pub creator_id: Option<PersonId>,
|
|
}
|
|
|
|
impl PrivateMessageQuery {
|
|
pub async fn list(
|
|
self,
|
|
pool: &mut DbPool<'_>,
|
|
recipient_id: PersonId,
|
|
) -> Result<Vec<PrivateMessageView>, Error> {
|
|
queries().list(pool, (self, recipient_id)).await
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
#[expect(clippy::indexing_slicing)]
|
|
mod tests {
|
|
|
|
use crate::{private_message_view::PrivateMessageQuery, structs::PrivateMessageView};
|
|
use lemmy_db_schema::{
|
|
assert_length,
|
|
newtypes::InstanceId,
|
|
source::{
|
|
instance::Instance,
|
|
instance_block::{InstanceBlock, InstanceBlockForm},
|
|
person::{Person, PersonInsertForm},
|
|
person_block::{PersonBlock, PersonBlockForm},
|
|
private_message::{PrivateMessage, PrivateMessageInsertForm},
|
|
},
|
|
traits::{Blockable, Crud},
|
|
utils::{build_db_pool_for_tests, DbPool},
|
|
};
|
|
use lemmy_utils::error::LemmyResult;
|
|
use pretty_assertions::assert_eq;
|
|
use serial_test::serial;
|
|
|
|
struct Data {
|
|
instance: Instance,
|
|
timmy: Person,
|
|
jess: Person,
|
|
sara: Person,
|
|
}
|
|
|
|
async fn init_data(pool: &mut DbPool<'_>) -> LemmyResult<Data> {
|
|
let message_content = String::new();
|
|
|
|
let instance = Instance::read_or_create(pool, "my_domain.tld".to_string()).await?;
|
|
|
|
let timmy_form = PersonInsertForm::test_form(instance.id, "timmy_rav");
|
|
|
|
let timmy = Person::create(pool, &timmy_form).await?;
|
|
|
|
let sara_form = PersonInsertForm::test_form(instance.id, "sara_rav");
|
|
|
|
let sara = Person::create(pool, &sara_form).await?;
|
|
|
|
let jess_form = PersonInsertForm::test_form(instance.id, "jess_rav");
|
|
|
|
let jess = Person::create(pool, &jess_form).await?;
|
|
|
|
let sara_timmy_message_form =
|
|
PrivateMessageInsertForm::new(sara.id, timmy.id, message_content.clone());
|
|
PrivateMessage::create(pool, &sara_timmy_message_form).await?;
|
|
|
|
let sara_jess_message_form =
|
|
PrivateMessageInsertForm::new(sara.id, jess.id, message_content.clone());
|
|
PrivateMessage::create(pool, &sara_jess_message_form).await?;
|
|
|
|
let timmy_sara_message_form =
|
|
PrivateMessageInsertForm::new(timmy.id, sara.id, message_content.clone());
|
|
PrivateMessage::create(pool, &timmy_sara_message_form).await?;
|
|
|
|
let jess_timmy_message_form =
|
|
PrivateMessageInsertForm::new(jess.id, timmy.id, message_content.clone());
|
|
PrivateMessage::create(pool, &jess_timmy_message_form).await?;
|
|
|
|
Ok(Data {
|
|
instance,
|
|
timmy,
|
|
jess,
|
|
sara,
|
|
})
|
|
}
|
|
|
|
async fn cleanup(instance_id: InstanceId, pool: &mut DbPool<'_>) -> LemmyResult<()> {
|
|
// This also deletes all persons and private messages thanks to sql `on delete cascade`
|
|
Instance::delete(pool, instance_id).await?;
|
|
Ok(())
|
|
}
|
|
|
|
#[tokio::test]
|
|
#[serial]
|
|
async fn read_private_messages() -> LemmyResult<()> {
|
|
let pool = &build_db_pool_for_tests();
|
|
let pool = &mut pool.into();
|
|
let Data {
|
|
timmy,
|
|
jess,
|
|
sara,
|
|
instance,
|
|
} = init_data(pool).await?;
|
|
|
|
let timmy_messages = PrivateMessageQuery {
|
|
unread_only: false,
|
|
creator_id: None,
|
|
..Default::default()
|
|
}
|
|
.list(pool, timmy.id)
|
|
.await?;
|
|
|
|
assert_length!(3, &timmy_messages);
|
|
assert_eq!(timmy_messages[0].creator.id, jess.id);
|
|
assert_eq!(timmy_messages[0].recipient.id, timmy.id);
|
|
assert_eq!(timmy_messages[1].creator.id, timmy.id);
|
|
assert_eq!(timmy_messages[1].recipient.id, sara.id);
|
|
assert_eq!(timmy_messages[2].creator.id, sara.id);
|
|
assert_eq!(timmy_messages[2].recipient.id, timmy.id);
|
|
|
|
let timmy_unread_messages = PrivateMessageQuery {
|
|
unread_only: true,
|
|
creator_id: None,
|
|
..Default::default()
|
|
}
|
|
.list(pool, timmy.id)
|
|
.await?;
|
|
|
|
assert_length!(2, &timmy_unread_messages);
|
|
assert_eq!(timmy_unread_messages[0].creator.id, jess.id);
|
|
assert_eq!(timmy_unread_messages[0].recipient.id, timmy.id);
|
|
assert_eq!(timmy_unread_messages[1].creator.id, sara.id);
|
|
assert_eq!(timmy_unread_messages[1].recipient.id, timmy.id);
|
|
|
|
let timmy_sara_messages = PrivateMessageQuery {
|
|
unread_only: false,
|
|
creator_id: Some(sara.id),
|
|
..Default::default()
|
|
}
|
|
.list(pool, timmy.id)
|
|
.await?;
|
|
|
|
assert_length!(2, &timmy_sara_messages);
|
|
assert_eq!(timmy_sara_messages[0].creator.id, timmy.id);
|
|
assert_eq!(timmy_sara_messages[0].recipient.id, sara.id);
|
|
assert_eq!(timmy_sara_messages[1].creator.id, sara.id);
|
|
assert_eq!(timmy_sara_messages[1].recipient.id, timmy.id);
|
|
|
|
let timmy_sara_unread_messages = PrivateMessageQuery {
|
|
unread_only: true,
|
|
creator_id: Some(sara.id),
|
|
..Default::default()
|
|
}
|
|
.list(pool, timmy.id)
|
|
.await?;
|
|
|
|
assert_length!(1, &timmy_sara_unread_messages);
|
|
assert_eq!(timmy_sara_unread_messages[0].creator.id, sara.id);
|
|
assert_eq!(timmy_sara_unread_messages[0].recipient.id, timmy.id);
|
|
|
|
cleanup(instance.id, pool).await
|
|
}
|
|
|
|
#[tokio::test]
|
|
#[serial]
|
|
async fn ensure_person_block() -> LemmyResult<()> {
|
|
let pool = &build_db_pool_for_tests();
|
|
let pool = &mut pool.into();
|
|
let Data {
|
|
timmy,
|
|
sara,
|
|
instance,
|
|
jess: _,
|
|
} = init_data(pool).await?;
|
|
|
|
// Make sure blocks are working
|
|
let timmy_blocks_sara_form = PersonBlockForm {
|
|
person_id: timmy.id,
|
|
target_id: sara.id,
|
|
};
|
|
|
|
let inserted_block = PersonBlock::block(pool, &timmy_blocks_sara_form).await?;
|
|
|
|
let expected_block = PersonBlock {
|
|
person_id: timmy.id,
|
|
target_id: sara.id,
|
|
published: inserted_block.published,
|
|
};
|
|
assert_eq!(expected_block, inserted_block);
|
|
|
|
let timmy_messages = PrivateMessageQuery {
|
|
unread_only: true,
|
|
creator_id: None,
|
|
..Default::default()
|
|
}
|
|
.list(pool, timmy.id)
|
|
.await?;
|
|
|
|
assert_length!(1, &timmy_messages);
|
|
|
|
let timmy_unread_messages = PrivateMessageView::get_unread_messages(pool, timmy.id).await?;
|
|
assert_eq!(timmy_unread_messages, 1);
|
|
|
|
cleanup(instance.id, pool).await
|
|
}
|
|
|
|
#[tokio::test]
|
|
#[serial]
|
|
async fn ensure_instance_block() -> LemmyResult<()> {
|
|
let pool = &build_db_pool_for_tests();
|
|
let pool = &mut pool.into();
|
|
let Data {
|
|
timmy,
|
|
jess: _,
|
|
sara,
|
|
instance,
|
|
} = init_data(pool).await?;
|
|
// Make sure instance_blocks are working
|
|
let timmy_blocks_instance_form = InstanceBlockForm {
|
|
person_id: timmy.id,
|
|
instance_id: sara.instance_id,
|
|
};
|
|
|
|
let inserted_instance_block = InstanceBlock::block(pool, &timmy_blocks_instance_form).await?;
|
|
|
|
let expected_instance_block = InstanceBlock {
|
|
person_id: timmy.id,
|
|
instance_id: sara.instance_id,
|
|
published: inserted_instance_block.published,
|
|
};
|
|
assert_eq!(expected_instance_block, inserted_instance_block);
|
|
|
|
let timmy_messages = PrivateMessageQuery {
|
|
unread_only: true,
|
|
creator_id: None,
|
|
..Default::default()
|
|
}
|
|
.list(pool, timmy.id)
|
|
.await?;
|
|
|
|
assert_length!(0, &timmy_messages);
|
|
|
|
let timmy_unread_messages = PrivateMessageView::get_unread_messages(pool, timmy.id).await?;
|
|
assert_eq!(timmy_unread_messages, 0);
|
|
cleanup(instance.id, pool).await
|
|
}
|
|
}
|