mirror of
https://github.com/LemmyNet/lemmy.git
synced 2024-12-28 13:51:32 +00:00
55f84dd38a
* Adding an image_details table to store image dimensions. - Adds an image_details table, which stores the height, width, and content_type for local and remote images. - For LocalImages, this information already comes back with the upload. - For RemoteImages, it calls the pictrs details endpoint. - Fixed some issues with proxying non-image urls. - Fixes #3328 - Also fixes #4703 * Running sql format. * Running fmt. * Don't fetch metadata in background for local API requests. * Dont export remote_image table to typescript. * Cleaning up validate. * Dont proxy url. * Fixing tests, fixing issue with federated thumbnails. * Fix tests. * Updating corepack, fixing issue. * Refactoring image inserts to use transactions. * Use select exists again. * Fixing imports. * Fix test. * Removing pointless backgrounded metadata generation version. * Removing public pictrs details route. * Fixing clippy. * Fixing proxy image fetching. Fixes #4703 - This extracts only the proxy image fixes from #4704, leaving off thumbnails. * Fix test. * Addressing PR comments. * Address PR comments 2. --------- Co-authored-by: SleeplessOne1917 <28871516+SleeplessOne1917@users.noreply.github.com>
535 lines
18 KiB
TypeScript
535 lines
18 KiB
TypeScript
jest.setTimeout(120000);
|
|
|
|
import { CommunityView } from "lemmy-js-client/dist/types/CommunityView";
|
|
import {
|
|
alpha,
|
|
beta,
|
|
gamma,
|
|
setupLogins,
|
|
resolveCommunity,
|
|
createCommunity,
|
|
deleteCommunity,
|
|
removeCommunity,
|
|
getCommunity,
|
|
followCommunity,
|
|
banPersonFromCommunity,
|
|
resolvePerson,
|
|
getSite,
|
|
createPost,
|
|
getPost,
|
|
resolvePost,
|
|
registerUser,
|
|
getPosts,
|
|
getComments,
|
|
createComment,
|
|
getCommunityByName,
|
|
blockInstance,
|
|
waitUntil,
|
|
alphaUrl,
|
|
delta,
|
|
betaAllowedInstances,
|
|
searchPostLocal,
|
|
longDelay,
|
|
editCommunity,
|
|
unfollows,
|
|
} from "./shared";
|
|
import { EditCommunity, EditSite } from "lemmy-js-client";
|
|
|
|
beforeAll(setupLogins);
|
|
afterAll(unfollows);
|
|
|
|
function assertCommunityFederation(
|
|
communityOne?: CommunityView,
|
|
communityTwo?: CommunityView,
|
|
) {
|
|
expect(communityOne?.community.actor_id).toBe(
|
|
communityTwo?.community.actor_id,
|
|
);
|
|
expect(communityOne?.community.name).toBe(communityTwo?.community.name);
|
|
expect(communityOne?.community.title).toBe(communityTwo?.community.title);
|
|
expect(communityOne?.community.description).toBe(
|
|
communityTwo?.community.description,
|
|
);
|
|
expect(communityOne?.community.icon).toBe(communityTwo?.community.icon);
|
|
expect(communityOne?.community.banner).toBe(communityTwo?.community.banner);
|
|
expect(communityOne?.community.published).toBe(
|
|
communityTwo?.community.published,
|
|
);
|
|
expect(communityOne?.community.nsfw).toBe(communityTwo?.community.nsfw);
|
|
expect(communityOne?.community.removed).toBe(communityTwo?.community.removed);
|
|
expect(communityOne?.community.deleted).toBe(communityTwo?.community.deleted);
|
|
}
|
|
|
|
test("Create community", async () => {
|
|
let communityRes = await createCommunity(alpha);
|
|
expect(communityRes.community_view.community.name).toBeDefined();
|
|
|
|
// A dupe check
|
|
let prevName = communityRes.community_view.community.name;
|
|
await expect(createCommunity(alpha, prevName)).rejects.toStrictEqual(
|
|
Error("community_already_exists"),
|
|
);
|
|
|
|
// Cache the community on beta, make sure it has the other fields
|
|
let searchShort = `!${prevName}@lemmy-alpha:8541`;
|
|
let betaCommunity = (await resolveCommunity(beta, searchShort)).community;
|
|
assertCommunityFederation(betaCommunity, communityRes.community_view);
|
|
});
|
|
|
|
test("Delete community", async () => {
|
|
let communityRes = await createCommunity(beta);
|
|
|
|
// Cache the community on Alpha
|
|
let searchShort = `!${communityRes.community_view.community.name}@lemmy-beta:8551`;
|
|
let alphaCommunity = (await resolveCommunity(alpha, searchShort)).community;
|
|
if (!alphaCommunity) {
|
|
throw "Missing alpha community";
|
|
}
|
|
assertCommunityFederation(alphaCommunity, communityRes.community_view);
|
|
|
|
// Follow the community from alpha
|
|
let follow = await followCommunity(alpha, true, alphaCommunity.community.id);
|
|
|
|
// Make sure the follow response went through
|
|
expect(follow.community_view.community.local).toBe(false);
|
|
|
|
let deleteCommunityRes = await deleteCommunity(
|
|
beta,
|
|
true,
|
|
communityRes.community_view.community.id,
|
|
);
|
|
expect(deleteCommunityRes.community_view.community.deleted).toBe(true);
|
|
expect(deleteCommunityRes.community_view.community.title).toBe(
|
|
communityRes.community_view.community.title,
|
|
);
|
|
|
|
// Make sure it got deleted on A
|
|
let communityOnAlphaDeleted = await waitUntil(
|
|
() => getCommunity(alpha, alphaCommunity!.community.id),
|
|
g => g.community_view.community.deleted,
|
|
);
|
|
expect(communityOnAlphaDeleted.community_view.community.deleted).toBe(true);
|
|
|
|
// Undelete
|
|
let undeleteCommunityRes = await deleteCommunity(
|
|
beta,
|
|
false,
|
|
communityRes.community_view.community.id,
|
|
);
|
|
expect(undeleteCommunityRes.community_view.community.deleted).toBe(false);
|
|
|
|
// Make sure it got undeleted on A
|
|
let communityOnAlphaUnDeleted = await waitUntil(
|
|
() => getCommunity(alpha, alphaCommunity!.community.id),
|
|
g => !g.community_view.community.deleted,
|
|
);
|
|
expect(communityOnAlphaUnDeleted.community_view.community.deleted).toBe(
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("Remove community", async () => {
|
|
let communityRes = await createCommunity(beta);
|
|
|
|
// Cache the community on Alpha
|
|
let searchShort = `!${communityRes.community_view.community.name}@lemmy-beta:8551`;
|
|
let alphaCommunity = (await resolveCommunity(alpha, searchShort)).community;
|
|
if (!alphaCommunity) {
|
|
throw "Missing alpha community";
|
|
}
|
|
assertCommunityFederation(alphaCommunity, communityRes.community_view);
|
|
|
|
// Follow the community from alpha
|
|
let follow = await followCommunity(alpha, true, alphaCommunity.community.id);
|
|
|
|
// Make sure the follow response went through
|
|
expect(follow.community_view.community.local).toBe(false);
|
|
|
|
let removeCommunityRes = await removeCommunity(
|
|
beta,
|
|
true,
|
|
communityRes.community_view.community.id,
|
|
);
|
|
expect(removeCommunityRes.community_view.community.removed).toBe(true);
|
|
expect(removeCommunityRes.community_view.community.title).toBe(
|
|
communityRes.community_view.community.title,
|
|
);
|
|
|
|
// Make sure it got Removed on A
|
|
let communityOnAlphaRemoved = await waitUntil(
|
|
() => getCommunity(alpha, alphaCommunity!.community.id),
|
|
g => g.community_view.community.removed,
|
|
);
|
|
expect(communityOnAlphaRemoved.community_view.community.removed).toBe(true);
|
|
|
|
// unremove
|
|
let unremoveCommunityRes = await removeCommunity(
|
|
beta,
|
|
false,
|
|
communityRes.community_view.community.id,
|
|
);
|
|
expect(unremoveCommunityRes.community_view.community.removed).toBe(false);
|
|
|
|
// Make sure it got undeleted on A
|
|
let communityOnAlphaUnRemoved = await waitUntil(
|
|
() => getCommunity(alpha, alphaCommunity!.community.id),
|
|
g => !g.community_view.community.removed,
|
|
);
|
|
expect(communityOnAlphaUnRemoved.community_view.community.removed).toBe(
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("Search for beta community", async () => {
|
|
let communityRes = await createCommunity(beta);
|
|
expect(communityRes.community_view.community.name).toBeDefined();
|
|
|
|
let searchShort = `!${communityRes.community_view.community.name}@lemmy-beta:8551`;
|
|
let alphaCommunity = (await resolveCommunity(alpha, searchShort)).community;
|
|
assertCommunityFederation(alphaCommunity, communityRes.community_view);
|
|
});
|
|
|
|
test("Admin actions in remote community are not federated to origin", async () => {
|
|
// create a community on alpha
|
|
let communityRes = (await createCommunity(alpha)).community_view;
|
|
expect(communityRes.community.name).toBeDefined();
|
|
|
|
// gamma follows community and posts in it
|
|
let gammaCommunity = (
|
|
await resolveCommunity(gamma, communityRes.community.actor_id)
|
|
).community;
|
|
if (!gammaCommunity) {
|
|
throw "Missing gamma community";
|
|
}
|
|
await followCommunity(gamma, true, gammaCommunity.community.id);
|
|
gammaCommunity = (
|
|
await waitUntil(
|
|
() => resolveCommunity(gamma, communityRes.community.actor_id),
|
|
g => g.community?.subscribed === "Subscribed",
|
|
)
|
|
).community;
|
|
if (!gammaCommunity) {
|
|
throw "Missing gamma community";
|
|
}
|
|
expect(gammaCommunity.subscribed).toBe("Subscribed");
|
|
let gammaPost = (await createPost(gamma, gammaCommunity.community.id))
|
|
.post_view;
|
|
expect(gammaPost.post.id).toBeDefined();
|
|
expect(gammaPost.creator_banned_from_community).toBe(false);
|
|
|
|
// admin of beta decides to ban gamma from community
|
|
let betaCommunity = (
|
|
await resolveCommunity(beta, communityRes.community.actor_id)
|
|
).community;
|
|
if (!betaCommunity) {
|
|
throw "Missing beta community";
|
|
}
|
|
let bannedUserInfo1 = (await getSite(gamma)).my_user?.local_user_view.person;
|
|
if (!bannedUserInfo1) {
|
|
throw "Missing banned user 1";
|
|
}
|
|
let bannedUserInfo2 = (await resolvePerson(beta, bannedUserInfo1.actor_id))
|
|
.person;
|
|
if (!bannedUserInfo2) {
|
|
throw "Missing banned user 2";
|
|
}
|
|
let banRes = await banPersonFromCommunity(
|
|
beta,
|
|
bannedUserInfo2.person.id,
|
|
betaCommunity.community.id,
|
|
true,
|
|
true,
|
|
);
|
|
expect(banRes.banned).toBe(true);
|
|
|
|
// ban doesn't federate to community's origin instance alpha
|
|
let alphaPost = (await resolvePost(alpha, gammaPost.post)).post;
|
|
expect(alphaPost?.creator_banned_from_community).toBe(false);
|
|
|
|
// and neither to gamma
|
|
let gammaPost2 = await getPost(gamma, gammaPost.post.id);
|
|
expect(gammaPost2.post_view.creator_banned_from_community).toBe(false);
|
|
});
|
|
|
|
test("moderator view", async () => {
|
|
// register a new user with their own community on alpha and post to it
|
|
let otherUser = await registerUser(alpha, alphaUrl);
|
|
|
|
let otherCommunity = (await createCommunity(otherUser)).community_view;
|
|
expect(otherCommunity.community.name).toBeDefined();
|
|
let otherPost = (await createPost(otherUser, otherCommunity.community.id))
|
|
.post_view;
|
|
expect(otherPost.post.id).toBeDefined();
|
|
|
|
let otherComment = (await createComment(otherUser, otherPost.post.id))
|
|
.comment_view;
|
|
expect(otherComment.comment.id).toBeDefined();
|
|
|
|
// create a community and post on alpha
|
|
let alphaCommunity = (await createCommunity(alpha)).community_view;
|
|
expect(alphaCommunity.community.name).toBeDefined();
|
|
let alphaPost = (await createPost(alpha, alphaCommunity.community.id))
|
|
.post_view;
|
|
expect(alphaPost.post.id).toBeDefined();
|
|
|
|
let alphaComment = (await createComment(otherUser, alphaPost.post.id))
|
|
.comment_view;
|
|
expect(alphaComment.comment.id).toBeDefined();
|
|
|
|
// other user also posts on alpha's community
|
|
let otherAlphaPost = (
|
|
await createPost(otherUser, alphaCommunity.community.id)
|
|
).post_view;
|
|
expect(otherAlphaPost.post.id).toBeDefined();
|
|
|
|
let otherAlphaComment = (
|
|
await createComment(otherUser, otherAlphaPost.post.id)
|
|
).comment_view;
|
|
expect(otherAlphaComment.comment.id).toBeDefined();
|
|
|
|
// alpha lists posts and comments on home page, should contain all posts that were made
|
|
let posts = (await getPosts(alpha, "All")).posts;
|
|
expect(posts).toBeDefined();
|
|
let postIds = posts.map(post => post.post.id);
|
|
|
|
let comments = (await getComments(alpha, undefined, "All")).comments;
|
|
expect(comments).toBeDefined();
|
|
let commentIds = comments.map(comment => comment.comment.id);
|
|
|
|
expect(postIds).toContain(otherPost.post.id);
|
|
expect(commentIds).toContain(otherComment.comment.id);
|
|
|
|
expect(postIds).toContain(alphaPost.post.id);
|
|
expect(commentIds).toContain(alphaComment.comment.id);
|
|
|
|
expect(postIds).toContain(otherAlphaPost.post.id);
|
|
expect(commentIds).toContain(otherAlphaComment.comment.id);
|
|
|
|
// in moderator view, alpha should not see otherPost, wich was posted on a community alpha doesn't moderate
|
|
posts = (await getPosts(alpha, "ModeratorView")).posts;
|
|
expect(posts).toBeDefined();
|
|
postIds = posts.map(post => post.post.id);
|
|
|
|
comments = (await getComments(alpha, undefined, "ModeratorView")).comments;
|
|
expect(comments).toBeDefined();
|
|
commentIds = comments.map(comment => comment.comment.id);
|
|
|
|
expect(postIds).not.toContain(otherPost.post.id);
|
|
expect(commentIds).not.toContain(otherComment.comment.id);
|
|
|
|
expect(postIds).toContain(alphaPost.post.id);
|
|
expect(commentIds).toContain(alphaComment.comment.id);
|
|
|
|
expect(postIds).toContain(otherAlphaPost.post.id);
|
|
expect(commentIds).toContain(otherAlphaComment.comment.id);
|
|
});
|
|
|
|
test("Get community for different casing on domain", async () => {
|
|
let communityRes = await createCommunity(alpha);
|
|
expect(communityRes.community_view.community.name).toBeDefined();
|
|
|
|
// A dupe check
|
|
let prevName = communityRes.community_view.community.name;
|
|
await expect(createCommunity(alpha, prevName)).rejects.toStrictEqual(
|
|
Error("community_already_exists"),
|
|
);
|
|
|
|
// Cache the community on beta, make sure it has the other fields
|
|
let communityName = `${communityRes.community_view.community.name}@LEMMY-ALPHA:8541`;
|
|
let betaCommunity = (await getCommunityByName(beta, communityName))
|
|
.community_view;
|
|
assertCommunityFederation(betaCommunity, communityRes.community_view);
|
|
});
|
|
|
|
test("User blocks instance, communities are hidden", async () => {
|
|
// create community and post on beta
|
|
let communityRes = await createCommunity(beta);
|
|
expect(communityRes.community_view.community.name).toBeDefined();
|
|
let postRes = await createPost(
|
|
beta,
|
|
communityRes.community_view.community.id,
|
|
);
|
|
expect(postRes.post_view.post.id).toBeDefined();
|
|
|
|
// fetch post to alpha
|
|
let alphaPost = (await resolvePost(alpha, postRes.post_view.post)).post!;
|
|
expect(alphaPost.post).toBeDefined();
|
|
|
|
// post should be included in listing
|
|
let listing = await getPosts(alpha, "All");
|
|
let listing_ids = listing.posts.map(p => p.post.ap_id);
|
|
expect(listing_ids).toContain(postRes.post_view.post.ap_id);
|
|
|
|
// block the beta instance
|
|
await blockInstance(alpha, alphaPost.community.instance_id, true);
|
|
|
|
// after blocking, post should not be in listing
|
|
let listing2 = await getPosts(alpha, "All");
|
|
let listing_ids2 = listing2.posts.map(p => p.post.ap_id);
|
|
expect(listing_ids2.indexOf(postRes.post_view.post.ap_id)).toBe(-1);
|
|
|
|
// unblock instance again
|
|
await blockInstance(alpha, alphaPost.community.instance_id, false);
|
|
|
|
// post should be included in listing
|
|
let listing3 = await getPosts(alpha, "All");
|
|
let listing_ids3 = listing3.posts.map(p => p.post.ap_id);
|
|
expect(listing_ids3).toContain(postRes.post_view.post.ap_id);
|
|
});
|
|
|
|
test("Community follower count is federated", async () => {
|
|
// Follow the beta community from alpha
|
|
let community = await createCommunity(beta);
|
|
let communityActorId = community.community_view.community.actor_id;
|
|
let resolved = await resolveCommunity(alpha, communityActorId);
|
|
if (!resolved.community) {
|
|
throw "Missing beta community";
|
|
}
|
|
|
|
await followCommunity(alpha, true, resolved.community.community.id);
|
|
let followed = (
|
|
await waitUntil(
|
|
() => resolveCommunity(alpha, communityActorId),
|
|
c => c.community?.subscribed === "Subscribed",
|
|
)
|
|
).community;
|
|
|
|
// Make sure there is 1 subscriber
|
|
expect(followed?.counts.subscribers).toBe(1);
|
|
|
|
// Follow the community from gamma
|
|
resolved = await resolveCommunity(gamma, communityActorId);
|
|
if (!resolved.community) {
|
|
throw "Missing beta community";
|
|
}
|
|
|
|
await followCommunity(gamma, true, resolved.community.community.id);
|
|
followed = (
|
|
await waitUntil(
|
|
() => resolveCommunity(gamma, communityActorId),
|
|
c => c.community?.subscribed === "Subscribed",
|
|
)
|
|
).community;
|
|
|
|
// Make sure there are 2 subscribers
|
|
expect(followed?.counts?.subscribers).toBe(2);
|
|
|
|
// Follow the community from delta
|
|
resolved = await resolveCommunity(delta, communityActorId);
|
|
if (!resolved.community) {
|
|
throw "Missing beta community";
|
|
}
|
|
|
|
await followCommunity(delta, true, resolved.community.community.id);
|
|
followed = (
|
|
await waitUntil(
|
|
() => resolveCommunity(delta, communityActorId),
|
|
c => c.community?.subscribed === "Subscribed",
|
|
)
|
|
).community;
|
|
|
|
// Make sure there are 3 subscribers
|
|
expect(followed?.counts?.subscribers).toBe(3);
|
|
});
|
|
|
|
test("Dont receive community activities after unsubscribe", async () => {
|
|
let communityRes = await createCommunity(alpha);
|
|
expect(communityRes.community_view.community.name).toBeDefined();
|
|
expect(communityRes.community_view.counts.subscribers).toBe(1);
|
|
|
|
let betaCommunity = (
|
|
await resolveCommunity(beta, communityRes.community_view.community.actor_id)
|
|
).community;
|
|
assertCommunityFederation(betaCommunity, communityRes.community_view);
|
|
|
|
// follow alpha community from beta
|
|
await followCommunity(beta, true, betaCommunity!.community.id);
|
|
|
|
// ensure that follower count was updated
|
|
let communityRes1 = await getCommunity(
|
|
alpha,
|
|
communityRes.community_view.community.id,
|
|
);
|
|
expect(communityRes1.community_view.counts.subscribers).toBe(2);
|
|
|
|
// temporarily block alpha, so that it doesn't know about unfollow
|
|
let editSiteForm: EditSite = {};
|
|
editSiteForm.allowed_instances = ["lemmy-epsilon"];
|
|
await beta.editSite(editSiteForm);
|
|
await longDelay();
|
|
|
|
// unfollow
|
|
await followCommunity(beta, false, betaCommunity!.community.id);
|
|
|
|
// ensure that alpha still sees beta as follower
|
|
let communityRes2 = await getCommunity(
|
|
alpha,
|
|
communityRes.community_view.community.id,
|
|
);
|
|
expect(communityRes2.community_view.counts.subscribers).toBe(2);
|
|
|
|
// unblock alpha
|
|
editSiteForm.allowed_instances = betaAllowedInstances;
|
|
await beta.editSite(editSiteForm);
|
|
await longDelay();
|
|
|
|
// create a post, it shouldnt reach beta
|
|
let postRes = await createPost(
|
|
alpha,
|
|
communityRes.community_view.community.id,
|
|
);
|
|
expect(postRes.post_view.post.id).toBeDefined();
|
|
// await longDelay();
|
|
|
|
let postResBeta = searchPostLocal(beta, postRes.post_view.post);
|
|
expect((await postResBeta).posts.length).toBe(0);
|
|
});
|
|
|
|
test("Fetch community, includes posts", async () => {
|
|
let communityRes = await createCommunity(alpha);
|
|
expect(communityRes.community_view.community.name).toBeDefined();
|
|
expect(communityRes.community_view.counts.subscribers).toBe(1);
|
|
|
|
let postRes = await createPost(
|
|
alpha,
|
|
communityRes.community_view.community.id,
|
|
);
|
|
expect(postRes.post_view.post).toBeDefined();
|
|
|
|
let resolvedCommunity = await waitUntil(
|
|
() =>
|
|
resolveCommunity(beta, communityRes.community_view.community.actor_id),
|
|
c => c.community?.community.id != undefined,
|
|
);
|
|
let betaCommunity = resolvedCommunity.community;
|
|
expect(betaCommunity?.community.actor_id).toBe(
|
|
communityRes.community_view.community.actor_id,
|
|
);
|
|
|
|
await longDelay();
|
|
|
|
let post_listing = await getPosts(beta, "All", betaCommunity?.community.id);
|
|
expect(post_listing.posts.length).toBe(1);
|
|
expect(post_listing.posts[0].post.ap_id).toBe(postRes.post_view.post.ap_id);
|
|
});
|
|
|
|
test("Content in local-only community doesn't federate", async () => {
|
|
// create a community and set it local-only
|
|
let communityRes = (await createCommunity(alpha)).community_view.community;
|
|
let form: EditCommunity = {
|
|
community_id: communityRes.id,
|
|
visibility: "LocalOnly",
|
|
};
|
|
await editCommunity(alpha, form);
|
|
|
|
// cant resolve the community from another instance
|
|
await expect(
|
|
resolveCommunity(beta, communityRes.actor_id),
|
|
).rejects.toStrictEqual(Error("couldnt_find_object"));
|
|
|
|
// create a post, also cant resolve it
|
|
let postRes = await createPost(alpha, communityRes.id);
|
|
await expect(resolvePost(beta, postRes.post_view.post)).rejects.toStrictEqual(
|
|
Error("couldnt_find_object"),
|
|
);
|
|
});
|