mirror of
https://github.com/LemmyNet/lemmy.git
synced 2025-01-09 03:31:53 +00:00
Nutomic
66a63df152
* Instance blocks with mod log entry and expiration (fixes #2506) * separate table for instance block mod log * fix tests * fix ts * modlog entry for allow instance * fix test cleanup * add back test * clippy * fix check * more changes * move files * update * sql fmt * partly working * fix setup * cleanup * fixes * prettier * try catch * address comments
458 lines
15 KiB
Rust
458 lines
15 KiB
Rust
use super::not_zero;
|
|
use crate::site::{application_question_check, site_default_post_listing_type_check};
|
|
use activitypub_federation::config::Data;
|
|
use actix_web::web::Json;
|
|
use chrono::Utc;
|
|
use lemmy_api_common::{
|
|
context::LemmyContext,
|
|
request::replace_image,
|
|
site::{EditSite, SiteResponse},
|
|
utils::{
|
|
get_url_blocklist,
|
|
is_admin,
|
|
local_site_rate_limit_to_rate_limit_config,
|
|
local_site_to_slur_regex,
|
|
process_markdown_opt,
|
|
proxy_image_link_opt_api,
|
|
},
|
|
};
|
|
use lemmy_db_schema::{
|
|
source::{
|
|
actor_language::SiteLanguage,
|
|
local_site::{LocalSite, LocalSiteUpdateForm},
|
|
local_site_rate_limit::{LocalSiteRateLimit, LocalSiteRateLimitUpdateForm},
|
|
local_site_url_blocklist::LocalSiteUrlBlocklist,
|
|
local_user::LocalUser,
|
|
site::{Site, SiteUpdateForm},
|
|
},
|
|
traits::Crud,
|
|
utils::{diesel_string_update, diesel_url_update},
|
|
RegistrationMode,
|
|
};
|
|
use lemmy_db_views::structs::{LocalUserView, SiteView};
|
|
use lemmy_utils::{
|
|
error::{LemmyErrorExt, LemmyErrorType, LemmyResult},
|
|
utils::{
|
|
slurs::check_slurs_opt,
|
|
validation::{
|
|
build_and_check_regex,
|
|
check_site_visibility_valid,
|
|
check_urls_are_valid,
|
|
is_valid_body_field,
|
|
site_name_length_check,
|
|
site_or_community_description_length_check,
|
|
},
|
|
},
|
|
};
|
|
|
|
#[tracing::instrument(skip(context))]
|
|
pub async fn update_site(
|
|
data: Json<EditSite>,
|
|
context: Data<LemmyContext>,
|
|
local_user_view: LocalUserView,
|
|
) -> LemmyResult<Json<SiteResponse>> {
|
|
let site_view = SiteView::read_local(&mut context.pool()).await?;
|
|
let local_site = site_view.local_site;
|
|
let site = site_view.site;
|
|
|
|
// Make sure user is an admin; other types of users should not update site data...
|
|
is_admin(&local_user_view)?;
|
|
|
|
validate_update_payload(&local_site, &data)?;
|
|
|
|
if let Some(discussion_languages) = data.discussion_languages.clone() {
|
|
SiteLanguage::update(&mut context.pool(), discussion_languages.clone(), &site).await?;
|
|
}
|
|
|
|
let slur_regex = local_site_to_slur_regex(&local_site);
|
|
let url_blocklist = get_url_blocklist(&context).await?;
|
|
let sidebar = diesel_string_update(
|
|
process_markdown_opt(&data.sidebar, &slur_regex, &url_blocklist, &context)
|
|
.await?
|
|
.as_deref(),
|
|
);
|
|
|
|
let icon = diesel_url_update(data.icon.as_deref())?;
|
|
replace_image(&icon, &site.icon, &context).await?;
|
|
let icon = proxy_image_link_opt_api(icon, &context).await?;
|
|
|
|
let banner = diesel_url_update(data.banner.as_deref())?;
|
|
replace_image(&banner, &site.banner, &context).await?;
|
|
let banner = proxy_image_link_opt_api(banner, &context).await?;
|
|
|
|
let site_form = SiteUpdateForm {
|
|
name: data.name.clone(),
|
|
sidebar,
|
|
description: diesel_string_update(data.description.as_deref()),
|
|
icon,
|
|
banner,
|
|
content_warning: diesel_string_update(data.content_warning.as_deref()),
|
|
updated: Some(Some(Utc::now())),
|
|
..Default::default()
|
|
};
|
|
|
|
Site::update(&mut context.pool(), site.id, &site_form)
|
|
.await
|
|
// Ignore errors for all these, so as to not throw errors if no update occurs
|
|
// Diesel will throw an error for empty update forms
|
|
.ok();
|
|
|
|
let local_site_form = LocalSiteUpdateForm {
|
|
registration_mode: data.registration_mode,
|
|
community_creation_admin_only: data.community_creation_admin_only,
|
|
require_email_verification: data.require_email_verification,
|
|
application_question: diesel_string_update(data.application_question.as_deref()),
|
|
private_instance: data.private_instance,
|
|
default_theme: data.default_theme.clone(),
|
|
default_post_listing_type: data.default_post_listing_type,
|
|
default_post_sort_type: data.default_post_sort_type,
|
|
default_comment_sort_type: data.default_comment_sort_type,
|
|
legal_information: diesel_string_update(data.legal_information.as_deref()),
|
|
application_email_admins: data.application_email_admins,
|
|
hide_modlog_mod_names: data.hide_modlog_mod_names,
|
|
updated: Some(Some(Utc::now())),
|
|
slur_filter_regex: diesel_string_update(data.slur_filter_regex.as_deref()),
|
|
actor_name_max_length: data.actor_name_max_length,
|
|
federation_enabled: data.federation_enabled,
|
|
captcha_enabled: data.captcha_enabled,
|
|
captcha_difficulty: data.captcha_difficulty.clone(),
|
|
reports_email_admins: data.reports_email_admins,
|
|
default_post_listing_mode: data.default_post_listing_mode,
|
|
oauth_registration: data.oauth_registration,
|
|
post_upvotes: data.post_upvotes,
|
|
post_downvotes: data.post_downvotes,
|
|
comment_upvotes: data.comment_upvotes,
|
|
comment_downvotes: data.comment_downvotes,
|
|
..Default::default()
|
|
};
|
|
|
|
let update_local_site = LocalSite::update(&mut context.pool(), &local_site_form)
|
|
.await
|
|
.ok();
|
|
|
|
let local_site_rate_limit_form = LocalSiteRateLimitUpdateForm {
|
|
message: data.rate_limit_message,
|
|
message_per_second: not_zero(data.rate_limit_message_per_second),
|
|
post: data.rate_limit_post,
|
|
post_per_second: not_zero(data.rate_limit_post_per_second),
|
|
register: data.rate_limit_register,
|
|
register_per_second: not_zero(data.rate_limit_register_per_second),
|
|
image: data.rate_limit_image,
|
|
image_per_second: not_zero(data.rate_limit_image_per_second),
|
|
comment: data.rate_limit_comment,
|
|
comment_per_second: not_zero(data.rate_limit_comment_per_second),
|
|
search: data.rate_limit_search,
|
|
search_per_second: not_zero(data.rate_limit_search_per_second),
|
|
..Default::default()
|
|
};
|
|
|
|
LocalSiteRateLimit::update(&mut context.pool(), &local_site_rate_limit_form)
|
|
.await
|
|
.ok();
|
|
|
|
if let Some(url_blocklist) = data.blocked_urls.clone() {
|
|
let parsed_urls = check_urls_are_valid(&url_blocklist)?;
|
|
LocalSiteUrlBlocklist::replace(&mut context.pool(), parsed_urls).await?;
|
|
}
|
|
|
|
// TODO can't think of a better way to do this.
|
|
// If the server suddenly requires email verification, or required applications, no old users
|
|
// will be able to log in. It really only wants this to be a requirement for NEW signups.
|
|
// So if it was set from false, to true, you need to update all current users columns to be
|
|
// verified.
|
|
|
|
let old_require_application =
|
|
local_site.registration_mode == RegistrationMode::RequireApplication;
|
|
let new_require_application = update_local_site
|
|
.as_ref()
|
|
.map(|ols| ols.registration_mode == RegistrationMode::RequireApplication)
|
|
.unwrap_or(false);
|
|
if !old_require_application && new_require_application {
|
|
LocalUser::set_all_users_registration_applications_accepted(&mut context.pool())
|
|
.await
|
|
.with_lemmy_type(LemmyErrorType::CouldntSetAllRegistrationsAccepted)?;
|
|
}
|
|
|
|
let new_require_email_verification = update_local_site
|
|
.as_ref()
|
|
.map(|ols| ols.require_email_verification)
|
|
.unwrap_or(false);
|
|
if !local_site.require_email_verification && new_require_email_verification {
|
|
LocalUser::set_all_users_email_verified(&mut context.pool())
|
|
.await
|
|
.with_lemmy_type(LemmyErrorType::CouldntSetAllEmailVerified)?;
|
|
}
|
|
|
|
let site_view = SiteView::read_local(&mut context.pool()).await?;
|
|
|
|
let rate_limit_config =
|
|
local_site_rate_limit_to_rate_limit_config(&site_view.local_site_rate_limit);
|
|
context.rate_limit_cell().set_config(rate_limit_config);
|
|
|
|
Ok(Json(SiteResponse {
|
|
site_view,
|
|
taglines: vec![],
|
|
}))
|
|
}
|
|
|
|
fn validate_update_payload(local_site: &LocalSite, edit_site: &EditSite) -> LemmyResult<()> {
|
|
// Check that the slur regex compiles, and return the regex if valid...
|
|
// Prioritize using new slur regex from the request; if not provided, use the existing regex.
|
|
let slur_regex = build_and_check_regex(
|
|
&edit_site
|
|
.slur_filter_regex
|
|
.as_deref()
|
|
.or(local_site.slur_filter_regex.as_deref()),
|
|
);
|
|
|
|
if let Some(name) = &edit_site.name {
|
|
// The name doesn't need to be updated, but if provided it cannot be blanked out...
|
|
site_name_length_check(name)?;
|
|
check_slurs_opt(&edit_site.name, &slur_regex)?;
|
|
}
|
|
|
|
if let Some(desc) = &edit_site.description {
|
|
site_or_community_description_length_check(desc)?;
|
|
check_slurs_opt(&edit_site.description, &slur_regex)?;
|
|
}
|
|
|
|
site_default_post_listing_type_check(&edit_site.default_post_listing_type)?;
|
|
|
|
check_site_visibility_valid(
|
|
local_site.private_instance,
|
|
local_site.federation_enabled,
|
|
&edit_site.private_instance,
|
|
&edit_site.federation_enabled,
|
|
)?;
|
|
|
|
// Ensure that the sidebar has fewer than the max num characters...
|
|
if let Some(body) = &edit_site.sidebar {
|
|
is_valid_body_field(body, false)?;
|
|
}
|
|
|
|
application_question_check(
|
|
&local_site.application_question,
|
|
&edit_site.application_question,
|
|
edit_site
|
|
.registration_mode
|
|
.unwrap_or(local_site.registration_mode),
|
|
)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
|
|
use crate::site::update::validate_update_payload;
|
|
use lemmy_api_common::site::EditSite;
|
|
use lemmy_db_schema::{
|
|
source::local_site::LocalSite,
|
|
ListingType,
|
|
PostSortType,
|
|
RegistrationMode,
|
|
};
|
|
use lemmy_utils::error::LemmyErrorType;
|
|
|
|
#[test]
|
|
fn test_validate_invalid_update_payload() {
|
|
let invalid_payloads = [
|
|
(
|
|
"EditSite name matches LocalSite slur filter",
|
|
LemmyErrorType::Slurs,
|
|
&LocalSite {
|
|
private_instance: true,
|
|
slur_filter_regex: Some(String::from("(foo|bar)")),
|
|
federation_enabled: false,
|
|
registration_mode: RegistrationMode::Open,
|
|
..Default::default()
|
|
},
|
|
&EditSite {
|
|
name: Some(String::from("foo site_name")),
|
|
..Default::default()
|
|
},
|
|
),
|
|
(
|
|
"EditSite name matches new slur filter",
|
|
LemmyErrorType::Slurs,
|
|
&LocalSite {
|
|
private_instance: true,
|
|
slur_filter_regex: Some(String::from("(foo|bar)")),
|
|
federation_enabled: false,
|
|
registration_mode: RegistrationMode::Open,
|
|
..Default::default()
|
|
},
|
|
&EditSite {
|
|
name: Some(String::from("zeta site_name")),
|
|
slur_filter_regex: Some(String::from("(zeta|alpha)")),
|
|
..Default::default()
|
|
},
|
|
),
|
|
(
|
|
"EditSite listing type is Subscribed, which is invalid",
|
|
LemmyErrorType::InvalidDefaultPostListingType,
|
|
&LocalSite {
|
|
private_instance: true,
|
|
federation_enabled: false,
|
|
registration_mode: RegistrationMode::Open,
|
|
..Default::default()
|
|
},
|
|
&EditSite {
|
|
name: Some(String::from("site_name")),
|
|
default_post_listing_type: Some(ListingType::Subscribed),
|
|
..Default::default()
|
|
},
|
|
),
|
|
(
|
|
"EditSite is both private and federated",
|
|
LemmyErrorType::CantEnablePrivateInstanceAndFederationTogether,
|
|
&LocalSite {
|
|
private_instance: true,
|
|
federation_enabled: false,
|
|
registration_mode: RegistrationMode::Open,
|
|
..Default::default()
|
|
},
|
|
&EditSite {
|
|
name: Some(String::from("site_name")),
|
|
private_instance: Some(true),
|
|
federation_enabled: Some(true),
|
|
..Default::default()
|
|
},
|
|
),
|
|
(
|
|
"LocalSite is private, but EditSite also makes it federated",
|
|
LemmyErrorType::CantEnablePrivateInstanceAndFederationTogether,
|
|
&LocalSite {
|
|
private_instance: true,
|
|
federation_enabled: false,
|
|
registration_mode: RegistrationMode::Open,
|
|
..Default::default()
|
|
},
|
|
&EditSite {
|
|
name: Some(String::from("site_name")),
|
|
federation_enabled: Some(true),
|
|
..Default::default()
|
|
},
|
|
),
|
|
(
|
|
"EditSite requires application, but neither it nor LocalSite has an application question",
|
|
LemmyErrorType::ApplicationQuestionRequired,
|
|
&LocalSite {
|
|
private_instance: true,
|
|
federation_enabled: false,
|
|
registration_mode: RegistrationMode::Open,
|
|
..Default::default()
|
|
},
|
|
&EditSite {
|
|
name: Some(String::from("site_name")),
|
|
registration_mode: Some(RegistrationMode::RequireApplication),
|
|
..Default::default()
|
|
},
|
|
),
|
|
];
|
|
|
|
invalid_payloads.iter().enumerate().for_each(
|
|
|(
|
|
idx,
|
|
&(reason, ref expected_err, local_site, edit_site),
|
|
)| {
|
|
match validate_update_payload(local_site, edit_site) {
|
|
Ok(_) => {
|
|
panic!(
|
|
"Got Ok, but validation should have failed with error: {} for reason: {}. invalid_payloads.nth({})",
|
|
expected_err, reason, idx
|
|
)
|
|
}
|
|
Err(error) => {
|
|
assert!(
|
|
error.error_type.eq(&expected_err.clone()),
|
|
"Got Err {:?}, but should have failed with message: {} for reason: {}. invalid_payloads.nth({})",
|
|
error.error_type,
|
|
expected_err,
|
|
reason,
|
|
idx
|
|
)
|
|
}
|
|
}
|
|
},
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn test_validate_valid_update_payload() {
|
|
let valid_payloads = [
|
|
(
|
|
"No changes between LocalSite and EditSite",
|
|
&LocalSite {
|
|
private_instance: true,
|
|
federation_enabled: false,
|
|
registration_mode: RegistrationMode::Open,
|
|
..Default::default()
|
|
},
|
|
&EditSite::default(),
|
|
),
|
|
(
|
|
"EditSite allows clearing and changing values",
|
|
&LocalSite {
|
|
private_instance: true,
|
|
federation_enabled: false,
|
|
registration_mode: RegistrationMode::Open,
|
|
..Default::default()
|
|
},
|
|
&EditSite {
|
|
name: Some(String::from("site_name")),
|
|
sidebar: Some(String::new()),
|
|
description: Some(String::new()),
|
|
application_question: Some(String::new()),
|
|
private_instance: Some(false),
|
|
default_post_listing_type: Some(ListingType::All),
|
|
default_post_sort_type: Some(PostSortType::Active),
|
|
slur_filter_regex: Some(String::new()),
|
|
registration_mode: Some(RegistrationMode::Open),
|
|
federation_enabled: Some(true),
|
|
..Default::default()
|
|
},
|
|
),
|
|
(
|
|
"EditSite name passes slur filter regex",
|
|
&LocalSite {
|
|
private_instance: true,
|
|
slur_filter_regex: Some(String::from("(foo|bar)")),
|
|
registration_mode: RegistrationMode::Open,
|
|
federation_enabled: false,
|
|
..Default::default()
|
|
},
|
|
&EditSite {
|
|
name: Some(String::from("foo site_name")),
|
|
slur_filter_regex: Some(String::new()),
|
|
..Default::default()
|
|
},
|
|
),
|
|
(
|
|
"LocalSite has application question and EditSite now requires applications,",
|
|
&LocalSite {
|
|
application_question: Some(String::from("question")),
|
|
private_instance: true,
|
|
federation_enabled: false,
|
|
registration_mode: RegistrationMode::Open,
|
|
..Default::default()
|
|
},
|
|
&EditSite {
|
|
name: Some(String::from("site_name")),
|
|
registration_mode: Some(RegistrationMode::RequireApplication),
|
|
..Default::default()
|
|
},
|
|
),
|
|
];
|
|
|
|
valid_payloads
|
|
.iter()
|
|
.enumerate()
|
|
.for_each(|(idx, &(reason, local_site, edit_site))| {
|
|
assert!(
|
|
validate_update_payload(local_site, edit_site).is_ok(),
|
|
"Got Err, but should have got Ok for reason: {}. valid_payloads.nth({})",
|
|
reason,
|
|
idx
|
|
);
|
|
})
|
|
}
|
|
}
|