LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Remove dead code #81

Merged
dessalines merged 7 commits from remove-dead-code into main 2020-08-12 12:30:54 +00:00
Conversation 2 Commits 7 Files Changed 20 +11 -8
4 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit afdbed30e5 - Show all commits

5
server/lemmy_db/src/comment.rs
View File

@ -55,8 +55,9 @@ impl Crud<CommentForm> for Comment {
comment.find(comment_id).first::<Self>(conn) comment.find(comment_id).first::<Self>(conn)
} }
fn delete(_conn: &PgConnection, _comment_id: i32) -> Result<usize, Error> { fn delete(conn: &PgConnection, comment_id: i32) -> Result<usize, Error> {
unimplemented!() use crate::schema::comment::dsl::*;
diesel::delete(comment.find(comment_id)).execute(conn)
} }
dessalines marked this conversation as resolved
dessalines commented 2020-08-11 14:38:26 +00:00
Review
Copy Link

Comment, post, user and community deletes shouldn't be removed, bc we will use them once we implement purge. (I think one of the chapo team was maybe working on it)

Comment, post, user and community deletes shouldn't be removed, bc we will use them once we implement purge. (I think one of the chapo team was maybe working on it)
nutomic commented 2020-08-11 17:51:49 +00:00
Review
Copy Link

Okay, restored them.

Okay, restored them.
fn create(conn: &PgConnection, comment_form: &CommentForm) -> Result<Self, Error> { fn create(conn: &PgConnection, comment_form: &CommentForm) -> Result<Self, Error> {

5
server/lemmy_db/src/community.rs
View File

@ -60,8 +60,9 @@ impl Crud<CommunityForm> for Community {
community.find(community_id).first::<Self>(conn) community.find(community_id).first::<Self>(conn)
} }
fn delete(_conn: &PgConnection, _community_id: i32) -> Result<usize, Error> { fn delete(conn: &PgConnection, community_id: i32) -> Result<usize, Error> {
unimplemented!() use crate::schema::community::dsl::*;
diesel::delete(community.find(community_id)).execute(conn)
} }
fn create(conn: &PgConnection, new_community: &CommunityForm) -> Result<Self, Error> { fn create(conn: &PgConnection, new_community: &CommunityForm) -> Result<Self, Error> {

5
server/lemmy_db/src/post.rs
View File

@ -162,8 +162,9 @@ impl Crud<PostForm> for Post {
post.find(post_id).first::<Self>(conn) post.find(post_id).first::<Self>(conn)
} }
fn delete(_conn: &PgConnection, _post_id: i32) -> Result<usize, Error> { fn delete(conn: &PgConnection, post_id: i32) -> Result<usize, Error> {
unimplemented!() use crate::schema::post::dsl::*;
diesel::delete(post.find(post_id)).execute(conn)
} }
fn create(conn: &PgConnection, new_post: &PostForm) -> Result<Self, Error> { fn create(conn: &PgConnection, new_post: &PostForm) -> Result<Self, Error> {

4
server/lemmy_db/src/user.rs
View File

@ -70,8 +70,8 @@ impl Crud<UserForm> for User_ {
fn read(conn: &PgConnection, user_id: i32) -> Result<Self, Error> { fn read(conn: &PgConnection, user_id: i32) -> Result<Self, Error> {
user_.find(user_id).first::<Self>(conn) user_.find(user_id).first::<Self>(conn)
} }
fn delete(_conn: &PgConnection, _user_id: i32) -> Result<usize, Error> { fn delete(conn: &PgConnection, user_id: i32) -> Result<usize, Error> {
unimplemented!() diesel::delete(user_.find(user_id)).execute(conn)
} }
fn create(conn: &PgConnection, form: &UserForm) -> Result<Self, Error> { fn create(conn: &PgConnection, form: &UserForm) -> Result<Self, Error> {
insert_into(user_).values(form).get_result::<Self>(conn) insert_into(user_).values(form).get_result::<Self>(conn)