Remove wildcard imports (in particular super::*) #93

nutomic · 2020-09-01T13:24:26Z

nutomic commented

2020-09-01 13:24:26 +00:00

These are annoying because its hard to see what is actually imported by a particular file. I thought I already did this before, but maybe that was only for database code? Anyway it would be nice to have a lint so we dont get the same thing in again in the future. There is clippy::wildcard_imports, but unfortunately that one is way too strict. Maybe we could just grep for use super::* in our CI and fail if that appears anywhere?

These are annoying because its hard to see what is actually imported by a particular file. I thought I already did this before, but maybe that was only for database code? Anyway it would be nice to have a lint so we dont get the same thing in again in the future. There is [clippy::wildcard_imports](https://rust-lang.github.io/rust-clippy/stable/index.html#wildcard_imports), but unfortunately that one is way too strict. Maybe we could just grep for `use super::*` in our CI and fail if that appears anywhere?

dessalines commented

2020-09-01 17:15:44 +00:00

Probably might need a grep for the character * in general.

Probably might need a grep for the character `*` in general.

dessalines commented

2020-09-01 17:17:42 +00:00

I don't know if its really worth it, there's ~100 of them, and many of them like prelude::* seem to be the preferred way to do it.

I don't know if its really worth it, there's ~100 of them, and many of them like `prelude::*` seem to be the preferred way to do it.

nutomic commented

2020-09-01 17:34:15 +00:00

I only want to get rid of use super::*, nothing else. I agree with you that getting rid of all wildcard imports would be a waste of time. There is a clippy lint for wildcard imports in general (the one I linked above), but not for the super::*.

I only want to get rid of `use super::*`, nothing else. I agree with you that getting rid of all wildcard imports would be a waste of time. There is a clippy lint for wildcard imports in general (the one I linked above), but not for the `super::*`.

dessalines commented

2020-09-01 17:42:49 +00:00

Ah gotcha.

nutomic manually merged commit 5d64dfd4dc into main

2020-09-01 21:47:35 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#93