Adding unique ap_ids. Fixes #1100 #90

dessalines · 2020-08-25T16:02:16Z

dessalines commented

2020-08-25 16:02:16 +00:00

No description provided.

dessalines reviewed 2020-08-25 16:03:22 +00:00

server/lemmy_db/src/comment.rs Outdated

						
				@ -62,3 +62,3 @@

				  fn create(conn: &PgConnection, comment_form: &CommentForm) -> Result<Self, Error> {

				    println!("creating {}", &comment_form.ap_id);

				    // println!("creating {}", &comment_form.ap_id.as_ref().unwrap());

dessalines commented

2020-08-25 16:03:22 +00:00

I had to comment this because it failed for some of the tests, where this ap_id is None.

I had to comment this because it failed for some of the tests, where this `ap_id` is None.

nutomic commented

2020-08-25 16:10:46 +00:00

Just put it into an if Some(ap_id) = form.ap_id?

Just put it into an `if Some(ap_id) = form.ap_id`?

dessalines reviewed 2020-08-25 16:03:50 +00:00

server/lemmy_db/src/comment.rs

						
				@ -46,3 +46,3 @@

				impl CommentForm {

				  pub fn get_ap_id(&self) -> Result<Url, ParseError> {

				    Url::parse(&self.ap_id)

				    Url::parse(&self.ap_id.as_ref().unwrap_or(&"not_a_url".to_string()))

dessalines commented

2020-08-25 16:03:50 +00:00

Seemed easier than doing -> Option<Result<Url...

Seemed easier than doing `-> Option<Result<Url...`

nutomic reviewed 2020-08-26 11:34:06 +00:00

server/lemmy_db/src/post.rs Outdated

						
				@ -186,1 +186,3 @@

				      .on_conflict_do_nothing()

				      .on_conflict(ap_id)

				      .do_update()

				      .set(post_form)

nutomic commented

2020-08-26 11:34:06 +00:00

I did it like this on purpose, because otherwise someone could abuse a Create activity to update a post. And under normal circumstances, the old and new post should be identical.

dessalines commented

2020-08-26 14:10:31 +00:00

Hrm... I spose this is the case for comments too. I'll change both, either way they should get real updates through the push, not the fetcher anyway, and the push looks like it correctly uses ::update.

Hrm... I spose this is the case for comments too. I'll change both, either way they should get real updates through the push, not the fetcher anyway, and the push looks like it correctly uses `::update`.