Migrate user/group to new activitystreams library #66

nutomic · 2020-07-03T12:34:52Z

nutomic commented

2020-07-03 12:34:52 +00:00

I'm not a fan of the take* methods. It might be good for performance, but makes the code more complicated imo.

Also I'm not sure how to use the methods in ApActorExt, like let mut person = Person::new(); person.set_endpoints(). I always get the following error, do I need a different kind of object for that?

error[E0599]: no method named `set_endpoints` found for struct `activitystreams_new::actor::Actor<activitystreams::actor::kind::PersonType>` in the current scope
--> src/apub/user.rs:62:8
|
62  |       .set_endpoints(endpoint_props)?;
|        ^^^^^^^^^^^^^ method not found in `activitystreams_new::actor::Actor<activitystreams::actor::kind::PersonType>`
|
::: /home/felix/.cargo/git/checkouts/activitystreams-sketch-b29e0c9dc9b9ce7d/99c7e9a/src/actor.rs:846:1
|
846 | pub struct Actor<Kind>(pub Object<Kind>);
| -----------------------------------------
| |
| doesn't satisfy `_: activitystreams_new::actor::ApActorExt<_>`
| doesn't satisfy `_: activitystreams_new::actor::AsApActor<_>`
|
= note: the method `set_endpoints` exists but the following trait bounds were not satisfied:
`activitystreams_new::actor::Actor<activitystreams::actor::kind::PersonType>: activitystreams_new::actor::AsApActor<_>`
which is required by `activitystreams_new::actor::Actor<activitystreams::actor::kind::PersonType>: activitystreams_new::actor::ApActorExt<_>`

I'm not a fan of the `take*` methods. It might be good for performance, but makes the code more complicated imo. Also I'm not sure how to use the methods in `ApActorExt`, like `let mut person = Person::new(); person.set_endpoints()`. I always get the following error, do I need a different kind of object for that? ``` error[E0599]: no method named `set_endpoints` found for struct `activitystreams_new::actor::Actor<activitystreams::actor::kind::PersonType>` in the current scope --> src/apub/user.rs:62:8 | 62 | .set_endpoints(endpoint_props)?; | ^^^^^^^^^^^^^ method not found in `activitystreams_new::actor::Actor<activitystreams::actor::kind::PersonType>` | ::: /home/felix/.cargo/git/checkouts/activitystreams-sketch-b29e0c9dc9b9ce7d/99c7e9a/src/actor.rs:846:1 | 846 | pub struct Actor<Kind>(pub Object<Kind>); | ----------------------------------------- | | | doesn't satisfy `_: activitystreams_new::actor::ApActorExt<_>` | doesn't satisfy `_: activitystreams_new::actor::AsApActor<_>` | = note: the method `set_endpoints` exists but the following trait bounds were not satisfied: `activitystreams_new::actor::Actor<activitystreams::actor::kind::PersonType>: activitystreams_new::actor::AsApActor<_>` which is required by `activitystreams_new::actor::Actor<activitystreams::actor::kind::PersonType>: activitystreams_new::actor::ApActorExt<_>` ```

nutomic commented

2020-07-03 15:36:53 +00:00

Second commit might have broken the federation test, its just stuck at Waiting for Lemmy to start....

Second commit might have broken the federation test, its just stuck at `Waiting for Lemmy to start...`.

nutomic changed title from ~~Migrate user to new activitystreams library~~ to Migrate user/group to new activitystreams library

2020-07-03 15:37:04 +00:00

nutomic reviewed 2020-07-06 17:56:24 +00:00

server/src/apub/community.rs Outdated

						
				@ -378,0 +373,4 @@

				    pool: &DbPool,

				  ) -> Result<Self, LemmyError> {

				    // TODO: this is probably gonna cause problems cause fetcher:292 also calls take_attributed_to()

				    let creator_and_moderator_uris = group.take_attributed_to().unwrap();

nutomic commented

2020-07-06 17:56:24 +00:00

This here seems problematic, because attributed_to is taken in two places.

This here seems problematic, because `attributed_to` is taken in two places.

dessalines commented

2020-07-08 15:04:03 +00:00

You called it. The fix was easier than expected, just call a clone:

let creator_and_moderator_uris = group.clone().take_attributed_to().unwrap();

The tests are passing now.

You called it. The fix was easier than expected, just call a clone: `let creator_and_moderator_uris = group.clone().take_attributed_to().unwrap();` The tests are passing now.

nutomic commented

2020-07-08 15:58:55 +00:00

Thanks! But I feel like this almost makes the take_* methods pointless, the performance that they give is probably all lost here.

Thanks! But I feel like this almost makes the `take_*` methods pointless, the performance that they give is probably all lost here.

nutomic commented

2020-07-08 22:58:01 +00:00

Btw I remembered that I forgot to remove the TODO here.

dessalines commented

2020-07-08 14:47:40 +00:00

Hrm I'm getting this error when testing:

lemmy-beta_1      | [2020-07-08T14:46:25Z DEBUG lemmy_server::apub] Checking http://lemmy-alpha:8540/u/lemmy_alpha
lemmy-alpha_1     | [2020-07-08T14:46:25Z INFO  actix_web::middleware::logger] 172.23.0.8:48828 "GET /u/lemmy_alpha HTTP/1.1" 200 112
3 "-" "-" 0.007529
lemmy-beta_1      | thread 'actix-rt:worker:2' panicked at 'called `Option::unwrap()` on a `None` value', src/apub/fetcher.rs:292:60

I'll investigate.

Hrm I'm getting this error when testing: ``` lemmy-beta_1 | [2020-07-08T14:46:25Z DEBUG lemmy_server::apub] Checking http://lemmy-alpha:8540/u/lemmy_alpha lemmy-alpha_1 | [2020-07-08T14:46:25Z INFO actix_web::middleware::logger] 172.23.0.8:48828 "GET /u/lemmy_alpha HTTP/1.1" 200 112 3 "-" "-" 0.007529 lemmy-beta_1 | thread 'actix-rt:worker:2' panicked at 'called `Option::unwrap()` on a `None` value', src/apub/fetcher.rs:292:60 ``` I'll investigate.

dessalines commented

2020-07-08 15:05:54 +00:00

That one clone was the only one necessary, and the tests are passing. When you add that, I'll merge.

dessalines manually merged commit d720993141 into master

2020-07-08 16:17:08 +00:00

nutomic referenced this pull request

2020-07-13 14:01:54 +00:00

Make reads from activitypub objects immutable #68

Sign in to join this conversation.

No reviewers

No Label

No Milestone