Replace isahc with attohttpc to remove curl (fixes #798) #52

nutomic · 2020-06-10T16:03:35Z

nutomic commented

2020-06-10 16:03:35 +00:00

This removes curl as a dependency. The compile doesnt get much faster for me, but it might help on computers with less CPU cores. And the fact is that we just dont need curl, something minimal like attohttpc is totally fine.

I tested to make sure that iframely embeds are still working.

Todo:

add the change to config config below
open an issue to make brotli optional in actix
check what's slow in the release build
try to optimise the deps of activitystreams?

This removes curl as a dependency. The compile doesnt get much faster for me, but it might help on computers with less CPU cores. And the fact is that we just dont need curl, something minimal like attohttpc is totally fine. I tested to make sure that iframely embeds are still working. Todo: - add the change to config config below - open an issue to make brotli optional in actix - check what's slow in the release build - try to optimise the deps of activitystreams?

nutomic commented

2020-06-10 16:55:33 +00:00

Gotta head out but heres another dep we dont need:

-config = "0.10.1"
-hjson = "0.8.2"
+config = {version = "0.10.1", default-features = false, features = ["hjson"] }

Gotta head out but heres another dep we dont need: ``` -config = "0.10.1" -hjson = "0.8.2" +config = {version = "0.10.1", default-features = false, features = ["hjson"] } ```

dessalines commented

2020-06-10 18:38:30 +00:00

Let me know if this ones ready, or you want me to wait on those other todos.

dessalines commented

2020-06-10 18:42:09 +00:00

Also just a side note / reminder, but try to work against github issues. Every commit or PR should be closing a github issue. This one might be https://github.com/LemmyNet/lemmy/issues/798

nutomic commented

2020-06-11 11:37:05 +00:00

Okay this is good to merge. I opened an issue at actix-http about the brotli dep here. But I think the only way to significantly reduce compile time would be if we replace diesel and/or actix.

I did reference that issue in my commit, so it should be all good.

Okay this is good to merge. I opened an issue at actix-http about the brotli dep [here](https://github.com/actix/actix-web/issues/1561). But I think the only way to significantly reduce compile time would be if we replace diesel and/or actix. I did reference that issue in my commit, so it should be all good.

dessalines commented

2020-06-11 13:59:56 +00:00

I'm compiling and testing this rn.

dessalines closed this pull request

2020-06-11 14:14:03 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#52