LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Adding post and comment ap_id columns. #31

Closed
dessalines wants to merge 0 commits from federation_add_fed_columns into federation
pull from: federation_add_fed_columns
merge into: LemmyNet:federation
Conversation 1 Commits - Files Changed 196 +4404 -17302
dessalines commented 2020-04-04 00:07:43 +00:00
Owner
Copy Link
No description provided.
dessalines reviewed 2020-04-04 00:09:30 +00:00
server/src/apub/mod.rs Outdated
@ -36,0 +34,4 @@
EndpointType::Community => "community",
EndpointType::User => "user",
EndpointType::Post => "post",
EndpointType::Comment => "comment",
dessalines commented 2020-04-04 00:09:30 +00:00
Author
Owner
Copy Link

@nutomic I changed these to their full names, they're urls so no reason to not be explicit, and /c/ could be either a community or a comment.

@nutomic I changed these to their full names, they're urls so no reason to not be explicit, and /c/ could be either a community or a comment.
nutomic commented 2020-04-07 11:11:37 +00:00
Owner
Copy Link

Not gonna work, you would have to change them in routes/federation.rs as well. Anyway I think we will have to change the URLs so that they are the same for html and activity+json content types, so that you can simply copy the URL into the Masto search and have it fetch the object.

Not gonna work, you would have to change them in routes/federation.rs as well. Anyway I think we will have to change the URLs so that they are the same for html and activity+json content types, so that you can simply copy the URL into the Masto search and have it fetch the object.
nutomic commented 2020-04-07 11:15:49 +00:00
Owner
Copy Link

Gonna revert this for now, anyway we are not federating comments yet.

Gonna revert this for now, anyway we are not federating comments yet.
dessalines reviewed 2020-04-04 02:12:37 +00:00
server/src/db/comment.rs
@ -71,0 +103,4 @@
))
.get_result::<Self>(conn)
}
}
dessalines commented 2020-04-04 02:12:37 +00:00
Author
Owner
Copy Link

Added some helper DB methods.

Added some helper DB methods.
nutomic commented 2020-04-07 11:03:11 +00:00
Owner
Copy Link

Could you explain how you imagine this to work with federation?

Could you explain how you imagine this to work with federation?
dessalines commented 2020-04-07 15:00:13 +00:00
Author
Owner
Copy Link

Activitypub calls deletes "tombstones" I think, and it'll have to post that to all its recipients.

Activitypub calls deletes "tombstones" I think, and it'll have to post that to all its recipients.
nutomic commented 2020-04-07 15:38:38 +00:00
Owner
Copy Link

Ah okay, thats still far away. And the update_ap_id() method is for db migrations or on comment creation then, I see.

Ah okay, thats still far away. And the update_ap_id() method is for db migrations or on comment creation then, I see.
dessalines reviewed 2020-04-04 02:13:08 +00:00
server/src/db/post.rs
@ -61,0 +72,4 @@
diesel::update(post.find(post_id))
.set(ap_id.eq(apid))
.get_result::<Self>(conn)
}
dessalines commented 2020-04-04 02:13:08 +00:00
Author
Owner
Copy Link

Necessary since the post ap_id comes from the row id.

Necessary since the post ap_id comes from the row id.
nutomic commented 2020-04-07 11:04:22 +00:00
Owner
Copy Link

Necessary in what case?

Necessary in what case?
dessalines commented 2020-04-07 15:02:41 +00:00
Author
Owner
Copy Link

You mean why a post needs an activitypub id? Our instance might have local posts, or federated ones. The local ones can use this helper method, the federated ones that we receive will have their external ones here.

You mean why a post needs an activitypub id? Our instance might have local posts, or federated ones. The local ones can use this helper method, the federated ones that we receive will have their external ones here.
nutomic closed this pull request 2020-04-07 15:32:25 +00:00
nutomic reopened this pull request 2020-04-07 15:32:56 +00:00
nutomic commented 2020-04-07 15:36:29 +00:00
Owner
Copy Link

Okay merged.

Okay merged.
nutomic closed this pull request 2020-04-07 15:36:29 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#31
No description provided.
Delete Branch "federation_add_fed_columns"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?