LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Implement SQL connection pool #2

Closed
nutomic wants to merge 0 commits from nutomic:sql-connection-pool into master
pull from: nutomic:sql-connection-pool
merge into: LemmyNet:master
Conversation 4 Commits - Files Changed 307 +10663 -26149
nutomic commented 2019-12-15 23:19:33 +00:00
Owner
Copy Link

Depends on #1

I couldnt install ab locally because https://aur.archlinux.org/ is down (and I dont want to install all of apache), but I'm certain that this fixes the performance problem I mentioned.

Btw is it normal that all of my PRs have huge diffs in Cargo.lock, or should I exclude that?

Depends on #1 I couldnt install ab locally because https://aur.archlinux.org/ is down (and I dont want to install all of apache), but I'm certain that this fixes the performance problem I mentioned. Btw is it normal that all of my PRs have huge diffs in Cargo.lock, or should I exclude that?
dessalines commented 2019-12-16 01:20:06 +00:00
Owner
Copy Link

Damn nice! I just added r2d2 to another rust project, I have no idea why I didn't add it to this one. This looks great tho.

1 question, with the ConnectionManager, is it correct to just let it alone, or add a specific number of connections for the pool? We can always tweak later if we don't know the answer.

Damn nice! I just added r2d2 to another rust project, I have no idea why I didn't add it to this one. This looks great tho. 1 question, with the `ConnectionManager`, is it correct to just let it alone, or add a specific number of connections for the pool? We can always tweak later if we don't know the answer.
nutomic commented 2019-12-16 09:33:08 +00:00
Author
Owner
Copy Link

The docs say it uses a maximum of 10 connections by default.

https://docs.diesel.rs/diesel/r2d2/struct.Builder.html#method.max_size

The docs say it uses a maximum of 10 connections by default. https://docs.diesel.rs/diesel/r2d2/struct.Builder.html#method.max_size
nutomic commented 2019-12-17 16:33:58 +00:00
Author
Owner
Copy Link

Added a config option for the sql pool size, with the same default that is used by Peertube.

Added a config option for the sql pool size, with the same default that is used by Peertube.
nutomic commented 2019-12-17 16:43:44 +00:00
Author
Owner
Copy Link

I added a new commit with comments in the config, didnt want to open a new pr. Please check that change, especially the part about rate limits is kind of confusing, and i dont know if i understood the jwt token correctly.

I added a new commit with comments in the config, didnt want to open a new pr. Please check that change, especially the part about rate limits is kind of confusing, and i dont know if i understood the jwt token correctly.
nutomic added a new dependency 2019-12-17 16:43:50 +00:00
#1 Implement config
nutomic added a new dependency 2019-12-17 21:37:22 +00:00
#3 Add documentation for Config and update Docker/Ansible files
nutomic closed this pull request 2019-12-28 22:10:57 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#3 Add documentation for Config and update Docker/Ansible files
LemmyNet/lemmy
Depends on
#1 Implement config
LemmyNet/lemmy
Reference: LemmyNet/lemmy#2
No description provided.
Delete Branch "nutomic:sql-connection-pool"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?